| Message ID | 20200703092143.165594-1-kwolf@redhat.com |
|---|---|
| State | New |
| Headers | show |
Patchew URL: https://patchew.org/QEMU/20200703092143.165594-1-kwolf@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PULL 0/7] Block layer patches
Type: series
Message-id: 20200703092143.165594-1-kwolf@redhat.com
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
From https://github.com/patchew-project/qemu
* [new tag] patchew/20200703092143.165594-1-kwolf@redhat.com -> patchew/20200703092143.165594-1-kwolf@redhat.com
Switched to a new branch 'test'
65e6f15 iotests: Fix 051 output after qdev_init_nofail() removal
cfd78ce iotests.py: Do not wait() before communicate()
0d0a798 vvfat: Fix array_remove_slice()
577c411 vvfat: Check that updated filenames are valid
0397c54 qemu-storage-daemon: add missing cleanup calls
f46fc30 qemu-storage-daemon: remember to add qemu_object_opts
aeda507 qemu-img convert: Don't pre-zero images
=== OUTPUT BEGIN ===
1/7 Checking commit aeda507d8d8c (qemu-img convert: Don't pre-zero images)
2/7 Checking commit f46fc3018757 (qemu-storage-daemon: remember to add qemu_object_opts)
3/7 Checking commit 0397c541a85e (qemu-storage-daemon: add missing cleanup calls)
4/7 Checking commit 577c411e9268 (vvfat: Check that updated filenames are valid)
ERROR: "(foo*)" should be "(foo *)"
#34: FILE: block/vvfat.c:526:
+ if (!strcmp((const char*)name, ".") || !strcmp((const char*)name, "..")) {
total: 1 errors, 0 warnings, 42 lines checked
Patch 4/7 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/7 Checking commit 0d0a798db814 (vvfat: Fix array_remove_slice())
6/7 Checking commit cfd78ce3cf07 (iotests.py: Do not wait() before communicate())
7/7 Checking commit 65e6f15ad9ab (iotests: Fix 051 output after qdev_init_nofail() removal)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20200703092143.165594-1-kwolf@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
On Fri, 3 Jul 2020 at 10:21, Kevin Wolf <kwolf@redhat.com> wrote: > > The following changes since commit 64f0ad8ad8e13257e7c912df470d46784b55c3fd: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2020-07-02' into staging (2020-07-02 15:54:09 +0100) > > are available in the Git repository at: > > git://repo.or.cz/qemu/kevin.git tags/for-upstream > > for you to fetch changes up to 4f071a9460886667fde061c05b79dc786cc22e3c: > > iotests: Fix 051 output after qdev_init_nofail() removal (2020-07-03 10:06:29 +0200) > > ---------------------------------------------------------------- > Block layer patches: > > - qemu-img convert: Don't pre-zero images (removes nowadays > counterproductive optimisation) > - qemu-storage-daemon: Fix object-del, cleaner shutdown > - vvfat: Check that the guest doesn't escape the given host directory > with read-write vvfat drives > - vvfat: Fix crash by out-of-bounds array writes for read-write drives > - iotests fixes > Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/5.1 for any user-visible changes. -- PMM
The following changes since commit 64f0ad8ad8e13257e7c912df470d46784b55c3fd: Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2020-07-02' into staging (2020-07-02 15:54:09 +0100) are available in the Git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you to fetch changes up to 4f071a9460886667fde061c05b79dc786cc22e3c: iotests: Fix 051 output after qdev_init_nofail() removal (2020-07-03 10:06:29 +0200) ---------------------------------------------------------------- Block layer patches: - qemu-img convert: Don't pre-zero images (removes nowadays counterproductive optimisation) - qemu-storage-daemon: Fix object-del, cleaner shutdown - vvfat: Check that the guest doesn't escape the given host directory with read-write vvfat drives - vvfat: Fix crash by out-of-bounds array writes for read-write drives - iotests fixes ---------------------------------------------------------------- Kevin Wolf (3): qemu-img convert: Don't pre-zero images vvfat: Check that updated filenames are valid vvfat: Fix array_remove_slice() Max Reitz (1): iotests.py: Do not wait() before communicate() Philippe Mathieu-Daudé (1): iotests: Fix 051 output after qdev_init_nofail() removal Stefan Hajnoczi (2): qemu-storage-daemon: remember to add qemu_object_opts qemu-storage-daemon: add missing cleanup calls block/vvfat.c | 67 +++++++++++++++++++------------------------ qemu-img.c | 9 ------ qemu-storage-daemon.c | 5 ++++ tests/qemu-iotests/iotests.py | 34 +++++++++++----------- tests/qemu-iotests/051.pc.out | 4 +-- 5 files changed, 53 insertions(+), 66 deletions(-)