| Message ID | 20200128175342.9066-2-pbonzini@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | Proof of concept for Meson integration | expand |
-EMISSINGPATCHDESCRIPTION Why is this required? Bug fix? New feature? ... please add some words here. Thomas On 28/01/2020 18.51, Paolo Bonzini wrote: > From: Marc-André Lureau <marcandre.lureau@redhat.com> > > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > --- > scripts/minikconf.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/minikconf.py b/scripts/minikconf.py > index 40ae1989e1..febd9a479f 100644 > --- a/scripts/minikconf.py > +++ b/scripts/minikconf.py > @@ -645,7 +645,7 @@ class KconfigParser: > self.cursor = self.src.find('\n', self.cursor) > self.val = self.src[start:self.cursor] > return TOK_SOURCE > - elif self.tok.isalpha(): > + elif self.tok.isalnum(): > # identifier > while self.src[self.cursor].isalnum() or self.src[self.cursor] == '_': > self.cursor += 1 >
Hi On Wed, Jan 29, 2020 at 1:09 PM Thomas Huth <thuth@redhat.com> wrote: > > > -EMISSINGPATCHDESCRIPTION > > Why is this required? Bug fix? New feature? ... please add some words here. This is required for later patch "meson: convert hw/9pfs", which adds config 9PFS. You are right, several patches could use some comments. It's still PoC. Otoh, a lot of them are quite mechanical or just what they are in meson, there isn't much to say about it. We'll have to improve this somehow. > Thomas > > > On 28/01/2020 18.51, Paolo Bonzini wrote: > > From: Marc-André Lureau <marcandre.lureau@redhat.com> > > > > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > > --- > > scripts/minikconf.py | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/scripts/minikconf.py b/scripts/minikconf.py > > index 40ae1989e1..febd9a479f 100644 > > --- a/scripts/minikconf.py > > +++ b/scripts/minikconf.py > > @@ -645,7 +645,7 @@ class KconfigParser: > > self.cursor = self.src.find('\n', self.cursor) > > self.val = self.src[start:self.cursor] > > return TOK_SOURCE > > - elif self.tok.isalpha(): > > + elif self.tok.isalnum(): > > # identifier > > while self.src[self.cursor].isalnum() or self.src[self.cursor] == '_': > > self.cursor += 1 > > >
On 29/01/2020 14.41, Marc-André Lureau wrote: > Hi > > On Wed, Jan 29, 2020 at 1:09 PM Thomas Huth <thuth@redhat.com> wrote: >> >> >> -EMISSINGPATCHDESCRIPTION >> >> Why is this required? Bug fix? New feature? ... please add some words here. > > This is required for later patch "meson: convert hw/9pfs", which adds > config 9PFS. > > You are right, several patches could use some comments. It's still > PoC. Otoh, a lot of them are quite mechanical or just what they are in > meson, there isn't much to say about it. We'll have to improve this > somehow. Sure, but with a proper patch description, this patch here could even be merged today already, shrinking this huge patch series by one at least... Thomas
Hi On Wed, Jan 29, 2020 at 2:47 PM Thomas Huth <thuth@redhat.com> wrote: > > On 29/01/2020 14.41, Marc-André Lureau wrote: > > Hi > > > > On Wed, Jan 29, 2020 at 1:09 PM Thomas Huth <thuth@redhat.com> wrote: > >> > >> > >> -EMISSINGPATCHDESCRIPTION > >> > >> Why is this required? Bug fix? New feature? ... please add some words here. > > > > This is required for later patch "meson: convert hw/9pfs", which adds > > config 9PFS. > > > > You are right, several patches could use some comments. It's still > > PoC. Otoh, a lot of them are quite mechanical or just what they are in > > meson, there isn't much to say about it. We'll have to improve this > > somehow. > > Sure, but with a proper patch description, this patch here could even be > merged today already, shrinking this huge patch series by one at least... > Paolo has been merging many preliminary patches already. I am not sure why that one wasn't. We have also done some preliminary work in meson too, and continue to do.
On 29/01/20 15:04, Marc-André Lureau wrote: >> Sure, but with a proper patch description, this patch here could even be >> merged today already, shrinking this huge patch series by one at least... > > Paolo has been merging many preliminary patches already. I am not sure > why that one wasn't. I'm no sure myself why I didn't pick up this one, probably because of the lack of commit message. :) Paolo
diff --git a/scripts/minikconf.py b/scripts/minikconf.py index 40ae1989e1..febd9a479f 100644 --- a/scripts/minikconf.py +++ b/scripts/minikconf.py @@ -645,7 +645,7 @@ class KconfigParser: self.cursor = self.src.find('\n', self.cursor) self.val = self.src[start:self.cursor] return TOK_SOURCE - elif self.tok.isalpha(): + elif self.tok.isalnum(): # identifier while self.src[self.cursor].isalnum() or self.src[self.cursor] == '_': self.cursor += 1