Message ID | 20190522044600.16534-1-david@gibson.dropbear.id.au |
---|---|
State | New |
Headers | show |
On Wed, 22 May 2019 at 05:46, David Gibson <david@gibson.dropbear.id.au> wrote: > > The following changes since commit a4f667b6714916683408b983cfe0a615a725775f: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20190521-3' into staging (2019-05-21 16:30:13 +0100) > > are available in the Git repository at: > > git://github.com/dgibson/qemu.git tags/ppc-for-4.1-20190522 > > for you to fetch changes up to 885659103ad9e1b0460e89c548e9fb823b007b7e: > > docs: provide documentation on the POWER9 XIVE interrupt controller (2019-05-22 10:38:22 +1000) > > ---------------------------------------------------------------- > ppc patch queue 2019-05-22 > > Next pull request against qemu-4.1. Highlights: > * KVM accelerated support for the XIVE interrupt controller in PAPR > guests > * A number of TCG vector fixes > * Fixes for the PReP / 40p machine > > Other than that it's just a bunch of assorted fixes, cleanups and > minor improvements. > > This supersedes the pull request dated 2019-05-21. I've dropped the > headers update, since it had a mistake, but is now made redundant by a > similar update in Cornelia's applied PR. I've also added a patch with > extra documentation for the XIVE interrupt controller, and fixed a > couple of minor style errors in the previous PR. > > ---------------------------------------------------------------- Hi -- this failed 'make check-tcg' for the linux-static build (x86-64 host): TEST linux-test on ppc64abi32 qemu-ppc64abi32: /home/petmay01/linaro/qemu-for-merges/accel/tcg/cpu-exec.c:700: cpu_exec: Assertion `!have_mmap_lock()' failed. qemu-ppc64abi32: /home/petmay01/linaro/qemu-for-merges/accel/tcg/cpu-exec.c:700: cpu_exec: Assertion `!have_mmap_lock()' failed. /home/petmay01/linaro/qemu-for-merges/tests/tcg/Makefile:122: recipe for target 'run-linux-test' failed thanks -- PMM
On Thu, May 23, 2019 at 10:29:57AM +0100, Peter Maydell wrote: > On Wed, 22 May 2019 at 05:46, David Gibson <david@gibson.dropbear.id.au> wrote: > > > > The following changes since commit a4f667b6714916683408b983cfe0a615a725775f: > > > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20190521-3' into staging (2019-05-21 16:30:13 +0100) > > > > are available in the Git repository at: > > > > git://github.com/dgibson/qemu.git tags/ppc-for-4.1-20190522 > > > > for you to fetch changes up to 885659103ad9e1b0460e89c548e9fb823b007b7e: > > > > docs: provide documentation on the POWER9 XIVE interrupt controller (2019-05-22 10:38:22 +1000) > > > > ---------------------------------------------------------------- > > ppc patch queue 2019-05-22 > > > > Next pull request against qemu-4.1. Highlights: > > * KVM accelerated support for the XIVE interrupt controller in PAPR > > guests > > * A number of TCG vector fixes > > * Fixes for the PReP / 40p machine > > > > Other than that it's just a bunch of assorted fixes, cleanups and > > minor improvements. > > > > This supersedes the pull request dated 2019-05-21. I've dropped the > > headers update, since it had a mistake, but is now made redundant by a > > similar update in Cornelia's applied PR. I've also added a patch with > > extra documentation for the XIVE interrupt controller, and fixed a > > couple of minor style errors in the previous PR. > > > > ---------------------------------------------------------------- > > Hi -- this failed 'make check-tcg' for the linux-static build > (x86-64 host): > > TEST linux-test on ppc64abi32 > qemu-ppc64abi32: > /home/petmay01/linaro/qemu-for-merges/accel/tcg/cpu-exec.c:700: > cpu_exec: Assertion `!have_mmap_lock()' failed. > qemu-ppc64abi32: > /home/petmay01/linaro/qemu-for-merges/accel/tcg/cpu-exec.c:700: > cpu_exec: Assertion `!have_mmap_lock()' failed. > /home/petmay01/linaro/qemu-for-merges/tests/tcg/Makefile:122: recipe > for target 'run-linux-test' failed Bother. I did run a make check-tcg on an x86_64 host, and didn't see this. Investigating...
On Fri, May 24, 2019 at 10:46:16AM +1000, David Gibson wrote: > On Thu, May 23, 2019 at 10:29:57AM +0100, Peter Maydell wrote: > > On Wed, 22 May 2019 at 05:46, David Gibson <david@gibson.dropbear.id.au> wrote: > > > > > > The following changes since commit a4f667b6714916683408b983cfe0a615a725775f: > > > > > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20190521-3' into staging (2019-05-21 16:30:13 +0100) > > > > > > are available in the Git repository at: > > > > > > git://github.com/dgibson/qemu.git tags/ppc-for-4.1-20190522 > > > > > > for you to fetch changes up to 885659103ad9e1b0460e89c548e9fb823b007b7e: > > > > > > docs: provide documentation on the POWER9 XIVE interrupt controller (2019-05-22 10:38:22 +1000) > > > > > > ---------------------------------------------------------------- > > > ppc patch queue 2019-05-22 > > > > > > Next pull request against qemu-4.1. Highlights: > > > * KVM accelerated support for the XIVE interrupt controller in PAPR > > > guests > > > * A number of TCG vector fixes > > > * Fixes for the PReP / 40p machine > > > > > > Other than that it's just a bunch of assorted fixes, cleanups and > > > minor improvements. > > > > > > This supersedes the pull request dated 2019-05-21. I've dropped the > > > headers update, since it had a mistake, but is now made redundant by a > > > similar update in Cornelia's applied PR. I've also added a patch with > > > extra documentation for the XIVE interrupt controller, and fixed a > > > couple of minor style errors in the previous PR. > > > > > > ---------------------------------------------------------------- > > > > Hi -- this failed 'make check-tcg' for the linux-static build > > (x86-64 host): > > > > TEST linux-test on ppc64abi32 > > qemu-ppc64abi32: > > /home/petmay01/linaro/qemu-for-merges/accel/tcg/cpu-exec.c:700: > > cpu_exec: Assertion `!have_mmap_lock()' failed. > > qemu-ppc64abi32: > > /home/petmay01/linaro/qemu-for-merges/accel/tcg/cpu-exec.c:700: > > cpu_exec: Assertion `!have_mmap_lock()' failed. > > /home/petmay01/linaro/qemu-for-merges/tests/tcg/Makefile:122: recipe > > for target 'run-linux-test' failed > > Bother. I did run a make check-tcg on an x86_64 host, and didn't see > this. Investigating... BUILD TCG tests for ppc64abi32-linux-user BUILD ppc64abi32 guest-tests SKIPPED RUN TCG tests for ppc64abi32-linux-user RUN tests for ppc64abi32 SKIPPED Well, that explains why I didn't see it. I'm using the docker setup for check-tcg, but it's not clear to me what bits I need to run the ppc64abi32 tests.
On Fri, May 24, 2019 at 12:17:25PM +1000, David Gibson wrote: > On Fri, May 24, 2019 at 10:46:16AM +1000, David Gibson wrote: > > On Thu, May 23, 2019 at 10:29:57AM +0100, Peter Maydell wrote: > > > On Wed, 22 May 2019 at 05:46, David Gibson <david@gibson.dropbear.id.au> wrote: > > > > > > > > The following changes since commit a4f667b6714916683408b983cfe0a615a725775f: > > > > > > > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20190521-3' into staging (2019-05-21 16:30:13 +0100) > > > > > > > > are available in the Git repository at: > > > > > > > > git://github.com/dgibson/qemu.git tags/ppc-for-4.1-20190522 > > > > > > > > for you to fetch changes up to 885659103ad9e1b0460e89c548e9fb823b007b7e: > > > > > > > > docs: provide documentation on the POWER9 XIVE interrupt controller (2019-05-22 10:38:22 +1000) > > > > > > > > ---------------------------------------------------------------- > > > > ppc patch queue 2019-05-22 > > > > > > > > Next pull request against qemu-4.1. Highlights: > > > > * KVM accelerated support for the XIVE interrupt controller in PAPR > > > > guests > > > > * A number of TCG vector fixes > > > > * Fixes for the PReP / 40p machine > > > > > > > > Other than that it's just a bunch of assorted fixes, cleanups and > > > > minor improvements. > > > > > > > > This supersedes the pull request dated 2019-05-21. I've dropped the > > > > headers update, since it had a mistake, but is now made redundant by a > > > > similar update in Cornelia's applied PR. I've also added a patch with > > > > extra documentation for the XIVE interrupt controller, and fixed a > > > > couple of minor style errors in the previous PR. > > > > > > > > ---------------------------------------------------------------- > > > > > > Hi -- this failed 'make check-tcg' for the linux-static build > > > (x86-64 host): > > > > > > TEST linux-test on ppc64abi32 > > > qemu-ppc64abi32: > > > /home/petmay01/linaro/qemu-for-merges/accel/tcg/cpu-exec.c:700: > > > cpu_exec: Assertion `!have_mmap_lock()' failed. > > > qemu-ppc64abi32: > > > /home/petmay01/linaro/qemu-for-merges/accel/tcg/cpu-exec.c:700: > > > cpu_exec: Assertion `!have_mmap_lock()' failed. > > > /home/petmay01/linaro/qemu-for-merges/tests/tcg/Makefile:122: recipe > > > for target 'run-linux-test' failed > > > > Bother. I did run a make check-tcg on an x86_64 host, and didn't see > > this. Investigating... > > BUILD TCG tests for ppc64abi32-linux-user > BUILD ppc64abi32 guest-tests SKIPPED > RUN TCG tests for ppc64abi32-linux-user > RUN tests for ppc64abi32 SKIPPED > > Well, that explains why I didn't see it. I'm using the docker setup > for check-tcg, but it's not clear to me what bits I need to run the > ppc64abi32 tests. What I can find seems to imply that it should use a a 32-bit ppc target compiler, but if I do that the test SEGVs on master, not just on my branch. I'm having a lot of trouble even figuring out what the ppc64abi32 target is supposed to be about.