| Message ID | 20190426172421.27133-1-richard.henderson@linaro.org |
|---|---|
| State | New |
| Headers | show |
Patchew URL: https://patchew.org/QEMU/20190426172421.27133-1-richard.henderson@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20190426172421.27133-1-richard.henderson@linaro.org
Subject: [Qemu-devel] [PULL 00/15] tcg patch queue
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20190426172421.27133-1-richard.henderson@linaro.org -> patchew/20190426172421.27133-1-richard.henderson@linaro.org
Switched to a new branch 'test'
3b5fbad27a cputlb: Fix io_readx() to respect the access_type
b5538c441b tcg/arm: Restrict constant pool displacement to 12 bits
d42c651923 tcg/ppc: Allow the constant pool to overflow at 32k
0c1b8687b1 tcg: Restart TB generation after out-of-line ldst overflow
e21b05fbc8 tcg: Restart TB generation after constant pool overflow
7c567fa038 tcg: Restart TB generation after relocation overflow
8ec60692fc tcg: Restart after TB code generation overflow
e204222382 tcg: Hoist max_insns computation to tb_gen_code
498c455395 tcg/aarch64: Support INDEX_op_extract2_{i32, i64}
e132577400 tcg/arm: Support INDEX_op_extract2_i32
c312fddc72 tcg/i386: Support INDEX_op_extract2_{i32, i64}
29311ac09e tcg: Use extract2 in tcg_gen_deposit_{i32, i64}
1dcf4ab4f1 tcg: Use deposit and extract2 in tcg_gen_shifti_i64
1ac2ae251b tcg: Add INDEX_op_extract2_{i32,i64}
12e84a540d tcg: Implement tcg_gen_extract2_{i32, i64}
=== OUTPUT BEGIN ===
1/15 Checking commit 12e84a540d21 (tcg: Implement tcg_gen_extract2_{i32, i64})
2/15 Checking commit 1ac2ae251b21 (tcg: Add INDEX_op_extract2_{i32,i64})
ERROR: spaces required around that ':' (ctx:VxE)
#111: FILE: tcg/optimize.c:1205:
+ CASE_OP_32_64(extract2):
^
total: 1 errors, 0 warnings, 207 lines checked
Patch 2/15 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/15 Checking commit 1dcf4ab4f1d3 (tcg: Use deposit and extract2 in tcg_gen_shifti_i64)
4/15 Checking commit 29311ac09eb0 (tcg: Use extract2 in tcg_gen_deposit_{i32, i64})
5/15 Checking commit c312fddc729f (tcg/i386: Support INDEX_op_extract2_{i32, i64})
ERROR: spaces required around that ':' (ctx:VxE)
#48: FILE: tcg/i386/tcg-target.inc.c:2591:
+ OP_32_64(extract2):
^
total: 1 errors, 0 warnings, 51 lines checked
Patch 5/15 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/15 Checking commit e13257740058 (tcg/arm: Support INDEX_op_extract2_i32)
7/15 Checking commit 498c455395dc (tcg/aarch64: Support INDEX_op_extract2_{i32, i64})
8/15 Checking commit e204222382ef (tcg: Hoist max_insns computation to tb_gen_code)
9/15 Checking commit 8ec60692fce4 (tcg: Restart after TB code generation overflow)
10/15 Checking commit 7c567fa0386d (tcg: Restart TB generation after relocation overflow)
11/15 Checking commit e21b05fbc853 (tcg: Restart TB generation after constant pool overflow)
12/15 Checking commit 0c1b8687b192 (tcg: Restart TB generation after out-of-line ldst overflow)
13/15 Checking commit d42c651923aa (tcg/ppc: Allow the constant pool to overflow at 32k)
14/15 Checking commit b5538c441b12 (tcg/arm: Restrict constant pool displacement to 12 bits)
15/15 Checking commit 3b5fbad27a48 (cputlb: Fix io_readx() to respect the access_type)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20190426172421.27133-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
On Fri, 26 Apr 2019 at 18:24, Richard Henderson <richard.henderson@linaro.org> wrote: > > The following changes since commit 3284aa128153750f14a61e8a96fd085e6f2999b6: > > Merge remote-tracking branch 'remotes/lersek/tags/edk2-pull-2019-04-22' into staging (2019-04-24 13:19:41 +0100) > > are available in the Git repository at: > > https://github.com/rth7680/qemu.git tags/pull-tcg-20190426 > > for you to fetch changes up to ef5dae6805cce7b59d129d801bdc5db71bcbd60d: > > cputlb: Fix io_readx() to respect the access_type (2019-04-25 10:40:06 -0700) > > ---------------------------------------------------------------- > Add tcg_gen_extract2_*. > Deal with overflow of TranslationBlocks. > Respect access_type in io_readx. > > ---------------------------------------------------------------- Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/4.1 for any user-visible changes. -- PMM
The following changes since commit 3284aa128153750f14a61e8a96fd085e6f2999b6: Merge remote-tracking branch 'remotes/lersek/tags/edk2-pull-2019-04-22' into staging (2019-04-24 13:19:41 +0100) are available in the Git repository at: https://github.com/rth7680/qemu.git tags/pull-tcg-20190426 for you to fetch changes up to ef5dae6805cce7b59d129d801bdc5db71bcbd60d: cputlb: Fix io_readx() to respect the access_type (2019-04-25 10:40:06 -0700) ---------------------------------------------------------------- Add tcg_gen_extract2_*. Deal with overflow of TranslationBlocks. Respect access_type in io_readx. ---------------------------------------------------------------- David Hildenbrand (1): tcg: Implement tcg_gen_extract2_{i32,i64} Richard Henderson (13): tcg: Add INDEX_op_extract2_{i32,i64} tcg: Use deposit and extract2 in tcg_gen_shifti_i64 tcg: Use extract2 in tcg_gen_deposit_{i32,i64} tcg/i386: Support INDEX_op_extract2_{i32,i64} tcg/arm: Support INDEX_op_extract2_i32 tcg/aarch64: Support INDEX_op_extract2_{i32,i64} tcg: Hoist max_insns computation to tb_gen_code tcg: Restart after TB code generation overflow tcg: Restart TB generation after relocation overflow tcg: Restart TB generation after constant pool overflow tcg: Restart TB generation after out-of-line ldst overflow tcg/ppc: Allow the constant pool to overflow at 32k tcg/arm: Restrict constant pool displacement to 12 bits Shahab Vahedi (1): cputlb: Fix io_readx() to respect the access_type include/exec/exec-all.h | 4 +- include/exec/translator.h | 3 +- tcg/aarch64/tcg-target.h | 2 + tcg/arm/tcg-target.h | 1 + tcg/i386/tcg-target.h | 2 + tcg/mips/tcg-target.h | 2 + tcg/ppc/tcg-target.h | 2 + tcg/riscv/tcg-target.h | 2 + tcg/s390/tcg-target.h | 2 + tcg/sparc/tcg-target.h | 2 + tcg/tcg-op.h | 6 ++ tcg/tcg-opc.h | 2 + tcg/tcg.h | 16 +++--- tcg/tci/tcg-target.h | 2 + accel/tcg/cputlb.c | 5 +- accel/tcg/translate-all.c | 53 ++++++++++++++--- accel/tcg/translator.c | 15 +---- target/alpha/translate.c | 4 +- target/arm/translate.c | 4 +- target/cris/translate.c | 10 +--- target/hppa/translate.c | 5 +- target/i386/translate.c | 4 +- target/lm32/translate.c | 10 +--- target/m68k/translate.c | 4 +- target/microblaze/translate.c | 10 +--- target/mips/translate.c | 4 +- target/moxie/translate.c | 11 +--- target/nios2/translate.c | 14 +---- target/openrisc/translate.c | 4 +- target/ppc/translate.c | 4 +- target/riscv/translate.c | 4 +- target/s390x/translate.c | 4 +- target/sh4/translate.c | 4 +- target/sparc/translate.c | 4 +- target/tilegx/translate.c | 12 +--- target/tricore/translate.c | 16 +----- target/unicore32/translate.c | 10 +--- target/xtensa/translate.c | 4 +- tcg/aarch64/tcg-target.inc.c | 27 +++++++-- tcg/arm/tcg-target.inc.c | 98 ++++++++++++++++++-------------- tcg/i386/tcg-target.inc.c | 17 +++++- tcg/mips/tcg-target.inc.c | 6 +- tcg/optimize.c | 16 ++++++ tcg/ppc/tcg-target.inc.c | 42 +++++++------- tcg/riscv/tcg-target.inc.c | 16 ++++-- tcg/s390/tcg-target.inc.c | 20 ++++--- tcg/tcg-ldst.inc.c | 18 +++--- tcg/tcg-op.c | 129 +++++++++++++++++++++++++++++++++--------- tcg/tcg-pool.inc.c | 12 ++-- tcg/tcg.c | 85 +++++++++++++++------------- tcg/README | 7 +++ 51 files changed, 451 insertions(+), 309 deletions(-)