| Message ID | 20190423222005.246981-1-ek@google.com |
|---|---|
| State | New |
| Headers | show |
| Series | The ioctl(SIOCGIFNAME) call requires a struct ifreq. | expand |
Patchew URL: https://patchew.org/QEMU/20190423222005.246981-1-ek@google.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190423222005.246981-1-ek@google.com Subject: [Qemu-devel] [PATCH] The ioctl(SIOCGIFNAME) call requires a struct ifreq. === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190416125744.27770-1-peter.maydell@linaro.org -> patchew/20190416125744.27770-1-peter.maydell@linaro.org t [tag update] patchew/20190420073442.7488-1-richard.henderson@linaro.org -> patchew/20190420073442.7488-1-richard.henderson@linaro.org t [tag update] patchew/20190423212246.3542-1-ehabkost@redhat.com -> patchew/20190423212246.3542-1-ehabkost@redhat.com * [new tag] patchew/20190423222005.246981-1-ek@google.com -> patchew/20190423222005.246981-1-ek@google.com Switched to a new branch 'test' eea8c80609 The ioctl(SIOCGIFNAME) call requires a struct ifreq. === OUTPUT BEGIN === ERROR: Author email address is mangled by the mailing list #2: Author: Erik Kline via Qemu-devel <qemu-devel@nongnu.org> total: 1 errors, 0 warnings, 8 lines checked Commit eea8c8060982 (The ioctl(SIOCGIFNAME) call requires a struct ifreq.) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190423222005.246981-1-ek@google.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
On Tue, 23 Apr 2019 at 23:28, Erik Kline via Qemu-devel <qemu-devel@nongnu.org> wrote: > > Signed-off-by: Erik Kline <ek@google.com> > Buglink: https://bugs.launchpad.net/qemu/+bug/1814352 > --- > linux-user/ioctls.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/linux-user/ioctls.h b/linux-user/ioctls.h > index ae8951625f..37501f575c 100644 > --- a/linux-user/ioctls.h > +++ b/linux-user/ioctls.h > @@ -178,7 +178,7 @@ > #endif /* CONFIG_USBFS */ > > IOCTL(SIOCATMARK, IOC_R, MK_PTR(TYPE_INT)) > - IOCTL(SIOCGIFNAME, IOC_RW, MK_PTR(TYPE_INT)) > + IOCTL(SIOCGIFNAME, IOC_RW, MK_PTR(MK_STRUCT(STRUCT_int_ifreq))) > IOCTL(SIOCGIFFLAGS, IOC_W | IOC_R, MK_PTR(MK_STRUCT(STRUCT_short_ifreq))) > IOCTL(SIOCSIFFLAGS, IOC_W, MK_PTR(MK_STRUCT(STRUCT_short_ifreq))) > IOCTL(SIOCGIFADDR, IOC_W | IOC_R, MK_PTR(MK_STRUCT(STRUCT_sockaddr_ifreq))) > -- > 2.21.0.593.g511ec345e18-goog > Reviewed-by: Peter Maydell <peter.maydell@linaro.org> thanks -- PMM
Anything else I need to do? On Wed, 24 Apr 2019 at 02:10, Peter Maydell <peter.maydell@linaro.org> wrote: > On Tue, 23 Apr 2019 at 23:28, Erik Kline via Qemu-devel > <qemu-devel@nongnu.org> wrote: > > > > Signed-off-by: Erik Kline <ek@google.com> > > Buglink: https://bugs.launchpad.net/qemu/+bug/1814352 > > --- > > linux-user/ioctls.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/linux-user/ioctls.h b/linux-user/ioctls.h > > index ae8951625f..37501f575c 100644 > > --- a/linux-user/ioctls.h > > +++ b/linux-user/ioctls.h > > @@ -178,7 +178,7 @@ > > #endif /* CONFIG_USBFS */ > > > > IOCTL(SIOCATMARK, IOC_R, MK_PTR(TYPE_INT)) > > - IOCTL(SIOCGIFNAME, IOC_RW, MK_PTR(TYPE_INT)) > > + IOCTL(SIOCGIFNAME, IOC_RW, MK_PTR(MK_STRUCT(STRUCT_int_ifreq))) > > IOCTL(SIOCGIFFLAGS, IOC_W | IOC_R, > MK_PTR(MK_STRUCT(STRUCT_short_ifreq))) > > IOCTL(SIOCSIFFLAGS, IOC_W, MK_PTR(MK_STRUCT(STRUCT_short_ifreq))) > > IOCTL(SIOCGIFADDR, IOC_W | IOC_R, > MK_PTR(MK_STRUCT(STRUCT_sockaddr_ifreq))) > > -- > > 2.21.0.593.g511ec345e18-goog > > > > Reviewed-by: Peter Maydell <peter.maydell@linaro.org> > > thanks > -- PMM >
Ah, just noticed the linux-user maintainers weren't cc'd on this patch. Laurent, could you pick this patch up, please? thanks -- PMM On Wed, 8 May 2019 at 23:54, Erik Kline <ek@loon.com> wrote: > > Anything else I need to do? > > On Wed, 24 Apr 2019 at 02:10, Peter Maydell <peter.maydell@linaro.org> wrote: >> >> On Tue, 23 Apr 2019 at 23:28, Erik Kline via Qemu-devel >> <qemu-devel@nongnu.org> wrote: >> > >> > Signed-off-by: Erik Kline <ek@google.com> >> > Buglink: https://bugs.launchpad.net/qemu/+bug/1814352 >> > --- >> > linux-user/ioctls.h | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/linux-user/ioctls.h b/linux-user/ioctls.h >> > index ae8951625f..37501f575c 100644 >> > --- a/linux-user/ioctls.h >> > +++ b/linux-user/ioctls.h >> > @@ -178,7 +178,7 @@ >> > #endif /* CONFIG_USBFS */ >> > >> > IOCTL(SIOCATMARK, IOC_R, MK_PTR(TYPE_INT)) >> > - IOCTL(SIOCGIFNAME, IOC_RW, MK_PTR(TYPE_INT)) >> > + IOCTL(SIOCGIFNAME, IOC_RW, MK_PTR(MK_STRUCT(STRUCT_int_ifreq))) >> > IOCTL(SIOCGIFFLAGS, IOC_W | IOC_R, MK_PTR(MK_STRUCT(STRUCT_short_ifreq))) >> > IOCTL(SIOCSIFFLAGS, IOC_W, MK_PTR(MK_STRUCT(STRUCT_short_ifreq))) >> > IOCTL(SIOCGIFADDR, IOC_W | IOC_R, MK_PTR(MK_STRUCT(STRUCT_sockaddr_ifreq))) >> > -- >> > 2.21.0.593.g511ec345e18-goog >> > >> >> Reviewed-by: Peter Maydell <peter.maydell@linaro.org> >> >> thanks >> -- PMM
On 09/05/2019 10:55, Peter Maydell wrote: > Ah, just noticed the linux-user maintainers weren't > cc'd on this patch. Laurent, could you pick this patch up, > please? Applied to my linux-user branch. Thanks, Laurent > > thanks > -- PMM > > On Wed, 8 May 2019 at 23:54, Erik Kline <ek@loon.com> wrote: >> >> Anything else I need to do? >> >> On Wed, 24 Apr 2019 at 02:10, Peter Maydell <peter.maydell@linaro.org> wrote: >>> >>> On Tue, 23 Apr 2019 at 23:28, Erik Kline via Qemu-devel >>> <qemu-devel@nongnu.org> wrote: >>>> >>>> Signed-off-by: Erik Kline <ek@google.com> >>>> Buglink: https://bugs.launchpad.net/qemu/+bug/1814352 >>>> --- >>>> linux-user/ioctls.h | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/linux-user/ioctls.h b/linux-user/ioctls.h >>>> index ae8951625f..37501f575c 100644 >>>> --- a/linux-user/ioctls.h >>>> +++ b/linux-user/ioctls.h >>>> @@ -178,7 +178,7 @@ >>>> #endif /* CONFIG_USBFS */ >>>> >>>> IOCTL(SIOCATMARK, IOC_R, MK_PTR(TYPE_INT)) >>>> - IOCTL(SIOCGIFNAME, IOC_RW, MK_PTR(TYPE_INT)) >>>> + IOCTL(SIOCGIFNAME, IOC_RW, MK_PTR(MK_STRUCT(STRUCT_int_ifreq))) >>>> IOCTL(SIOCGIFFLAGS, IOC_W | IOC_R, MK_PTR(MK_STRUCT(STRUCT_short_ifreq))) >>>> IOCTL(SIOCSIFFLAGS, IOC_W, MK_PTR(MK_STRUCT(STRUCT_short_ifreq))) >>>> IOCTL(SIOCGIFADDR, IOC_W | IOC_R, MK_PTR(MK_STRUCT(STRUCT_sockaddr_ifreq))) >>>> -- >>>> 2.21.0.593.g511ec345e18-goog >>>> >>> >>> Reviewed-by: Peter Maydell <peter.maydell@linaro.org> >>> >>> thanks >>> -- PMM
diff --git a/linux-user/ioctls.h b/linux-user/ioctls.h index ae8951625f..37501f575c 100644 --- a/linux-user/ioctls.h +++ b/linux-user/ioctls.h @@ -178,7 +178,7 @@ #endif /* CONFIG_USBFS */ IOCTL(SIOCATMARK, IOC_R, MK_PTR(TYPE_INT)) - IOCTL(SIOCGIFNAME, IOC_RW, MK_PTR(TYPE_INT)) + IOCTL(SIOCGIFNAME, IOC_RW, MK_PTR(MK_STRUCT(STRUCT_int_ifreq))) IOCTL(SIOCGIFFLAGS, IOC_W | IOC_R, MK_PTR(MK_STRUCT(STRUCT_short_ifreq))) IOCTL(SIOCSIFFLAGS, IOC_W, MK_PTR(MK_STRUCT(STRUCT_short_ifreq))) IOCTL(SIOCGIFADDR, IOC_W | IOC_R, MK_PTR(MK_STRUCT(STRUCT_sockaddr_ifreq)))
Signed-off-by: Erik Kline <ek@google.com> Buglink: https://bugs.launchpad.net/qemu/+bug/1814352 --- linux-user/ioctls.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)