| Message ID | 20181220084559.13880-1-armbru@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] ui/cocoa: Include less of the generated modular QAPI headers | expand |
On 12/20/18 9:45 AM, Markus Armbruster wrote: > Avoids pointless recompilation. Missed in commit 112ed241f5d. > > Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > ui/cocoa.m | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/ui/cocoa.m b/ui/cocoa.m > index ecf12bfc2e..ddc058e76e 100644 > --- a/ui/cocoa.m > +++ b/ui/cocoa.m > @@ -32,7 +32,8 @@ > #include "ui/input.h" > #include "sysemu/sysemu.h" > #include "qapi/error.h" > -#include "qapi/qapi-commands.h" > +#include "qapi/qapi-commands-block.h" > +#include "qapi/qapi-commands-misc.h" > #include "sysemu/blockdev.h" > #include "qemu-version.h" > #include <Carbon/Carbon.h> >
On Thu, Dec 20, 2018 at 09:45:59AM +0100, Markus Armbruster wrote: > Avoids pointless recompilation. Missed in commit 112ed241f5d. > > Signed-off-by: Markus Armbruster <armbru@redhat.com> > --- > ui/cocoa.m | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Reviewed-by: Roman Bolshakov <r.bolshakov@yadro.com> Tested-by: Roman Bolshakov <r.bolshakov@yadro.com> Thanks, Roman
On Thu, 20 Dec 2018 at 08:46, Markus Armbruster <armbru@redhat.com> wrote: > > Avoids pointless recompilation. Missed in commit 112ed241f5d. > > Signed-off-by: Markus Armbruster <armbru@redhat.com> > --- > ui/cocoa.m | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/ui/cocoa.m b/ui/cocoa.m > index ecf12bfc2e..ddc058e76e 100644 > --- a/ui/cocoa.m > +++ b/ui/cocoa.m > @@ -32,7 +32,8 @@ > #include "ui/input.h" > #include "sysemu/sysemu.h" > #include "qapi/error.h" > -#include "qapi/qapi-commands.h" > +#include "qapi/qapi-commands-block.h" > +#include "qapi/qapi-commands-misc.h" > #include "sysemu/blockdev.h" > #include "qemu-version.h" > #include <Carbon/Carbon.h> > -- Applied, thanks. -- PMM
diff --git a/ui/cocoa.m b/ui/cocoa.m index ecf12bfc2e..ddc058e76e 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -32,7 +32,8 @@ #include "ui/input.h" #include "sysemu/sysemu.h" #include "qapi/error.h" -#include "qapi/qapi-commands.h" +#include "qapi/qapi-commands-block.h" +#include "qapi/qapi-commands-misc.h" #include "sysemu/blockdev.h" #include "qemu-version.h" #include <Carbon/Carbon.h>
Avoids pointless recompilation. Missed in commit 112ed241f5d. Signed-off-by: Markus Armbruster <armbru@redhat.com> --- ui/cocoa.m | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)