| Message ID | 20181114123643.24091-12-marcandre.lureau@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | RFC: slirp: make it again a standalone project | expand |
On Wed, Nov 14, 2018 at 04:36:13PM +0400, Marc-André Lureau wrote: > Looking at git history, this looks like something from the past, when > there was a tty layer. Let's remove it. > > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> > --- > slirp/slirp_config.h | 7 ------- > slirp/if.c | 2 -- > 2 files changed, 9 deletions(-) Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Regards, Daniel
Daniel P. Berrangé, le mer. 14 nov. 2018 13:46:02 +0000, a ecrit: > On Wed, Nov 14, 2018 at 04:36:13PM +0400, Marc-André Lureau wrote: > > Looking at git history, this looks like something from the past, when > > there was a tty layer. Let's remove it. > > > > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> > > --- > > slirp/slirp_config.h | 7 ------- > > slirp/if.c | 2 -- > > 2 files changed, 9 deletions(-) > > Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Applied to my tree, thanks!
diff --git a/slirp/slirp_config.h b/slirp/slirp_config.h index 721667e3ef..f0cc1c781b 100644 --- a/slirp/slirp_config.h +++ b/slirp/slirp_config.h @@ -5,13 +5,6 @@ /* Define to 1 if you want KEEPALIVE timers */ #define DO_KEEPALIVE 0 -/* Define this if you want slirp to write to the tty as fast as it can */ -/* This should only be set if you are using load-balancing, slirp does a */ -/* pretty good job on single modems already, and seting this will make */ -/* interactive sessions less responsive */ -/* XXXXX Talk about having fast modem as unit 0 */ -#undef FULL_BOLT - /*********************************************************/ /* * Autoconf defined configuration options diff --git a/slirp/if.c b/slirp/if.c index 1c96869831..1a9122a732 100644 --- a/slirp/if.c +++ b/slirp/if.c @@ -131,12 +131,10 @@ diddit: } } -#ifndef FULL_BOLT /* * This prevents us from malloc()ing too many mbufs */ if_start(ifm->slirp); -#endif } /*
Looking at git history, this looks like something from the past, when there was a tty layer. Let's remove it. Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> --- slirp/slirp_config.h | 7 ------- slirp/if.c | 2 -- 2 files changed, 9 deletions(-)