| Message ID | 20181114123643.24091-23-marcandre.lureau@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | RFC: slirp: make it again a standalone project | expand |
On Wed, Nov 14, 2018 at 04:36:24PM +0400, Marc-André Lureau wrote: > It's actually qemu configure CONFIG_IOVEC that is being used. That makes it sound like slirp is using CONFIG_IOVEC, but AFAICT that's only used by QEMU's osdep code. > > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> > --- > slirp/slirp_config.h | 6 ------ > 1 file changed, 6 deletions(-) Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Regards, Daniel
Daniel P. Berrangé, le mer. 14 nov. 2018 13:53:31 +0000, a ecrit: > On Wed, Nov 14, 2018 at 04:36:24PM +0400, Marc-André Lureau wrote: > > It's actually qemu configure CONFIG_IOVEC that is being used. > > That makes it sound like slirp is using CONFIG_IOVEC, but AFAICT > that's only used by QEMU's osdep code. > > > > > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> > > --- > > slirp/slirp_config.h | 6 ------ > > 1 file changed, 6 deletions(-) > > Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Applied to my tree, thanks!
diff --git a/slirp/slirp_config.h b/slirp/slirp_config.h index f1ee927c15..833f25a965 100644 --- a/slirp/slirp_config.h +++ b/slirp/slirp_config.h @@ -14,12 +14,6 @@ /* Define if the machine is big endian */ //#undef HOST_WORDS_BIGENDIAN -/* Define if iovec needs to be declared */ -#undef DECLARE_IOVEC -#ifdef _WIN32 -#define DECLARE_IOVEC -#endif - /* Define to sizeof(char *) */ #define SIZEOF_CHAR_P (HOST_LONG_BITS / 8)
It's actually qemu configure CONFIG_IOVEC that is being used. Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> --- slirp/slirp_config.h | 6 ------ 1 file changed, 6 deletions(-)