diff mbox series

[v1,04/13] ui: avoid pointless VNC updates if framebuffer isn't dirty

Message ID 20171218191228.31018-5-berrange@redhat.com
State New
Headers show
Series Fix VNC server unbounded memory usage | expand

Commit Message

Daniel P. Berrangé Dec. 18, 2017, 7:12 p.m. UTC 
The vnc_update_client() method checks the 'has_dirty' flag to see if there are
dirty regions that are pending to send to the client. Regardless of this flag,
if a forced update is requested, updates must be sent. For unknown reasons
though, the code also tries to sent updates if audio capture is enabled. This
makes no sense as audio capture state does not impact framebuffer contents, so
this check is removed.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---
 ui/vnc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/ui/vnc.c b/ui/vnc.c
index a61fcbd20c..f53eddb8e5 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -984,7 +984,7 @@  static int vnc_update_client(VncState *vs, int has_dirty)
         return 0;
     }
 
-    if (!vs->has_dirty && !vs->audio_cap && !vs->force_update) {
+    if (!vs->has_dirty && !vs->force_update) {
         return 0;
     }