Message ID | 20171218191228.31018-3-berrange@redhat.com |
---|---|
State | New |
Headers | show |
Series | Fix VNC server unbounded memory usage | expand |
diff --git a/ui/vnc.c b/ui/vnc.c index 7ba3297dfa..869c75bbcf 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -969,7 +969,7 @@ static int vnc_update_client(VncState *vs, int has_dirty) } vs->has_dirty += has_dirty; - if (vs->need_update && !vs->disconnecting) { + if (vs->need_update) { VncDisplay *vd = vs->vd; VncJob *job; int y; @@ -1030,10 +1030,6 @@ static int vnc_update_client(VncState *vs, int has_dirty) return n; } - if (vs->disconnecting) { - vnc_disconnect_finish(vs); - } - return 0; }
A previous commit: commit 5a8be0f73d6f60ff08746377eb09ca459f39deab Author: Gerd Hoffmann <kraxel@redhat.com> Date: Wed Jul 13 12:21:20 2016 +0200 vnc: make sure we finish disconnect Added a check for vs->disconnecting at the very start of the vnc_update_client method. This means that the very next "if" statement check for !vs->disconnecting always evaluates true, and is thus redundant. This in turn means the vs->disconnecting check at the very end of the method never evaluates true, and is thus unreachable code. Signed-off-by: Daniel P. Berrange <berrange@redhat.com> --- ui/vnc.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)