| Message ID | 20161220230732.17862-1-samuel.thibault@ens-lyon.org |
|---|---|
| State | New |
| Headers | show |
Hi,
Your series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20161220230732.17862-1-samuel.thibault@ens-lyon.org
Subject: [Qemu-devel] [PULL 0/2] slirp updates: MIN/MAX, tftp dynamic blocks
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20161220230732.17862-1-samuel.thibault@ens-lyon.org -> patchew/20161220230732.17862-1-samuel.thibault@ens-lyon.org
Switched to a new branch 'test'
9c5544e slirp: support dynamic block size for TFTP transfers
8de1d56 slirp, disas: Replace min/max with MIN/MAX macros
=== OUTPUT BEGIN ===
Checking PATCH 1/2: slirp, disas: Replace min/max with MIN/MAX macros...
Checking PATCH 2/2: slirp: support dynamic block size for TFTP transfers...
ERROR: suspect code indent for conditional statements (10, 14)
#90: FILE: slirp/tftp.c:393:
+ if (blksize > 0) {
+ spt->block_size = MIN(blksize, TFTP_BLOCKSIZE_MAX);
total: 1 errors, 0 warnings, 101 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org
no-reply@patchew.org, on Tue 20 Dec 2016 15:15:43 -0800, wrote: > Your series seems to have some coding style problems. See output below for > more information: > ERROR: suspect code indent for conditional statements (10, 14) > #90: FILE: slirp/tftp.c:393: > + if (blksize > 0) { > + spt->block_size = MIN(blksize, TFTP_BLOCKSIZE_MAX); This is a false positive. Samuel
On 20 December 2016 at 23:07, Samuel Thibault <samuel.thibault@ens-lyon.org> wrote: > The following changes since commit 82ecffa8c050bf5bbc13329e9b65eac1caa5b55c: > > Open 2.9 development tree (2016-12-20 16:20:16 +0000) > > are available in the git repository at: > > http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault > > for you to fetch changes up to 9443598d7e2f2c0a6493d97b3f11dd04837b08e8: > > slirp: support dynamic block size for TFTP transfers (2016-12-21 00:02:15 +0100) > > ---------------------------------------------------------------- > slirp updates > > ---------------------------------------------------------------- > Hervé Poussineau (1): > slirp: support dynamic block size for TFTP transfers > > Yuval Shaia (1): > slirp, disas: Replace min/max with MIN/MAX macros > Applied, thanks. -- PMM
The following changes since commit 82ecffa8c050bf5bbc13329e9b65eac1caa5b55c: Open 2.9 development tree (2016-12-20 16:20:16 +0000) are available in the git repository at: http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault for you to fetch changes up to 9443598d7e2f2c0a6493d97b3f11dd04837b08e8: slirp: support dynamic block size for TFTP transfers (2016-12-21 00:02:15 +0100) ---------------------------------------------------------------- slirp updates ---------------------------------------------------------------- Hervé Poussineau (1): slirp: support dynamic block size for TFTP transfers Yuval Shaia (1): slirp, disas: Replace min/max with MIN/MAX macros disas/m68k.c | 8 ++------ slirp/dhcpv6.c | 2 +- slirp/ip6_icmp.c | 2 +- slirp/slirp.c | 2 +- slirp/slirp.h | 5 ----- slirp/tcp_input.c | 16 ++++++++-------- slirp/tcp_output.c | 6 +++--- slirp/tcp_timer.c | 2 +- slirp/tcpip.h | 2 +- slirp/tftp.c | 26 ++++++++++++++------------ slirp/tftp.h | 8 +++++--- 11 files changed, 37 insertions(+), 42 deletions(-)