mbox

[PULL,0/2] qtest: don't leak pid files and UNIX domain sockets

Message ID 20140204083111.GA6919@stefanha-thinkpad.redhat.com
State New
Headers show

Pull-request

git://github.com/stefanha/qemu.git tags/qtest-for-peter

Message

Stefan Hajnoczi Feb. 4, 2014, 8:31 a.m. UTC 
On Mon, Feb 03, 2014 at 04:01:00PM +0000, Peter Maydell wrote:
> On 3 February 2014 15:20, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> > This pull request has been rebased onto qemu.git/master and retested.
> >
> > The series fixes init_socket() failures when reused PIDs cause temporary file
> > name collisions.
> 
> Your pull request appears to be missing the critically
> important part, ie the git repo/branch/tag information
> to pull from... ("git request-pull" is your friend here.)

Oops, I ran the wrong script.  Here are the full details and signed tag:

The following changes since commit 2f61120c10da9128357510debc8e66880cd2bfdc:

  Merge remote-tracking branch 'qmp-unstable/queue/qmp' into staging (2014-02-01 23:32:31 +0000)

are available in the git repository at:


  git://github.com/stefanha/qemu.git tags/qtest-for-peter

for you to fetch changes up to 56db2e5843256c857addb17deb743109330649be:

  qtest: unlink UNIX domain sockets after connecting (2014-02-03 16:06:24 +0100)

----------------------------------------------------------------
qtest resource cleanup patches

----------------------------------------------------------------
Stefan Hajnoczi (2):
      qtest: unlink QEMU pid file after startup
      qtest: unlink UNIX domain sockets after connecting

 tests/libqtest.c | 45 +++++++++++++++++++++++----------------------
 1 file changed, 23 insertions(+), 22 deletions(-)

Comments

Peter Maydell Feb. 7, 2014, 4:41 p.m. UTC | #1 
On 4 February 2014 08:31, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> On Mon, Feb 03, 2014 at 04:01:00PM +0000, Peter Maydell wrote:
>> On 3 February 2014 15:20, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>> > This pull request has been rebased onto qemu.git/master and retested.
>> >
>> > The series fixes init_socket() failures when reused PIDs cause temporary file
>> > name collisions.
>>
>> Your pull request appears to be missing the critically
>> important part, ie the git repo/branch/tag information
>> to pull from... ("git request-pull" is your friend here.)
>
> Oops, I ran the wrong script.  Here are the full details and signed tag:

Applied, thanks.

-- PMM
Andreas Färber Feb. 9, 2014, 11:40 a.m. UTC | #2 
Am 07.02.2014 17:41, schrieb Peter Maydell:
> On 4 February 2014 08:31, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>> On Mon, Feb 03, 2014 at 04:01:00PM +0000, Peter Maydell wrote:
>>> On 3 February 2014 15:20, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>>>> This pull request has been rebased onto qemu.git/master and retested.
>>>>
>>>> The series fixes init_socket() failures when reused PIDs cause temporary file
>>>> name collisions.
>>>
>>> Your pull request appears to be missing the critically
>>> important part, ie the git repo/branch/tag information
>>> to pull from... ("git request-pull" is your friend here.)
>>
>> Oops, I ran the wrong script.  Here are the full details and signed tag:
> 
> Applied, thanks.

Thanks. I've stumbled over a remaining pid file leak:

http://patchwork.ozlabs.org/patch/318576/

Regards,
Andreas