| Message ID | 1594631150-36801-1-git-send-email-wang.yi59@zte.com.cn |
|---|---|
| State | New |
| Headers | show |
| Series | [01/12] target/arm/kvm: Remove superfluous break | expand |
On 13/07/2020 11.05, Yi Wang wrote: > From: Liao Pingfang <liao.pingfang@zte.com.cn> > > Remove superfluous breaks, as there is a "return" before them. > > Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn> > Signed-off-by: Yi Wang <wang.yi59@zte.com.cn> > Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > target/cris/translate.c | 7 +++---- > target/cris/translate_v10.inc.c | 2 -- > 2 files changed, 3 insertions(+), 6 deletions(-) > > diff --git a/target/cris/translate.c b/target/cris/translate.c > index aaa46b5..64a478b 100644 > --- a/target/cris/translate.c > +++ b/target/cris/translate.c > @@ -1178,12 +1178,11 @@ static inline void t_gen_zext(TCGv d, TCGv s, int size) > static char memsize_char(int size) > { > switch (size) { > - case 1: return 'b'; break; > - case 2: return 'w'; break; > - case 4: return 'd'; break; > + case 1: return 'b'; > + case 2: return 'w'; > + case 4: return 'd'; > default: > return 'x'; > - break; > } > } > #endif > diff --git a/target/cris/translate_v10.inc.c b/target/cris/translate_v10.inc.c > index ae34a0d..7f38fd2 100644 > --- a/target/cris/translate_v10.inc.c > +++ b/target/cris/translate_v10.inc.c > @@ -1026,10 +1026,8 @@ static unsigned int dec10_ind(CPUCRISState *env, DisasContext *dc) > switch (dc->opcode) { > case CRISV10_IND_MOVE_M_R: > return dec10_ind_move_m_r(env, dc, size); > - break; > case CRISV10_IND_MOVE_R_M: > return dec10_ind_move_r_m(dc, size); > - break; > case CRISV10_IND_CMP: > LOG_DIS("cmp size=%d op=%d %d\n", size, dc->src, dc->dst); > cris_cc_mask(dc, CC_MASK_NZVC); > Reviewed-by: Thomas Huth <thuth@redhat.com>
Le 13/07/2020 à 11:39, Thomas Huth a écrit : > On 13/07/2020 11.05, Yi Wang wrote: >> From: Liao Pingfang <liao.pingfang@zte.com.cn> >> >> Remove superfluous breaks, as there is a "return" before them. >> >> Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn> >> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn> >> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> >> --- >> target/cris/translate.c | 7 +++---- >> target/cris/translate_v10.inc.c | 2 -- >> 2 files changed, 3 insertions(+), 6 deletions(-) >> >> diff --git a/target/cris/translate.c b/target/cris/translate.c >> index aaa46b5..64a478b 100644 >> --- a/target/cris/translate.c >> +++ b/target/cris/translate.c >> @@ -1178,12 +1178,11 @@ static inline void t_gen_zext(TCGv d, TCGv s, int size) >> static char memsize_char(int size) >> { >> switch (size) { >> - case 1: return 'b'; break; >> - case 2: return 'w'; break; >> - case 4: return 'd'; break; >> + case 1: return 'b'; >> + case 2: return 'w'; >> + case 4: return 'd'; >> default: >> return 'x'; >> - break; >> } >> } >> #endif >> diff --git a/target/cris/translate_v10.inc.c b/target/cris/translate_v10.inc.c >> index ae34a0d..7f38fd2 100644 >> --- a/target/cris/translate_v10.inc.c >> +++ b/target/cris/translate_v10.inc.c >> @@ -1026,10 +1026,8 @@ static unsigned int dec10_ind(CPUCRISState *env, DisasContext *dc) >> switch (dc->opcode) { >> case CRISV10_IND_MOVE_M_R: >> return dec10_ind_move_m_r(env, dc, size); >> - break; >> case CRISV10_IND_MOVE_R_M: >> return dec10_ind_move_r_m(dc, size); >> - break; >> case CRISV10_IND_CMP: >> LOG_DIS("cmp size=%d op=%d %d\n", size, dc->src, dc->dst); >> cris_cc_mask(dc, CC_MASK_NZVC); >> > > Reviewed-by: Thomas Huth <thuth@redhat.com> > > Applied to my trivial-patches branch. Thanks, Laurent
diff --git a/target/cris/translate.c b/target/cris/translate.c index aaa46b5..64a478b 100644 --- a/target/cris/translate.c +++ b/target/cris/translate.c @@ -1178,12 +1178,11 @@ static inline void t_gen_zext(TCGv d, TCGv s, int size) static char memsize_char(int size) { switch (size) { - case 1: return 'b'; break; - case 2: return 'w'; break; - case 4: return 'd'; break; + case 1: return 'b'; + case 2: return 'w'; + case 4: return 'd'; default: return 'x'; - break; } } #endif diff --git a/target/cris/translate_v10.inc.c b/target/cris/translate_v10.inc.c index ae34a0d..7f38fd2 100644 --- a/target/cris/translate_v10.inc.c +++ b/target/cris/translate_v10.inc.c @@ -1026,10 +1026,8 @@ static unsigned int dec10_ind(CPUCRISState *env, DisasContext *dc) switch (dc->opcode) { case CRISV10_IND_MOVE_M_R: return dec10_ind_move_m_r(env, dc, size); - break; case CRISV10_IND_MOVE_R_M: return dec10_ind_move_r_m(dc, size); - break; case CRISV10_IND_CMP: LOG_DIS("cmp size=%d op=%d %d\n", size, dc->src, dc->dst); cris_cc_mask(dc, CC_MASK_NZVC);