diff mbox series

[07/12] vnc: Remove the superfluous break

Message ID 1594631086-36509-1-git-send-email-wang.yi59@zte.com.cn
State New
Headers show
Series [01/12] target/arm/kvm: Remove superfluous break | expand

Commit Message

Yi Wang July 13, 2020, 9:04 a.m. UTC 
From: Liao Pingfang <liao.pingfang@zte.com.cn>

Remove the superfluous break, as there is a "return" before.

Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>a
Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 ui/vnc-enc-tight.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Thomas Huth July 13, 2020, 9:35 a.m. UTC | #1 
On 13/07/2020 11.04, Yi Wang wrote:
> From: Liao Pingfang <liao.pingfang@zte.com.cn>
> 
> Remove the superfluous break, as there is a "return" before.
> 
> Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>a
> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  ui/vnc-enc-tight.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c
> index 1e08518..cebd358 100644
> --- a/ui/vnc-enc-tight.c
> +++ b/ui/vnc-enc-tight.c
> @@ -1125,7 +1125,6 @@ static int send_palette_rect(VncState *vs, int x, int y,
>      }
>      default:
>          return -1; /* No palette for 8bits colors */
> -        break;
>      }
>      bytes = w * h;
>      vs->tight->tight.offset = bytes;
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>
Juan Quintela July 13, 2020, 10:02 a.m. UTC | #2 
Yi Wang <wang.yi59@zte.com.cn> wrote:
> From: Liao Pingfang <liao.pingfang@zte.com.cn>
>
> Remove the superfluous break, as there is a "return" before.
>
> Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>a
> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Reviewed-by: Juan Quintela <quintela@redhat.com>
Laurent Vivier Sept. 1, 2020, 6:37 a.m. UTC | #3 
Le 13/07/2020 à 11:35, Thomas Huth a écrit :
> On 13/07/2020 11.04, Yi Wang wrote:
>> From: Liao Pingfang <liao.pingfang@zte.com.cn>
>>
>> Remove the superfluous break, as there is a "return" before.
>>
>> Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>a
>> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
>> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>>  ui/vnc-enc-tight.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c
>> index 1e08518..cebd358 100644
>> --- a/ui/vnc-enc-tight.c
>> +++ b/ui/vnc-enc-tight.c
>> @@ -1125,7 +1125,6 @@ static int send_palette_rect(VncState *vs, int x, int y,
>>      }
>>      default:
>>          return -1; /* No palette for 8bits colors */
>> -        break;
>>      }
>>      bytes = w * h;
>>      vs->tight->tight.offset = bytes;
>>
> 
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> 
> 

Applied to my trivial-patches branch.

Thanks,
Laurent
diff mbox series

Patch

diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c
index 1e08518..cebd358 100644
--- a/ui/vnc-enc-tight.c
+++ b/ui/vnc-enc-tight.c
@@ -1125,7 +1125,6 @@  static int send_palette_rect(VncState *vs, int x, int y,
     }
     default:
         return -1; /* No palette for 8bits colors */
-        break;
     }
     bytes = w * h;
     vs->tight->tight.offset = bytes;