Message ID | 1486380501-13431-1-git-send-email-kraxel@redhat.com |
---|---|
State | New |
Headers | show |
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PULL 0/9] usb: various bugfixes, mostly xhci. Message-id: 1486380501-13431-1-git-send-email-kraxel@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 # Useful git options git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/1486380501-13431-1-git-send-email-kraxel@redhat.com -> patchew/1486380501-13431-1-git-send-email-kraxel@redhat.com Switched to a new branch 'test' 4dbd0d1 xhci: fix event queue IRQ handling c2e151b usb: ccid: check ccid apdu length d2e396c xhci: guard xhci_kick_epctx against recursive calls 8f04397 xhci: don't kick in xhci_submit and xhci_fire_ctl_transfer 1361fc9 xhci: rename xhci_complete_packet to xhci_try_complete_packet 93cd5d4 xhci: only free completed transfers 81fac17 usb: accept usb3 control requests 36fec08 usb/uas: more verbose error message ecf8fb4 hw/usb/dev-hid: Improve guest compatibility of usb-tablet === OUTPUT BEGIN === Checking PATCH 1/9: hw/usb/dev-hid: Improve guest compatibility of usb-tablet... ERROR: code indent should never use tabs #53: FILE: hw/usb/dev-hid.c:490: + 0x09, 0x02,^I^I/* Usage (Mouse) */$ total: 1 errors, 0 warnings, 24 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 2/9: usb/uas: more verbose error message... Checking PATCH 3/9: usb: accept usb3 control requests... Checking PATCH 4/9: xhci: only free completed transfers... Checking PATCH 5/9: xhci: rename xhci_complete_packet to xhci_try_complete_packet... Checking PATCH 6/9: xhci: don't kick in xhci_submit and xhci_fire_ctl_transfer... Checking PATCH 7/9: xhci: guard xhci_kick_epctx against recursive calls... Checking PATCH 8/9: usb: ccid: check ccid apdu length... Checking PATCH 9/9: xhci: fix event queue IRQ handling... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@freelists.org
On 6 February 2017 at 11:28, Gerd Hoffmann <kraxel@redhat.com> wrote: > Hi, > > Here is the usb patch queue, with a collection of xhci bugfixes, > also some other usb fixes in various places. > > please pull, > Gerd > > The following changes since commit a951316b8a5c3c63254f20a826afeed940dd4cba: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2017-02-03 14:41:49 +0000) > > are available in the git repository at: > > > git://git.kraxel.org/qemu tags/pull-usb-20170206-1 > > for you to fetch changes up to 7da76e12cc5cc902dda4c168d8d608fd4e61cbc5: > > xhci: fix event queue IRQ handling (2017-02-06 12:12:26 +0100) > > ---------------------------------------------------------------- > usb: various bugfixes, mostly xhci. > > ---------------------------------------------------------------- > Gerd Hoffmann (7): > usb/uas: more verbose error message > usb: accept usb3 control requests > xhci: only free completed transfers > xhci: rename xhci_complete_packet to xhci_try_complete_packet > xhci: don't kick in xhci_submit and xhci_fire_ctl_transfer > xhci: guard xhci_kick_epctx against recursive calls > xhci: fix event queue IRQ handling > > Phil Dennis-Jordan (1): > hw/usb/dev-hid: Improve guest compatibility of usb-tablet > > Prasad J Pandit (1): > usb: ccid: check ccid apdu length Applied, thanks. -- PMM