Message ID | 1483967385-12891-1-git-send-email-kraxel@redhat.com |
---|---|
State | New |
Headers | show |
On 9 January 2017 at 13:09, Gerd Hoffmann <kraxel@redhat.com> wrote: > Hi, > > Here comes the ui patch queue with a bunch of small changes and fixes > all over the place: gtk, vnc, curses, sdl, keyboard. > > v2 changes: Replace the ps2 fix (v3 instead of v2 of the patch). > > please pull, > Gerd > > The following changes since commit dbe2b65566e76d3c3a0c3358285c0336ac61e757: > > Merge remote-tracking branch 'remotes/vivier/tags/m68k-for-2.9-pull-request' into staging (2016-12-28 17:11:11 +0000) > > are available in the git repository at: > > > git://git.kraxel.org/qemu tags/pull-ui-20170109-1 > > for you to fetch changes up to f46c4259f489d2e7742890ddfaa862bde3731e3e: > > ps2: Fix lost scancodes by recent changes (2017-01-06 10:36:49 +0100) > > ---------------------------------------------------------------- > gtk,vnc: misc bugfixes. > kbd: add jp keys, fix ps2 regressions. > sdl: export window id for baum, remove sdl hooks from baum. > egl: egl-helpers.c license change. Hi. I'm afraid this fails to build on OSX: /Users/pm215/src/qemu-for-merges/ui/cocoa.m:688:21: error: use of undeclared identifier 'MOUSE_EVENT_WHEELUP' MOUSE_EVENT_WHEELUP : MOUSE_EVENT_WHEELDN; ^ /Users/pm215/src/qemu-for-merges/ui/cocoa.m:710:45: error: use of undeclared identifier 'MOUSE_EVENT_WHEELUP' [INPUT_BUTTON_WHEEL_UP] = MOUSE_EVENT_WHEELUP, ^ /Users/pm215/src/qemu-for-merges/ui/cocoa.m:711:45: error: use of undeclared identifier 'MOUSE_EVENT_WHEELDN' [INPUT_BUTTON_WHEEL_DOWN] = MOUSE_EVENT_WHEELDN, ^ thanks -- PMM
Hi, > > git://git.kraxel.org/qemu tags/pull-ui-20170109-1 > Hi. I'm afraid this fails to build on OSX: > > /Users/pm215/src/qemu-for-merges/ui/cocoa.m:688:21: error: use of > undeclared identifier 'MOUSE_EVENT_WHEELUP' > MOUSE_EVENT_WHEELUP : MOUSE_EVENT_WHEELDN; > ^ > /Users/pm215/src/qemu-for-merges/ui/cocoa.m:710:45: error: use of > undeclared identifier 'MOUSE_EVENT_WHEELUP' > [INPUT_BUTTON_WHEEL_UP] = MOUSE_EVENT_WHEELUP, > ^ > /Users/pm215/src/qemu-for-merges/ui/cocoa.m:711:45: error: use of > undeclared identifier 'MOUSE_EVENT_WHEELDN' > [INPUT_BUTTON_WHEEL_DOWN] = MOUSE_EVENT_WHEELDN, Pushed new tag: git://git.kraxel.org/qemu tags/pull-ui-20170110-1 Dropped offending patch (8/11), no other changes. cheers, Gerd
On 10 January 2017 at 07:18, Gerd Hoffmann <kraxel@redhat.com> wrote: > Hi, > >> > git://git.kraxel.org/qemu tags/pull-ui-20170109-1 > >> Hi. I'm afraid this fails to build on OSX: >> >> /Users/pm215/src/qemu-for-merges/ui/cocoa.m:688:21: error: use of >> undeclared identifier 'MOUSE_EVENT_WHEELUP' >> MOUSE_EVENT_WHEELUP : MOUSE_EVENT_WHEELDN; >> ^ >> /Users/pm215/src/qemu-for-merges/ui/cocoa.m:710:45: error: use of >> undeclared identifier 'MOUSE_EVENT_WHEELUP' >> [INPUT_BUTTON_WHEEL_UP] = MOUSE_EVENT_WHEELUP, >> ^ >> /Users/pm215/src/qemu-for-merges/ui/cocoa.m:711:45: error: use of >> undeclared identifier 'MOUSE_EVENT_WHEELDN' >> [INPUT_BUTTON_WHEEL_DOWN] = MOUSE_EVENT_WHEELDN, > > Pushed new tag: > > git://git.kraxel.org/qemu tags/pull-ui-20170110-1 > > Dropped offending patch (8/11), no other changes. Applied, thanks. PS: to guarantee getting my attention on a respun pull request you need to resend a proper cover email (but you don't need to resend the rest of the emails). You got lucky this time :-) thanks -- PMM