[PULL,0/5] input: ps2 kbd cleanups and improvements

Hi,

This pull request features a bunch of cleanups and improvements for the
ps2 keyboard emulation (by Hervé Poussineau).

please pull,
  Gerd

The following changes since commit 7cfdc02dae0d2ff58c897496cfdbbafc0eda0f3f:

  Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2016-09-26 19:47:00 +0100)

are available in the git repository at:


  git://git.kraxel.org/qemu tags/pull-input-20160928-1

for you to fetch changes up to ec044a80e7216ca290ee2dce0afb864256efa956:

  ps2: do not generate invalid key codes for unknown keys (2016-09-28 14:03:42 +0200)

----------------------------------------------------------------
input queue: ps2 kbd cleanups and improvements

----------------------------------------------------------------
Hervé Poussineau (5):
      ps2: reject unknown commands, instead of blindly accepting them
      ps2: correctly handle 'get/set scancode' command
      ps2: allow keycode translation for all scancode sets
      ps2: use QEMU qcodes instead of scancodes
      ps2: do not generate invalid key codes for unknown keys

 hw/input/ps2.c | 612 ++++++++++++++++++++++++++++++++++++++++++++++++++++-----
 1 file changed, 558 insertions(+), 54 deletions(-)

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1475067272-11714-1-git-send-email-kraxel@redhat.com
Subject: [Qemu-devel] [PULL 0/5] input: ps2 kbd cleanups and improvements

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/1475061390-17644-1-git-send-email-thuth@redhat.com -> patchew/1475061390-17644-1-git-send-email-thuth@redhat.com
 * [new tag]         patchew/1475063033-8176-1-git-send-email-vijaykumar@zilogic.com -> patchew/1475063033-8176-1-git-send-email-vijaykumar@zilogic.com
 * [new tag]         patchew/1475067272-11714-1-git-send-email-kraxel@redhat.com -> patchew/1475067272-11714-1-git-send-email-kraxel@redhat.com
 * [new tag]         patchew/1475067819-21413-1-git-send-email-peterx@redhat.com -> patchew/1475067819-21413-1-git-send-email-peterx@redhat.com
Switched to a new branch 'test'
40d8b27 ps2: do not generate invalid key codes for unknown keys
56f82e4 ps2: use QEMU qcodes instead of scancodes
d0a4068 ps2: allow keycode translation for all scancode sets
9a4122f ps2: correctly handle 'get/set scancode' command
75e2b42 ps2: reject unknown commands, instead of blindly accepting them

=== OUTPUT BEGIN ===
Checking PATCH 1/5: ps2: reject unknown commands, instead of blindly accepting them...
Checking PATCH 2/5: ps2: correctly handle 'get/set scancode' command...
Checking PATCH 3/5: ps2: allow keycode translation for all scancode sets...
Checking PATCH 4/5: ps2: use QEMU qcodes instead of scancodes...
ERROR: if this code is redundant consider removing it
#165: FILE: hw/input/ps2.c:226:
+#if 0

ERROR: if this code is redundant consider removing it
#313: FILE: hw/input/ps2.c:365:
+#if 0

total: 2 errors, 0 warnings, 554 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 5/5: ps2: do not generate invalid key codes for unknown keys...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org

On 28 September 2016 at 05:54, Gerd Hoffmann <kraxel@redhat.com> wrote:
>   Hi,
>
> This pull request features a bunch of cleanups and improvements for the
> ps2 keyboard emulation (by Hervé Poussineau).
>
> please pull,
>   Gerd
>
> The following changes since commit 7cfdc02dae0d2ff58c897496cfdbbafc0eda0f3f:
>
>   Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2016-09-26 19:47:00 +0100)
>
> are available in the git repository at:
>
>
>   git://git.kraxel.org/qemu tags/pull-input-20160928-1
>
> for you to fetch changes up to ec044a80e7216ca290ee2dce0afb864256efa956:
>
>   ps2: do not generate invalid key codes for unknown keys (2016-09-28 14:03:42 +0200)
>
> ----------------------------------------------------------------
> input queue: ps2 kbd cleanups and improvements
>
> ----------------------------------------------------------------
> Hervé Poussineau (5):
>       ps2: reject unknown commands, instead of blindly accepting them
>       ps2: correctly handle 'get/set scancode' command
>       ps2: allow keycode translation for all scancode sets
>       ps2: use QEMU qcodes instead of scancodes
>       ps2: do not generate invalid key codes for unknown keys
>
>  hw/input/ps2.c | 612 ++++++++++++++++++++++++++++++++++++++++++++++++++++-----
>  1 file changed, 558 insertions(+), 54 deletions(-)

Applied, thanks.

-- PMM