Message ID | 1458656229-32043-1-git-send-email-pbonzini@redhat.com |
---|---|
State | New |
Headers | show |
On 22 March 2016 at 14:16, Paolo Bonzini <pbonzini@redhat.com> wrote: > The following changes since commit 4829e0378dfb91d55af9dfd741bd09e8f2c4f91a: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2016-03-18' into staging (2016-03-18 17:18:41 +0000) > > are available in the git repository at: > > git://github.com/bonzini/qemu.git tags/for-upstream > > for you to fetch changes up to 67262f458f145452614468137aff17c7b51e5257: > > target-i386: implement PKE for TCG (2016-03-22 15:15:59 +0100) > > ---------------------------------------------------------------- > * Log filtering from Alex and Peter > * Chardev fixes from Daniel and Marc-André > * config.status tweak from David > * Header file tweaks from Markus, myself and Veronia (Outreachy candidate) > * get_ticks_per_sec() removal from Rutuja (Outreachy candidate) > * Coverity fix from myself > * PKE implementation from myself, based on rth's XSAVE support Hi; I'm afraid this didn't build: PPC64 Linux: /home/pm215/qemu/hw/intc/openpic_kvm.c: In function 'kvm_openpic_realize': /home/pm215/qemu/hw/intc/openpic_kvm.c:207:9: error: implicit declaration of function 'error_setg' [-Werror=implicit-function-declaration] error_setg(errp, "Kernel is lacking Device Control API"); ^ OSX: /Users/pm215/src/qemu-for-merges/hw/usb/dev-mtp.c:1354:13: warning: implicit declaration of function 'error_setg' is invalid in C99 [-Wimplicit-function-declaration] error_setg(errp, "usb-mtp: x-root property must be configured"); ^ /Users/pm215/src/qemu-for-merges/net/tap-bsd.c:75:9: warning: implicit declaration of function 'error_setg_errno' is invalid in C99 [-Wimplicit-function-declaration] error_setg_errno(errp, errno, "could not open %s", dname); ^ /Users/pm215/src/qemu-for-merges/net/tap-bsd.c:99:13: warning: implicit declaration of function 'error_setg' is invalid in C99 [-Wimplicit-function-declaration] error_setg(errp, "vnet_hdr=1 requested, but no kernel " ^ (and subsequent link errors). thanks -- PMM
On 22/03/2016 21:27, Peter Maydell wrote: > > PPC64 Linux: > > /home/pm215/qemu/hw/intc/openpic_kvm.c: In function 'kvm_openpic_realize': > /home/pm215/qemu/hw/intc/openpic_kvm.c:207:9: error: implicit > declaration of function 'error_setg' > [-Werror=implicit-function-declaration] > error_setg(errp, "Kernel is lacking Device Control API"); > ^ > > OSX: > /Users/pm215/src/qemu-for-merges/hw/usb/dev-mtp.c:1354:13: warning: > implicit declaration of function 'error_setg' is invalid in C99 > [-Wimplicit-function-declaration] > error_setg(errp, "usb-mtp: x-root property must be configured"); > ^ > > /Users/pm215/src/qemu-for-merges/net/tap-bsd.c:75:9: warning: implicit > declaration of function 'error_setg_errno' is invalid in C99 > [-Wimplicit-function-declaration] > error_setg_errno(errp, errno, "could not open %s", dname); > ^ > /Users/pm215/src/qemu-for-merges/net/tap-bsd.c:99:13: warning: > implicit declaration of function 'error_setg' is invalid in C99 > [-Wimplicit-function-declaration] > error_setg(errp, "vnet_hdr=1 requested, but no kernel " > ^ OS X is not surprising, since I had to fix both Win32 and ARM builds compared to Markus's original patch... I thought I had covered all files in PPC, but openpic slipped. Paolo