mbox

[PULL,00/28] Misc changes for 2016-02-08

Message ID 1454950999-64128-1-git-send-email-pbonzini@redhat.com
State New
Headers show

Pull-request

git://github.com/bonzini/qemu.git tags/for-upstream

Message

Paolo Bonzini Feb. 8, 2016, 5:02 p.m. UTC 
The following changes since commit e4a096b1cd4350eeca5dcdc391ab333d2083d7fd:

  ui/cocoa.m: Include qemu/osdep.h (2016-02-08 13:14:40 +0000)

are available in the git repository at:

  git://github.com/bonzini/qemu.git tags/for-upstream

for you to fetch changes up to c3fb8ac5f6d315cf7aecdd1601c27d134c7cdbf5:

  ipmi_bmc_sim: Add break to correct watchdog NMI check (2016-02-08 17:36:49 +0100)

----------------------------------------------------------------
* switch to C11 atomics (Alex)
* Coverity fixes for IPMI (Corey)
* at long last, fail on wrong .pc files if -m32 is in use (Daniel)
* qemu-char regression fix (Daniel)
* SAS1068 device (Paolo)
* target-i386 cleanups (Richard)
* qemu-nbd docs improvements (Sitsofe)
* thread-safe memory hotplug (Stefan)

----------------------------------------------------------------
Alex Bennée (1):
      include/qemu/atomic.h: default to __atomic functions

Andrew Jones (1):
      kvm-all: trace: strerror fixup

Corey Minyard (2):
      ipmi_bmc_sim: Fix off by one in check.
      ipmi_bmc_sim: Add break to correct watchdog NMI check

Daniel P. Berrange (2):
      configure: sanity check the glib library that pkg-config finds
      char: fix repeated registration of tcp chardev I/O handlers

Janosch Frank (1):
      scripts/kvm/kvm_stat: Fix tracefs access checking

John Snow (1):
      nbd: avoid unaligned uint64_t store

Paolo Bonzini (6):
      memory: add early bail out from cpu_physical_memory_set_dirty_range
      qemu-char: Keep pty slave file descriptor open until the master is closed
      scsi: push WWN fields up to SCSIDevice
      scsi-generic: grab device and port SAS addresses from backend
      hw: Add support for LSI SAS1068 (mptsas) device
      ipmi: do not take/drop iothread lock

Richard Henderson (10):
      target-i386: Create gen_lea_v_seg
      target-i386: Introduce mo_stacksize
      target-i386: Use gen_lea_v_seg in gen_lea_modrm
      target-i386: Use gen_lea_v_seg in stack subroutines
      target-i386: Access segs via TCG registers
      target-i386: Use gen_lea_v_seg in pusha/popa
      target-i386: Rewrite gen_enter inline
      target-i386: Rewrite leave
      target-i386: Tidy gen_add_A0_im
      target-i386: Deconstruct the cpu_T array

Sitsofe Wheeler (3):
      qemu-nbd: Fix unintended texi verbatim formatting
      qemu-nbd: Minor texi updates
      qemu-nbd: Fix texi sentence capitalisation

Stefan Hajnoczi (1):
      memory: RCU ram_list.dirty_memory[] for safe RAM hotplug

 configure                |   24 +
 default-configs/pci.mak  |    1 +
 exec.c                   |   73 +-
 hw/ipmi/ipmi.c           |    2 -
 hw/ipmi/ipmi_bmc_sim.c   |    4 +-
 hw/scsi/Makefile.objs    |    1 +
 hw/scsi/mpi.h            | 1153 +++++++++++++++++++++++++++++++
 hw/scsi/mptconfig.c      |  904 ++++++++++++++++++++++++
 hw/scsi/mptendian.c      |  204 ++++++
 hw/scsi/mptsas.c         | 1441 ++++++++++++++++++++++++++++++++++++++
 hw/scsi/mptsas.h         |  100 +++
 hw/scsi/scsi-disk.c      |   23 +-
 hw/scsi/scsi-generic.c   |   92 +++
 include/exec/ram_addr.h  |  193 +++++-
 include/hw/pci/pci_ids.h |    1 +
 include/hw/scsi/scsi.h   |    3 +
 include/qemu/atomic.h    |  192 ++++--
 kvm-all.c                |    4 +-
 migration/ram.c          |    4 -
 nbd/server.c             |   20 +-
 qemu-char.c              |    8 +-
 qemu-nbd.texi            |   80 ++-
 scripts/kvm/kvm_stat     |   23 +-
 target-i386/helper.h     |    4 -
 target-i386/seg_helper.c |   74 --
 target-i386/translate.c  | 1725 +++++++++++++++++++++-------------------------
 trace-events             |   22 +
 27 files changed, 5186 insertions(+), 1189 deletions(-)
 create mode 100644 hw/scsi/mpi.h
 create mode 100644 hw/scsi/mptconfig.c
 create mode 100644 hw/scsi/mptendian.c
 create mode 100644 hw/scsi/mptsas.c
 create mode 100644 hw/scsi/mptsas.h

Comments

Peter Maydell Feb. 9, 2016, 9:21 a.m. UTC | #1 
On 8 February 2016 at 17:02, Paolo Bonzini <pbonzini@redhat.com> wrote:
> The following changes since commit e4a096b1cd4350eeca5dcdc391ab333d2083d7fd:
>
>   ui/cocoa.m: Include qemu/osdep.h (2016-02-08 13:14:40 +0000)
>
> are available in the git repository at:
>
>   git://github.com/bonzini/qemu.git tags/for-upstream
>
> for you to fetch changes up to c3fb8ac5f6d315cf7aecdd1601c27d134c7cdbf5:
>
>   ipmi_bmc_sim: Add break to correct watchdog NMI check (2016-02-08 17:36:49 +0100)
>
> ----------------------------------------------------------------
> * switch to C11 atomics (Alex)
> * Coverity fixes for IPMI (Corey)
> * at long last, fail on wrong .pc files if -m32 is in use (Daniel)
> * qemu-char regression fix (Daniel)
> * SAS1068 device (Paolo)
> * target-i386 cleanups (Richard)
> * qemu-nbd docs improvements (Sitsofe)
> * thread-safe memory hotplug (Stefan)
>

Hi; I'm afraid there are some compile issues here:

On 64-bit ARM and 64-bit PPC:

/home/pm215/qemu/hw/scsi/mptconfig.c: In function ‘vfill.isra.1’:
/home/pm215/qemu/hw/scsi/mptconfig.c:86:41: error: ‘val.str’ may be
used uninitialized in this function [-Werror=maybe-uninitialized]
                 stl_le_p(data + ofs, val.ll);
                                         ^

And a runtime error from the clang undefined behaviour
sanitizer:

/home/petmay01/linaro/qemu-for-merges/exec.c:1546:48: runtime error:
member access within null pointer of type 'DirtyMemoryBlocks'

which seems to fire for every test in the check-qtest-$ARCH
tests.

thanks
-- PMM
Paolo Bonzini Feb. 9, 2016, 11:10 a.m. UTC | #2 
On 09/02/2016 10:21, Peter Maydell wrote:
> On 8 February 2016 at 17:02, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> The following changes since commit e4a096b1cd4350eeca5dcdc391ab333d2083d7fd:
>>
>>   ui/cocoa.m: Include qemu/osdep.h (2016-02-08 13:14:40 +0000)
>>
>> are available in the git repository at:
>>
>>   git://github.com/bonzini/qemu.git tags/for-upstream
>>
>> for you to fetch changes up to c3fb8ac5f6d315cf7aecdd1601c27d134c7cdbf5:
>>
>>   ipmi_bmc_sim: Add break to correct watchdog NMI check (2016-02-08 17:36:49 +0100)
>>
>> ----------------------------------------------------------------
>> * switch to C11 atomics (Alex)
>> * Coverity fixes for IPMI (Corey)
>> * at long last, fail on wrong .pc files if -m32 is in use (Daniel)
>> * qemu-char regression fix (Daniel)
>> * SAS1068 device (Paolo)
>> * target-i386 cleanups (Richard)
>> * qemu-nbd docs improvements (Sitsofe)
>> * thread-safe memory hotplug (Stefan)
>>
> 
> Hi; I'm afraid there are some compile issues here:
> 
> On 64-bit ARM and 64-bit PPC:
> 
> /home/pm215/qemu/hw/scsi/mptconfig.c: In function ‘vfill.isra.1’:
> /home/pm215/qemu/hw/scsi/mptconfig.c:86:41: error: ‘val.str’ may be
> used uninitialized in this function [-Werror=maybe-uninitialized]
>                  stl_le_p(data + ofs, val.ll);
>                                          ^

Compiler issue, but easily shut up.

> And a runtime error from the clang undefined behaviour
> sanitizer:
> 
> /home/petmay01/linaro/qemu-for-merges/exec.c:1546:48: runtime error:
> member access within null pointer of type 'DirtyMemoryBlocks'
> 
> which seems to fire for every test in the check-qtest-$ARCH
> tests.

This is almost genuine, :) it's a zero-size memcpy.

clang 1, GCC 1.  Can't complain too loudly this time.

Paolo