mbox

[PULL,00/13] QMP and QObject patches

Message ID 1445937707-22768-1-git-send-email-armbru@redhat.com
State New
Headers show

Pull-request

git://repo.or.cz/qemu/armbru.git tags/pull-monitor-2015-10-27

Message

Markus Armbruster Oct. 27, 2015, 9:21 a.m. UTC
The following changes since commit 9666248a85fd889bfb6118f769e9c73039b998ed:

  Merge remote-tracking branch 'remotes/sstabellini/tags/xen-2015-10-26' into staging (2015-10-26 13:13:38 +0000)

are available in the git repository at:

  git://repo.or.cz/qemu/armbru.git tags/pull-monitor-2015-10-27

for you to fetch changes up to 8a4e1a93634a95997e227f3470453f07cf159fcf:

  docs: Document QMP event rate limiting (2015-10-27 10:05:54 +0100)

----------------------------------------------------------------
QMP and QObject patches

----------------------------------------------------------------
Markus Armbruster (13):
      qobject: Drop QObject_HEAD
      qbool: Make conversion from QObject * accept null
      qdict: Make conversion from QObject * accept null
      qfloat qint: Make conversion from QObject * accept null
      qlist: Make conversion from QObject * accept null
      qstring: Make conversion from QObject * accept null
      monitor: Reduce casting of QAPI event QDict
      monitor: Simplify event throttling
      monitor: Switch from timer_new() to timer_new_ns()
      monitor: Split MonitorQAPIEventConf off MonitorQAPIEventState
      monitor: Turn monitor_qapi_event_state[] into a hash table
      monitor: Throttle event VSERPORT_CHANGE separately by "id"
      docs: Document QMP event rate limiting

 docs/qmp-events.txt        |  12 +++
 docs/qmp-spec.txt          |   5 ++
 include/qapi/qmp/qbool.h   |   2 +-
 include/qapi/qmp/qdict.h   |   2 +-
 include/qapi/qmp/qfloat.h  |   2 +-
 include/qapi/qmp/qint.h    |   2 +-
 include/qapi/qmp/qlist.h   |   2 +-
 include/qapi/qmp/qobject.h |   4 -
 include/qapi/qmp/qstring.h |   2 +-
 monitor.c                  | 192 ++++++++++++++++++++++++++-------------------
 qapi/qmp-input-visitor.c   |  40 +++++-----
 qga/main.c                 |  11 +--
 qobject/qbool.c            |   4 +-
 qobject/qdict.c            |  39 +++------
 qobject/qfloat.c           |   4 +-
 qobject/qint.c             |   4 +-
 qobject/qlist.c            |   3 +-
 qobject/qstring.c          |   4 +-
 trace-events               |   4 +-
 19 files changed, 183 insertions(+), 155 deletions(-)

Comments

Peter Maydell Oct. 27, 2015, 1:06 p.m. UTC | #1
On 27 October 2015 at 09:21, Markus Armbruster <armbru@redhat.com> wrote:
> The following changes since commit 9666248a85fd889bfb6118f769e9c73039b998ed:
>
>   Merge remote-tracking branch 'remotes/sstabellini/tags/xen-2015-10-26' into staging (2015-10-26 13:13:38 +0000)
>
> are available in the git repository at:
>
>   git://repo.or.cz/qemu/armbru.git tags/pull-monitor-2015-10-27
>
> for you to fetch changes up to 8a4e1a93634a95997e227f3470453f07cf159fcf:
>
>   docs: Document QMP event rate limiting (2015-10-27 10:05:54 +0100)
>
> ----------------------------------------------------------------
> QMP and QObject patches
>
> ----------------------------------------------------------------
> Markus Armbruster (13):
>       qobject: Drop QObject_HEAD
>       qbool: Make conversion from QObject * accept null
>       qdict: Make conversion from QObject * accept null
>       qfloat qint: Make conversion from QObject * accept null
>       qlist: Make conversion from QObject * accept null
>       qstring: Make conversion from QObject * accept null
>       monitor: Reduce casting of QAPI event QDict
>       monitor: Simplify event throttling
>       monitor: Switch from timer_new() to timer_new_ns()
>       monitor: Split MonitorQAPIEventConf off MonitorQAPIEventState
>       monitor: Turn monitor_qapi_event_state[] into a hash table
>       monitor: Throttle event VSERPORT_CHANGE separately by "id"
>       docs: Document QMP event rate limiting

Hi. I'm afraid this fails to build against our minimum
glib version:

Undefined symbols for architecture x86_64:
  "_g_hash_table_add", referenced from:
      _monitor_qapi_event_queue in monitor.o
ld: symbol(s) not found for architecture x86_64

g_hash_table_add() was only introduced in glib 2.32.

thanks
-- PMM
Markus Armbruster Oct. 27, 2015, 2:28 p.m. UTC | #2
Peter Maydell <peter.maydell@linaro.org> writes:

> On 27 October 2015 at 09:21, Markus Armbruster <armbru@redhat.com> wrote:
>> The following changes since commit 9666248a85fd889bfb6118f769e9c73039b998ed:
>>
>>   Merge remote-tracking branch 'remotes/sstabellini/tags/xen-2015-10-26' into staging (2015-10-26 13:13:38 +0000)
>>
>> are available in the git repository at:
>>
>>   git://repo.or.cz/qemu/armbru.git tags/pull-monitor-2015-10-27
>>
>> for you to fetch changes up to 8a4e1a93634a95997e227f3470453f07cf159fcf:
>>
>>   docs: Document QMP event rate limiting (2015-10-27 10:05:54 +0100)
>>
>> ----------------------------------------------------------------
>> QMP and QObject patches
>>
>> ----------------------------------------------------------------
>> Markus Armbruster (13):
>>       qobject: Drop QObject_HEAD
>>       qbool: Make conversion from QObject * accept null
>>       qdict: Make conversion from QObject * accept null
>>       qfloat qint: Make conversion from QObject * accept null
>>       qlist: Make conversion from QObject * accept null
>>       qstring: Make conversion from QObject * accept null
>>       monitor: Reduce casting of QAPI event QDict
>>       monitor: Simplify event throttling
>>       monitor: Switch from timer_new() to timer_new_ns()
>>       monitor: Split MonitorQAPIEventConf off MonitorQAPIEventState
>>       monitor: Turn monitor_qapi_event_state[] into a hash table
>>       monitor: Throttle event VSERPORT_CHANGE separately by "id"
>>       docs: Document QMP event rate limiting
>
> Hi. I'm afraid this fails to build against our minimum
> glib version:
>
> Undefined symbols for architecture x86_64:
>   "_g_hash_table_add", referenced from:
>       _monitor_qapi_event_queue in monitor.o
> ld: symbol(s) not found for architecture x86_64
>
> g_hash_table_add() was only introduced in glib 2.32.

My mistake, thanks for catching it!