| Message ID | 1445297899-20527-1-git-send-email-mdroth@linux.vnet.ibm.com |
|---|---|
| State | New |
| Headers | show |
On 20 October 2015 at 00:38, Michael Roth <mdroth@linux.vnet.ibm.com> wrote: > Hi Peter, > > Please note that 'glib-compat: add 2.38/2.40/2.46 asserts' is also in > Marc-André's recent ivshmem PULL. The 2 versions of the patches are identical, > but let me know if you'd prefer a re-send/re-base later. > > The following changes since commit 26c7be842637ee65a79cd77f96a99c23ddcd90ad: > > Merge remote-tracking branch 'remotes/sstabellini/tags/2015-10-19-tag' into staging (2015-10-19 12:13:27 +0100) > > are available in the git repository at: > > > git://github.com/mdroth/qemu.git tags/qga-pull-2015-10-14-v4-tag > > for you to fetch changes up to e853ea1cc68716c3d9c22d04578020c6dd743306: > > qga: fix uninitialized value warning for win32 (2015-10-19 18:31:54 -0500) > > ---------------------------------------------------------------- > qemu-ga patch queue > > * add unit tests for qemu-ga > * add guest-exec support for posix/w32 guests > * added 'qemu-ga' target for w32. this allows us to do full MSI build, > without overloading 'qemu-ga.exe' target with uneeded dependencies. > * number of s/g_new/g_malloc/ conversions for qga > > v2: > * commit message and qapi documentation spelling fixes > * rename 'inp-data' guest-exec param to 'input-data' > > v3: > * fix OSX build errors for test-qga by using PRId64 > format in place of glib's, and dropping use of G_SPAWN_DEFAULT > macro for glib 2.22 compat > * fix win32 build warnings for 32-bit builds by avoid int casts > of process HANDLEs > > v4: > * assert connect_qga() doesn't fail > * only enable test-qga for linux hosts > * allow get-memory-block-info* to fail if memory blocks aren't exposed in > sysfs > Applied, thanks. -- PMM
On 20 October 2015 at 10:52, Peter Maydell <peter.maydell@linaro.org> wrote: > On 20 October 2015 at 00:38, Michael Roth <mdroth@linux.vnet.ibm.com> wrote: >> ---------------------------------------------------------------- >> qemu-ga patch queue >> >> * add unit tests for qemu-ga >> * add guest-exec support for posix/w32 guests >> * added 'qemu-ga' target for w32. this allows us to do full MSI build, >> without overloading 'qemu-ga.exe' target with uneeded dependencies. >> * number of s/g_new/g_malloc/ conversions for qga > Applied, thanks. ...but it looks like this is causing one of our travis builds to fail: https://travis-ci.org/qemu/qemu/jobs/86374487 Any suggestions? thanks -- PMM
Quoting Peter Maydell (2015-10-20 06:55:19) > On 20 October 2015 at 10:52, Peter Maydell <peter.maydell@linaro.org> wrote: > > On 20 October 2015 at 00:38, Michael Roth <mdroth@linux.vnet.ibm.com> wrote: > >> ---------------------------------------------------------------- > >> qemu-ga patch queue > >> > >> * add unit tests for qemu-ga > >> * add guest-exec support for posix/w32 guests > >> * added 'qemu-ga' target for w32. this allows us to do full MSI build, > >> without overloading 'qemu-ga.exe' target with uneeded dependencies. > >> * number of s/g_new/g_malloc/ conversions for qga > > > Applied, thanks. > > ...but it looks like this is causing one of our travis builds > to fail: > https://travis-ci.org/qemu/qemu/jobs/86374487 > > Any suggestions? I kicked off a travis job to reproduce it with make V=1 check and it looks like it's the filesystem query that's throwing it off. TEST: tests/test-qga... (pid=16941) /qga/sync-delimited: OK /qga/sync: OK /qga/ping: OK /qga/info: OK /qga/network-get-interfaces: OK /qga/get-vcpus: OK /qga/get-fsinfo: FAIL GTester: last random seed: R02Sd753608c4f8cbecc864ed92164a9c32d (pid=16945) /qga/get-memory-block-info: OK /qga/get-memory-blocks: OK /qga/file-ops: OK /qga/get-time: OK /qga/invalid-cmd: OK /qga/fsfreeze-status: OK /qga/blacklist: OK /qga/config: OK FAIL: tests/test-qga make: *** [check-tests/test-qga] Error 1 Added some debugging and kicked off another run, should have an answer/fix soon. > > thanks > -- PMM >
Hi Peter, Please note that 'glib-compat: add 2.38/2.40/2.46 asserts' is also in Marc-André's recent ivshmem PULL. The 2 versions of the patches are identical, but let me know if you'd prefer a re-send/re-base later. The following changes since commit 26c7be842637ee65a79cd77f96a99c23ddcd90ad: Merge remote-tracking branch 'remotes/sstabellini/tags/2015-10-19-tag' into staging (2015-10-19 12:13:27 +0100) are available in the git repository at: git://github.com/mdroth/qemu.git tags/qga-pull-2015-10-14-v4-tag for you to fetch changes up to e853ea1cc68716c3d9c22d04578020c6dd743306: qga: fix uninitialized value warning for win32 (2015-10-19 18:31:54 -0500) ---------------------------------------------------------------- qemu-ga patch queue * add unit tests for qemu-ga * add guest-exec support for posix/w32 guests * added 'qemu-ga' target for w32. this allows us to do full MSI build, without overloading 'qemu-ga.exe' target with uneeded dependencies. * number of s/g_new/g_malloc/ conversions for qga v2: * commit message and qapi documentation spelling fixes * rename 'inp-data' guest-exec param to 'input-data' v3: * fix OSX build errors for test-qga by using PRId64 format in place of glib's, and dropping use of G_SPAWN_DEFAULT macro for glib 2.22 compat * fix win32 build warnings for 32-bit builds by avoid int casts of process HANDLEs v4: * assert connect_qga() doesn't fail * only enable test-qga for linux hosts * allow get-memory-block-info* to fail if memory blocks aren't exposed in sysfs ---------------------------------------------------------------- Denis V. Lunev (2): qga: drop guest_file_init helper and replace it with static initializers qga: handle possible SIGPIPE in guest-file-write Marc-André Lureau (5): qga: add QGA_CONF environment variable qga: do not override configuration verbosity qtest: add a few fd-level qmp helpers glib-compat: add 2.38/2.40/2.46 asserts tests: add a local test for guest agent Markus Armbruster (1): qga: Use g_new() & friends where that makes obvious sense Michael Roth (3): build: qemu-ga: add 'qemu-ga' build target for w32 qga: guest-get-memory-blocks shouldn't fail for unexposed memory blocks qga: fix uninitialized value warning for win32 Yuri Pudgorodskiy (3): qga: guest exec functionality qga: handle G_IO_STATUS_AGAIN in ga_channel_write_all() qga: guest-exec simple stdin/stdout/stderr redirection Makefile | 14 +- configure | 2 +- include/glib-compat.h | 61 ++++ qga/channel-posix.c | 25 +- qga/channel-win32.c | 4 +- qga/commands-posix.c | 30 +- qga/commands-win32.c | 20 +- qga/commands.c | 394 +++++++++++++++++++- qga/guest-agent-command-state.c | 4 +- qga/main.c | 13 +- qga/qapi-schema.json | 67 ++++ tests/Makefile | 3 + tests/libqtest.c | 45 ++- tests/libqtest.h | 7 + tests/test-qga.c | 783 ++++++++++++++++++++++++++++++++++++++++ 15 files changed, 1412 insertions(+), 60 deletions(-) create mode 100644 tests/test-qga.c