| Message ID | 1433194188-24514-1-git-send-email-aurelien@aurel32.net |
|---|---|
| State | New |
| Headers | show |
On 1 June 2015 at 22:29, Aurelien Jarno <aurelien@aurel32.net> wrote: > The following changes since commit f5790c3bc81702c98c7ddadedb274758cff8cbe7: > > Revert "target-alpha: Add vector implementation for CMPBGE" (2015-05-22 12:30:13 +0100) > > are available in the git repository at: > > git://git.aurel32.net/qemu.git tags/pull-qemu-sh4-2015-06-01 > > for you to fetch changes up to c9967fd80d4686f44ee725a8c2af66b387b393a5: > > target-sh4: remove dead code (2015-05-25 01:28:56 +0200) > > ---------------------------------------------------------------- > SH4 patches for upstream > > ---------------------------------------------------------------- > Aurelien Jarno (8): > target-sh4: use bit number for SR constants > target-sh4: Split out T from SR > target-sh4: optimize addc using add2 > target-sh4: optimize subc using sub2 > target-sh4: optimize negc using add2 and sub2 > target-sh4: split out Q and M from of SR and optimize div1 > target-sh4: factorize fmov implementation > target-sh4: remove dead code Hi. I'm afraid this fails to build under clang: target-sh4/translate.c:282:20: error: unused function 'gen_copy_bit_i32' [-Werror,-Wunused-function] static inline void gen_copy_bit_i32(TCGv t0, int p0, TCGv t1, int p1) ^ 1 error generated. (Clang will warn about unused static inline functions defined in in a .c file; gcc doesn't.) thanks -- PMM
On 2015-06-02 18:23, Peter Maydell wrote: > On 1 June 2015 at 22:29, Aurelien Jarno <aurelien@aurel32.net> wrote: > > The following changes since commit f5790c3bc81702c98c7ddadedb274758cff8cbe7: > > > > Revert "target-alpha: Add vector implementation for CMPBGE" (2015-05-22 12:30:13 +0100) > > > > are available in the git repository at: > > > > git://git.aurel32.net/qemu.git tags/pull-qemu-sh4-2015-06-01 > > > > for you to fetch changes up to c9967fd80d4686f44ee725a8c2af66b387b393a5: > > > > target-sh4: remove dead code (2015-05-25 01:28:56 +0200) > > > > ---------------------------------------------------------------- > > SH4 patches for upstream > > > > ---------------------------------------------------------------- > > Aurelien Jarno (8): > > target-sh4: use bit number for SR constants > > target-sh4: Split out T from SR > > target-sh4: optimize addc using add2 > > target-sh4: optimize subc using sub2 > > target-sh4: optimize negc using add2 and sub2 > > target-sh4: split out Q and M from of SR and optimize div1 > > target-sh4: factorize fmov implementation > > target-sh4: remove dead code > > Hi. I'm afraid this fails to build under clang: Oops sorry about that. > target-sh4/translate.c:282:20: error: unused > function 'gen_copy_bit_i32' [-Werror,-Wunused-function] > static inline void gen_copy_bit_i32(TCGv t0, int p0, TCGv t1, int p1) > ^ > 1 error generated. > > (Clang will warn about unused static inline functions defined > in in a .c file; gcc doesn't.) That's actually a good catch. One of the goal of the patch set was to remove this function, but after converting everything, I forgot to remove it. I'll send a new PULL request with this fixed.
The following changes since commit f5790c3bc81702c98c7ddadedb274758cff8cbe7: Revert "target-alpha: Add vector implementation for CMPBGE" (2015-05-22 12:30:13 +0100) are available in the git repository at: git://git.aurel32.net/qemu.git tags/pull-qemu-sh4-2015-06-01 for you to fetch changes up to c9967fd80d4686f44ee725a8c2af66b387b393a5: target-sh4: remove dead code (2015-05-25 01:28:56 +0200) ---------------------------------------------------------------- SH4 patches for upstream ---------------------------------------------------------------- Aurelien Jarno (8): target-sh4: use bit number for SR constants target-sh4: Split out T from SR target-sh4: optimize addc using add2 target-sh4: optimize subc using sub2 target-sh4: optimize negc using add2 and sub2 target-sh4: split out Q and M from of SR and optimize div1 target-sh4: factorize fmov implementation target-sh4: remove dead code target-sh4/cpu.c | 3 +- target-sh4/cpu.h | 50 +++++--- target-sh4/gdbstub.c | 8 +- target-sh4/helper.c | 29 ++--- target-sh4/helper.h | 1 - target-sh4/op_helper.c | 148 +----------------------- target-sh4/translate.c | 307 +++++++++++++++++++++++++------------------------ 7 files changed, 217 insertions(+), 329 deletions(-)