mbox

[PULL,0/5] bootdevice: Refactor and improvement

Message ID 1419238601-5844-1-git-send-email-arei.gonglei@huawei.com
State New
Headers show

Pull-request

https://github.com/gongleiarei/qemu.git tags/bootdevice-next-20141222

Message

Gonglei (Arei) Dec. 22, 2014, 8:56 a.m. UTC
From: Gonglei <arei.gonglei@huawei.com>

Hi, Peter

Those patches just move boot order related code to bootdevice.c
and add a Error **errp argument for corresponding functions so
that it can propagate error messages to the caller.

After a new round review, this is the secondly pull request.

Please pull, thanks
-Gonglei

The following changes since commit 328b3b6c44c17d94df115ed1851f54a0bd59a471:

  Merge remote-tracking branch 'remotes/stefanha/tags/net-pull-request' into staging (2014-12-20 22:04:13 +0000)

are available in the git repository at:


  https://github.com/gongleiarei/qemu.git tags/bootdevice-next-20141222

for you to fetch changes up to ddcd55316fb2851e144e719171621ad2816487dc:

  bootdevice: add Error **errp argument for QEMUBootSetHandler (2014-12-22 14:39:21 +0800)

----------------------------------------------------------------
bootdevice: Refactor and improvement

----------------------------------------------------------------

Gonglei (5):
  bootdevice: move code about bootorder from vl.c to bootdevice.c
  bootdevice: add Error **errp argument for validate_bootdevices()
  bootdevice: add Error **errp argument for qemu_boot_set()
  bootdevice: add validate check for qemu_boot_set()
  bootdevice: add Error **errp argument for QEMUBootSetHandler

 bootdevice.c            |   73 +++++++++++++++++++++++++++++++++++++++++++++
 hw/i386/pc.c            |   22 +++++++-------
 hw/ppc/mac_newworld.c   |    4 +--
 hw/ppc/mac_oldworld.c   |    5 ++--
 hw/sparc/sun4m.c        |    4 +--
 hw/sparc64/sun4u.c      |    4 +--
 include/hw/hw.h         |    6 ----
 include/sysemu/sysemu.h |    8 +++++
 monitor.c               |   14 ++++-----
 vl.c                    |   75 +++++++----------------------------------------
 10 files changed, 118 insertions(+), 97 deletions(-)

Comments

Peter Maydell Dec. 22, 2014, 4:31 p.m. UTC | #1
On 22 December 2014 at 08:56,  <arei.gonglei@huawei.com> wrote:
> From: Gonglei <arei.gonglei@huawei.com>
>
> Hi, Peter
>
> Those patches just move boot order related code to bootdevice.c
> and add a Error **errp argument for corresponding functions so
> that it can propagate error messages to the caller.
>
> After a new round review, this is the secondly pull request.
>
> Please pull, thanks
> -Gonglei
>
> The following changes since commit 328b3b6c44c17d94df115ed1851f54a0bd59a471:
>
>   Merge remote-tracking branch 'remotes/stefanha/tags/net-pull-request' into staging (2014-12-20 22:04:13 +0000)
>
> are available in the git repository at:
>
>
>   https://github.com/gongleiarei/qemu.git tags/bootdevice-next-20141222
>
> for you to fetch changes up to ddcd55316fb2851e144e719171621ad2816487dc:
>
>   bootdevice: add Error **errp argument for QEMUBootSetHandler (2014-12-22 14:39:21 +0800)
>
> ----------------------------------------------------------------
> bootdevice: Refactor and improvement
>
> ----------------------------------------------------------------

Applied, thanks.

-- PMM