diff mbox

libvixl: Fix typo in comment

Message ID 1393012441-4112-1-git-send-email-sw@weilnetz.de
State Awaiting Upstream
Headers show

Commit Message

Stefan Weil Feb. 21, 2014, 7:54 p.m. UTC 
* substract -> subtract

Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
 disas/libvixl/a64/constants-a64.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Peter Maydell Feb. 24, 2014, 12:19 p.m. UTC | #1 
On 21 February 2014 19:54, Stefan Weil <sw@weilnetz.de> wrote:
> * substract -> subtract
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>  disas/libvixl/a64/constants-a64.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

It seems like a bad idea to make more changes than
necessary to a component we will probably be updating
with new upstream releases. We've made fixes where we
need to so the code will build, but fixing typos in
comments doesn't really seem worthwhile to me.

thanks
-- PMM
diff mbox

Patch

diff --git a/disas/libvixl/a64/constants-a64.h b/disas/libvixl/a64/constants-a64.h
index 2e0336d..3d7b3c1 100644
--- a/disas/libvixl/a64/constants-a64.h
+++ b/disas/libvixl/a64/constants-a64.h
@@ -71,7 +71,7 @@  V_(ImmDPShift, 15, 10, Bits)                                                   \
 V_(ImmAddSub, 21, 10, Bits)                                                    \
 V_(ShiftAddSub, 23, 22, Bits)                                                  \
                                                                                \
-/* Add/substract extend */                                                     \
+/* Add/subtract extend */                                                      \
 V_(ImmExtendShift, 12, 10, Bits)                                               \
 V_(ExtendMode, 15, 13, Bits)                                                   \
                                                                                \