diff mbox

[v12,08/15] rdma: introduce qemu_ram_foreach_block()

Message ID 1372210541-28092-9-git-send-email-mrhines@linux.vnet.ibm.com
State New
Headers show

Commit Message

mrhines@linux.vnet.ibm.com June 26, 2013, 1:35 a.m. UTC 
From: "Michael R. Hines" <mrhines@us.ibm.com>

This is used during RDMA initialization in order to
transmit a description of all the RAM blocks to the
peer for later dynamic chunk registration purposes.

Reviewed-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Chegu Vinod <chegu_vinod@hp.com>
Tested-by: Chegu Vinod <chegu_vinod@hp.com>
Tested-by: Michael R. Hines <mrhines@us.ibm.com>
Signed-off-by: Michael R. Hines <mrhines@us.ibm.com>
---
 exec.c                    |    9 +++++++++
 include/exec/cpu-common.h |    5 +++++
 2 files changed, 14 insertions(+)

Comments

Peter Maydell June 27, 2013, 7:24 p.m. UTC | #1 
On 26 June 2013 02:35,  <mrhines@linux.vnet.ibm.com> wrote:
> --- a/exec.c
> +++ b/exec.c
> @@ -2630,3 +2630,12 @@ bool cpu_physical_memory_is_io(hwaddr phys_addr)
>               memory_region_is_romd(mr));
>  }
>  #endif
> +
> +void qemu_ram_foreach_block(RAMBlockIterFunc func, void *opaque)
> +{
> +    RAMBlock *block;
> +
> +    QTAILQ_FOREACH(block, &ram_list.blocks, next) {
> +        func(block->host, block->offset, block->length, opaque);
> +    }
> +}
> diff --git a/include/exec/cpu-common.h b/include/exec/cpu-common.h
> index e061e21..92a4223 100644
> --- a/include/exec/cpu-common.h
> +++ b/include/exec/cpu-common.h
> @@ -113,6 +113,11 @@ void cpu_physical_memory_write_rom(hwaddr addr,
>  extern struct MemoryRegion io_mem_rom;
>  extern struct MemoryRegion io_mem_notdirty;
>
> +typedef void (RAMBlockIterFunc)(void *host_addr,
> +    ram_addr_t offset, ram_addr_t length, void *opaque);
> +
> +void qemu_ram_foreach_block(RAMBlockIterFunc func, void *opaque);
> +
>  #endif

The prototype is inside an ifndef CONFIG_USER_ONLY -- the
implementation needs to be as well.

thanks
-- PMM
mrhines@linux.vnet.ibm.com June 27, 2013, 7:56 p.m. UTC | #2 
On 06/27/2013 03:24 PM, Peter Maydell wrote:
> On 26 June 2013 02:35,  <mrhines@linux.vnet.ibm.com> wrote:
>> --- a/exec.c
>> +++ b/exec.c
>> @@ -2630,3 +2630,12 @@ bool cpu_physical_memory_is_io(hwaddr phys_addr)
>>                memory_region_is_romd(mr));
>>   }
>>   #endif
>> +
>> +void qemu_ram_foreach_block(RAMBlockIterFunc func, void *opaque)
>> +{
>> +    RAMBlock *block;
>> +
>> +    QTAILQ_FOREACH(block, &ram_list.blocks, next) {
>> +        func(block->host, block->offset, block->length, opaque);
>> +    }
>> +}
>> diff --git a/include/exec/cpu-common.h b/include/exec/cpu-common.h
>> index e061e21..92a4223 100644
>> --- a/include/exec/cpu-common.h
>> +++ b/include/exec/cpu-common.h
>> @@ -113,6 +113,11 @@ void cpu_physical_memory_write_rom(hwaddr addr,
>>   extern struct MemoryRegion io_mem_rom;
>>   extern struct MemoryRegion io_mem_notdirty;
>>
>> +typedef void (RAMBlockIterFunc)(void *host_addr,
>> +    ram_addr_t offset, ram_addr_t length, void *opaque);
>> +
>> +void qemu_ram_foreach_block(RAMBlockIterFunc func, void *opaque);
>> +
>>   #endif
> The prototype is inside an ifndef CONFIG_USER_ONLY -- the
> implementation needs to be as well.
>
> thanks
> -- PMM
>

Good catch. I'll send it in the next patch series ASAP.

- Michael
diff mbox

Patch

diff --git a/exec.c b/exec.c
index 0b0118b..2e6fc00 100644
--- a/exec.c
+++ b/exec.c
@@ -2630,3 +2630,12 @@  bool cpu_physical_memory_is_io(hwaddr phys_addr)
              memory_region_is_romd(mr));
 }
 #endif
+
+void qemu_ram_foreach_block(RAMBlockIterFunc func, void *opaque)
+{
+    RAMBlock *block;
+
+    QTAILQ_FOREACH(block, &ram_list.blocks, next) {
+        func(block->host, block->offset, block->length, opaque);
+    }
+}
diff --git a/include/exec/cpu-common.h b/include/exec/cpu-common.h
index e061e21..92a4223 100644
--- a/include/exec/cpu-common.h
+++ b/include/exec/cpu-common.h
@@ -113,6 +113,11 @@  void cpu_physical_memory_write_rom(hwaddr addr,
 extern struct MemoryRegion io_mem_rom;
 extern struct MemoryRegion io_mem_notdirty;
 
+typedef void (RAMBlockIterFunc)(void *host_addr,
+    ram_addr_t offset, ram_addr_t length, void *opaque);
+
+void qemu_ram_foreach_block(RAMBlockIterFunc func, void *opaque);
+
 #endif
 
 #endif /* !CPU_COMMON_H */