mbox series

[0/5] virtio-gpu: Blob resources

Message ID 20220829154058.524413-1-antonio.caggiano@collabora.com
Headers show
Series virtio-gpu: Blob resources | expand

Message

Antonio Caggiano Aug. 29, 2022, 3:40 p.m. UTC
Add shared memory and support blob resource creation, mapping and
unmapping through virglrenderer new stable APIs[0] when available.

[0] https://gitlab.freedesktop.org/virgl/virglrenderer/-/merge_requests/891

Antonio Caggiano (1):
  virtio-gpu: Handle resource blob commands

Dmitry Osipenko (1):
  virtio-gpu: Don't require udmabuf when blob support is enabled

Dr. David Alan Gilbert (1):
  virtio: Add shared memory capability

Gerd Hoffmann (1):
  virtio-gpu: hostmem

Richard Henderson (1):
  Update version for v7.1.0-rc4 release

 VERSION                              |   2 +-
 hw/display/virtio-gpu-pci.c          |  15 +++
 hw/display/virtio-gpu-virgl.c        | 169 +++++++++++++++++++++++++++
 hw/display/virtio-gpu.c              |  25 ++--
 hw/display/virtio-vga.c              |  33 ++++--
 hw/virtio/virtio-pci.c               |  18 +++
 include/hw/virtio/virtio-gpu-bswap.h |  18 +++
 include/hw/virtio/virtio-gpu.h       |  11 ++
 include/hw/virtio/virtio-pci.h       |   4 +
 meson.build                          |   5 +
 10 files changed, 276 insertions(+), 24 deletions(-)

Comments

Marc-André Lureau Aug. 30, 2022, 11:07 a.m. UTC | #1
Hi

On Mon, Aug 29, 2022 at 7:46 PM Antonio Caggiano <
antonio.caggiano@collabora.com> wrote:

> Add shared memory and support blob resource creation, mapping and
> unmapping through virglrenderer new stable APIs[0] when available.
>
> [0]
> https://gitlab.freedesktop.org/virgl/virglrenderer/-/merge_requests/891


This is merged, and will be part of 0.10 (
https://gitlab.freedesktop.org/virgl/virglrenderer/-/milestones/9#tab-issues),
hopefully soon to be released.

The series looks ok to me, except for the few comments I left. Could you
please update the documentation too?

thanks


>
> Antonio Caggiano (1):
>   virtio-gpu: Handle resource blob commands
>
> Dmitry Osipenko (1):
>   virtio-gpu: Don't require udmabuf when blob support is enabled
>
> Dr. David Alan Gilbert (1):
>   virtio: Add shared memory capability
>
> Gerd Hoffmann (1):
>   virtio-gpu: hostmem
>
> Richard Henderson (1):
>   Update version for v7.1.0-rc4 release
>
>  VERSION                              |   2 +-
>  hw/display/virtio-gpu-pci.c          |  15 +++
>  hw/display/virtio-gpu-virgl.c        | 169 +++++++++++++++++++++++++++
>  hw/display/virtio-gpu.c              |  25 ++--
>  hw/display/virtio-vga.c              |  33 ++++--
>  hw/virtio/virtio-pci.c               |  18 +++
>  include/hw/virtio/virtio-gpu-bswap.h |  18 +++
>  include/hw/virtio/virtio-gpu.h       |  11 ++
>  include/hw/virtio/virtio-pci.h       |   4 +
>  meson.build                          |   5 +
>  10 files changed, 276 insertions(+), 24 deletions(-)
>
> --
> 2.34.1
>
>
>
Antonio Caggiano Sept. 12, 2022, 8:58 a.m. UTC | #2
Hi Marc-André,

On 30/08/2022 13:07, Marc-André Lureau wrote:
> Hi
> 
> On Mon, Aug 29, 2022 at 7:46 PM Antonio Caggiano 
> <antonio.caggiano@collabora.com <mailto:antonio.caggiano@collabora.com>> 
> wrote:
> 
>     Add shared memory and support blob resource creation, mapping and
>     unmapping through virglrenderer new stable APIs[0] when available.
> 
>     [0]
>     https://gitlab.freedesktop.org/virgl/virglrenderer/-/merge_requests/891 <https://gitlab.freedesktop.org/virgl/virglrenderer/-/merge_requests/891>
> 
> 
> This is merged, and will be part of 0.10 
> (https://gitlab.freedesktop.org/virgl/virglrenderer/-/milestones/9#tab-issues <https://gitlab.freedesktop.org/virgl/virglrenderer/-/milestones/9#tab-issues>), hopefully soon to be released.
> 
> The series looks ok to me, except for the few comments I left. Could you 
> please update the documentation too?

Which documentation are you referring to?

> 
> thanks
> 
> 
> 
>     Antonio Caggiano (1):
>        virtio-gpu: Handle resource blob commands
> 
>     Dmitry Osipenko (1):
>        virtio-gpu: Don't require udmabuf when blob support is enabled
> 
>     Dr. David Alan Gilbert (1):
>        virtio: Add shared memory capability
> 
>     Gerd Hoffmann (1):
>        virtio-gpu: hostmem
> 
>     Richard Henderson (1):
>        Update version for v7.1.0-rc4 release
> 
>       VERSION                              |   2 +-
>       hw/display/virtio-gpu-pci.c          |  15 +++
>       hw/display/virtio-gpu-virgl.c        | 169 +++++++++++++++++++++++++++
>       hw/display/virtio-gpu.c              |  25 ++--
>       hw/display/virtio-vga.c              |  33 ++++--
>       hw/virtio/virtio-pci.c               |  18 +++
>       include/hw/virtio/virtio-gpu-bswap.h |  18 +++
>       include/hw/virtio/virtio-gpu.h       |  11 ++
>       include/hw/virtio/virtio-pci.h       |   4 +
>       meson.build                          |   5 +
>       10 files changed, 276 insertions(+), 24 deletions(-)
> 
>     -- 
>     2.34.1
> 
> 
> 
> 
> -- 
> Marc-André Lureau
Marc-André Lureau Sept. 12, 2022, 9:19 a.m. UTC | #3
Hi

On Mon, Sep 12, 2022 at 12:58 PM Antonio Caggiano <
antonio.caggiano@collabora.com> wrote:

> Hi Marc-André,
>
> On 30/08/2022 13:07, Marc-André Lureau wrote:
> > Hi
> >
> > On Mon, Aug 29, 2022 at 7:46 PM Antonio Caggiano
> > <antonio.caggiano@collabora.com <mailto:antonio.caggiano@collabora.com>>
>
> > wrote:
> >
> >     Add shared memory and support blob resource creation, mapping and
> >     unmapping through virglrenderer new stable APIs[0] when available.
> >
> >     [0]
> >
> https://gitlab.freedesktop.org/virgl/virglrenderer/-/merge_requests/891 <
> https://gitlab.freedesktop.org/virgl/virglrenderer/-/merge_requests/891>
> >
> >
> > This is merged, and will be part of 0.10
> > (
> https://gitlab.freedesktop.org/virgl/virglrenderer/-/milestones/9#tab-issues
> <
> https://gitlab.freedesktop.org/virgl/virglrenderer/-/milestones/9#tab-issues>),
> hopefully soon to be released.
> >
> > The series looks ok to me, except for the few comments I left. Could you
> > please update the documentation too?
>
> Which documentation are you referring to?
>

Oh indeed, we really lack documentation about graphics! not your fault  ..
could you at least give some hints in the commit message how to enable /
test this feature?

thanks