mbox series

[v2,0/7] ui/cocoa: Use OSX's main loop

Message ID 20190214102816.3393-1-peter.maydell@linaro.org
Headers show
Series ui/cocoa: Use OSX's main loop | expand

Message

Peter Maydell Feb. 14, 2019, 10:28 a.m. UTC 
This set of patches rearranges how we handle events on
the OSX Cocoa UI so that we use the main thread to run
the OSX event loop, and we don't do a long blocking
operation from the applicationDidFinishLaunching callback.
Instead we create a second thread which runs qemu_main()
and becomes the QEMU main-loop thread. The callbacks from
QEMU into the cocoa code asynchronously dispatch their
work to the main thread, and the main thread takes the
iothread lock before calling into QEMU code.

NB: the code to asynchronously run code blocks on the
main thread uses dispatch_get_main_queue(), which is a
10.10-or-later function. I think the benefit in
clarity-of-code is a worthwhile gain for dropping support
for ancient OSX versions.

The change from v1 is that we actually wire up input events
from OSX to the handleEvent method. There are a couple of
plausible ways we could do this:

 * most OSX apps do this by implementing event handling
   methods on their NSView. This won't work for us, because
   these only get called after OSX has dealt with some events
   like menu bar accelerator keystrokes, and we would like to
   send those to the guest instead in some situations.
 * we could use addLocalMonitorForEventsMatchingMask to
   add a "local event monitor", which gets to examine/filter
   events before the usual OSX event processing. I think this
   would work, but it's not what I chose
 * we can subclass NSApplication and implement a custom
   sendEvent method in our subclass. This gets all events
   first and can either handle them or call the superclass
   sendEvent to hand them to OSX as usual. This is what I
   ended up going for.
 * It is also possible to implement sendEvent on NSWindow,
   but I think this has the "only called after OSX has done
   menu keystroke processing" issue.

I've tested this a bit better than the v1 RFC, and it seems
to work OK for me.

Patchset structure:
 * patch 1 does the "make sure we have the iothread lock for
   calls into QEMU" (which is effectively a no-op initially
   since we'll already be holding that lock when our refresh
   etc callbacks are called)
 * patch 2 makes switchSurface directly take the pixman image
   (which is refcounted) rather than the DisplaySurface (which
   is not), so we can make the calls to it asynchronous later
 * patches 3 and 4 are just trivial code motion
 * patch 5 (new in v2) restructures handleEvent so it doesn't
   directly call sendEvent but instead returns a flag indicating
   whether it consumed the event or not
 * patch 6 (new in v2) subclasses NSApplication
 * patch 7 (the old patch 5) does the bulk of the work (and can't
   really be split further without the UI being broken at the
   intermediate point)

thanks
-- PMM


Peter Maydell (7):
  ui/cocoa: Ensure we have the iothread lock when calling into QEMU
  ui/cocoa: Use the pixman image directly in switchSurface
  ui/cocoa: Factor out initial menu creation
  ui/cocoa: Move console/device menu creation code up in file
  ui/cocoa: Don't call NSApp sendEvent directly from handleEvent
  ui/cocoa: Subclass NSApplication so we can implement sendEvent
  ui/cocoa: Perform UI operations only on the main thread

 ui/cocoa.m | 483 ++++++++++++++++++++++++++++++++---------------------
 1 file changed, 294 insertions(+), 189 deletions(-)

Comments

no-reply@patchew.org Feb. 14, 2019, 11:07 a.m. UTC | #1 
Patchew URL: https://patchew.org/QEMU/20190214102816.3393-1-peter.maydell@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190214102816.3393-1-peter.maydell@linaro.org
Subject: [Qemu-devel] [PATCH v2 0/7] ui/cocoa: Use OSX's main loop
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20190212134758.10514-1-dgilbert@redhat.com -> patchew/20190212134758.10514-1-dgilbert@redhat.com
 * [new tag]               patchew/20190214102816.3393-1-peter.maydell@linaro.org -> patchew/20190214102816.3393-1-peter.maydell@linaro.org
Switched to a new branch 'test'
b6de88ab3a ui/cocoa: Perform UI operations only on the main thread
1940bfd263 ui/cocoa: Subclass NSApplication so we can implement sendEvent
724525dbfc ui/cocoa: Don't call NSApp sendEvent directly from handleEvent
dcd07aa31c ui/cocoa: Move console/device menu creation code up in file
f0890fa38d ui/cocoa: Factor out initial menu creation
9669817763 ui/cocoa: Use the pixman image directly in switchSurface
bcffb41705 ui/cocoa: Ensure we have the iothread lock when calling into QEMU

=== OUTPUT BEGIN ===
1/7 Checking commit bcffb41705d0 (ui/cocoa: Ensure we have the iothread lock when calling into QEMU)
2/7 Checking commit 96698177637f (ui/cocoa: Use the pixman image directly in switchSurface)
3/7 Checking commit f0890fa38dc1 (ui/cocoa: Factor out initial menu creation)
4/7 Checking commit dcd07aa31c3b (ui/cocoa: Move console/device menu creation code up in file)
5/7 Checking commit 724525dbfc09 (ui/cocoa: Don't call NSApp sendEvent directly from handleEvent)
ERROR: trailing whitespace
#41: FILE: ui/cocoa.m:152:
+    $

total: 1 errors, 0 warnings, 122 lines checked

Patch 5/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

6/7 Checking commit 1940bfd26326 (ui/cocoa: Subclass NSApplication so we can implement sendEvent)
7/7 Checking commit b6de88ab3a67 (ui/cocoa: Perform UI operations only on the main thread)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190214102816.3393-1-peter.maydell@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
no-reply@patchew.org Feb. 14, 2019, 11:11 a.m. UTC | #2 
Patchew URL: https://patchew.org/QEMU/20190214102816.3393-1-peter.maydell@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v2 0/7] ui/cocoa: Use OSX's main loop
Message-id: 20190214102816.3393-1-peter.maydell@linaro.org
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20190212074840.13542-1-richard.henderson@linaro.org -> patchew/20190212074840.13542-1-richard.henderson@linaro.org
 - [tag update]      patchew/20190212134758.10514-1-dgilbert@redhat.com -> patchew/20190212134758.10514-1-dgilbert@redhat.com
 - [tag update]      patchew/20190214031004.32522-1-stefanha@redhat.com -> patchew/20190214031004.32522-1-stefanha@redhat.com
 * [new tag]         patchew/20190214084939.20640-1-richardw.yang@linux.intel.com -> patchew/20190214084939.20640-1-richardw.yang@linux.intel.com
 * [new tag]         patchew/20190214093053.1400-1-armbru@redhat.com -> patchew/20190214093053.1400-1-armbru@redhat.com
 * [new tag]         patchew/20190214102816.3393-1-peter.maydell@linaro.org -> patchew/20190214102816.3393-1-peter.maydell@linaro.org
Submodule 'capstone' (https://git.qemu.org/git/capstone.git) registered for path 'capstone'
Submodule 'dtc' (https://git.qemu.org/git/dtc.git) registered for path 'dtc'
Submodule 'roms/QemuMacDrivers' (https://git.qemu.org/git/QemuMacDrivers.git) registered for path 'roms/QemuMacDrivers'
Submodule 'roms/SLOF' (https://git.qemu.org/git/SLOF.git) registered for path 'roms/SLOF'
Submodule 'roms/ipxe' (https://git.qemu.org/git/ipxe.git) registered for path 'roms/ipxe'
Submodule 'roms/openbios' (https://git.qemu.org/git/openbios.git) registered for path 'roms/openbios'
Submodule 'roms/openhackware' (https://git.qemu.org/git/openhackware.git) registered for path 'roms/openhackware'
Submodule 'roms/qemu-palcode' (https://git.qemu.org/git/qemu-palcode.git) registered for path 'roms/qemu-palcode'
Submodule 'roms/seabios' (https://git.qemu.org/git/seabios.git/) registered for path 'roms/seabios'
Submodule 'roms/seabios-hppa' (https://github.com/hdeller/seabios-hppa.git) registered for path 'roms/seabios-hppa'
Submodule 'roms/sgabios' (https://git.qemu.org/git/sgabios.git) registered for path 'roms/sgabios'
Submodule 'roms/skiboot' (https://git.qemu.org/git/skiboot.git) registered for path 'roms/skiboot'
Submodule 'roms/u-boot' (https://git.qemu.org/git/u-boot.git) registered for path 'roms/u-boot'
Submodule 'roms/u-boot-sam460ex' (https://git.qemu.org/git/u-boot-sam460ex.git) registered for path 'roms/u-boot-sam460ex'
Submodule 'tests/fp/berkeley-softfloat-3' (https://github.com/cota/berkeley-softfloat-3) registered for path 'tests/fp/berkeley-softfloat-3'
Submodule 'tests/fp/berkeley-testfloat-3' (https://github.com/cota/berkeley-testfloat-3) registered for path 'tests/fp/berkeley-testfloat-3'
Submodule 'ui/keycodemapdb' (https://git.qemu.org/git/keycodemapdb.git) registered for path 'ui/keycodemapdb'
Cloning into 'capstone'...
Submodule path 'capstone': checked out '22ead3e0bfdb87516656453336160e0a37b066bf'
Cloning into 'dtc'...
Submodule path 'dtc': checked out '88f18909db731a627456f26d779445f84e449536'
Cloning into 'roms/QemuMacDrivers'...
Submodule path 'roms/QemuMacDrivers': checked out '90c488d5f4a407342247b9ea869df1c2d9c8e266'
Cloning into 'roms/SLOF'...
Submodule path 'roms/SLOF': checked out 'a5b428e1c1eae703bdd62a3f527223c291ee3fdc'
Cloning into 'roms/ipxe'...
Submodule path 'roms/ipxe': checked out 'de4565cbe76ea9f7913a01f331be3ee901bb6e17'
Cloning into 'roms/openbios'...
Submodule path 'roms/openbios': checked out '441a84d3a642a10b948369c63f32367e8ff6395b'
Cloning into 'roms/openhackware'...
Submodule path 'roms/openhackware': checked out 'c559da7c8eec5e45ef1f67978827af6f0b9546f5'
Cloning into 'roms/qemu-palcode'...
Submodule path 'roms/qemu-palcode': checked out '51c237d7e20d05100eacadee2f61abc17e6bc097'
Cloning into 'roms/seabios'...
Submodule path 'roms/seabios': checked out 'a698c8995ffb2838296ec284fe3c4ad33dfca307'
Cloning into 'roms/seabios-hppa'...
Submodule path 'roms/seabios-hppa': checked out '1ef99a01572c2581c30e16e6fe69e9ea2ef92ce0'
Cloning into 'roms/sgabios'...
Submodule path 'roms/sgabios': checked out 'cbaee52287e5f32373181cff50a00b6c4ac9015a'
Cloning into 'roms/skiboot'...
Submodule path 'roms/skiboot': checked out 'e0ee24c27a172bcf482f6f2bc905e6211c134bcc'
Cloning into 'roms/u-boot'...
Submodule path 'roms/u-boot': checked out 'd85ca029f257b53a96da6c2fb421e78a003a9943'
Cloning into 'roms/u-boot-sam460ex'...
Submodule path 'roms/u-boot-sam460ex': checked out '60b3916f33e617a815973c5a6df77055b2e3a588'
Cloning into 'tests/fp/berkeley-softfloat-3'...
Submodule path 'tests/fp/berkeley-softfloat-3': checked out 'b64af41c3276f97f0e181920400ee056b9c88037'
Cloning into 'tests/fp/berkeley-testfloat-3'...
Submodule path 'tests/fp/berkeley-testfloat-3': checked out '5a59dcec19327396a011a17fd924aed4fec416b3'
Cloning into 'ui/keycodemapdb'...
Submodule path 'ui/keycodemapdb': checked out '6b3d716e2b6472eb7189d3220552280ef3d832ce'
Switched to a new branch 'test'
b6de88a ui/cocoa: Perform UI operations only on the main thread
1940bfd ui/cocoa: Subclass NSApplication so we can implement sendEvent
724525d ui/cocoa: Don't call NSApp sendEvent directly from handleEvent
dcd07aa ui/cocoa: Move console/device menu creation code up in file
f0890fa ui/cocoa: Factor out initial menu creation
96698177 ui/cocoa: Use the pixman image directly in switchSurface
bcffb41 ui/cocoa: Ensure we have the iothread lock when calling into QEMU

=== OUTPUT BEGIN ===
1/7 Checking commit bcffb41705d0 (ui/cocoa: Ensure we have the iothread lock when calling into QEMU)
2/7 Checking commit 96698177637f (ui/cocoa: Use the pixman image directly in switchSurface)
3/7 Checking commit f0890fa38dc1 (ui/cocoa: Factor out initial menu creation)
4/7 Checking commit dcd07aa31c3b (ui/cocoa: Move console/device menu creation code up in file)
5/7 Checking commit 724525dbfc09 (ui/cocoa: Don't call NSApp sendEvent directly from handleEvent)
ERROR: trailing whitespace
#41: FILE: ui/cocoa.m:152:
+    $

total: 1 errors, 0 warnings, 122 lines checked

Patch 5/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

6/7 Checking commit 1940bfd26326 (ui/cocoa: Subclass NSApplication so we can implement sendEvent)
7/7 Checking commit b6de88ab3a67 (ui/cocoa: Perform UI operations only on the main thread)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190214102816.3393-1-peter.maydell@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
no-reply@patchew.org Feb. 14, 2019, 5:44 p.m. UTC | #3 
Patchew URL: https://patchew.org/QEMU/20190214102816.3393-1-peter.maydell@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190214102816.3393-1-peter.maydell@linaro.org
Subject: [Qemu-devel] [PATCH v2 0/7] ui/cocoa: Use OSX's main loop
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
8d76c56d6c ui/cocoa: Perform UI operations only on the main thread
3aee068a7c ui/cocoa: Subclass NSApplication so we can implement sendEvent
1da7a6a150 ui/cocoa: Don't call NSApp sendEvent directly from handleEvent
07e0180720 ui/cocoa: Move console/device menu creation code up in file
ae490d83db ui/cocoa: Factor out initial menu creation
4b0ac50558 ui/cocoa: Use the pixman image directly in switchSurface
c83f0eb31d ui/cocoa: Ensure we have the iothread lock when calling into QEMU

=== OUTPUT BEGIN ===
1/7 Checking commit c83f0eb31d04 (ui/cocoa: Ensure we have the iothread lock when calling into QEMU)
2/7 Checking commit 4b0ac5055867 (ui/cocoa: Use the pixman image directly in switchSurface)
3/7 Checking commit ae490d83dba7 (ui/cocoa: Factor out initial menu creation)
4/7 Checking commit 07e018072093 (ui/cocoa: Move console/device menu creation code up in file)
5/7 Checking commit 1da7a6a15059 (ui/cocoa: Don't call NSApp sendEvent directly from handleEvent)
ERROR: trailing whitespace
#41: FILE: ui/cocoa.m:152:
+    $

total: 1 errors, 0 warnings, 122 lines checked

Patch 5/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

6/7 Checking commit 3aee068a7c6a (ui/cocoa: Subclass NSApplication so we can implement sendEvent)
7/7 Checking commit 8d76c56d6c33 (ui/cocoa: Perform UI operations only on the main thread)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190214102816.3393-1-peter.maydell@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
no-reply@patchew.org Feb. 14, 2019, 5:48 p.m. UTC | #4 
Patchew URL: https://patchew.org/QEMU/20190214102816.3393-1-peter.maydell@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v2 0/7] ui/cocoa: Use OSX's main loop
Message-id: 20190214102816.3393-1-peter.maydell@linaro.org
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20190214102816.3393-1-peter.maydell@linaro.org -> patchew/20190214102816.3393-1-peter.maydell@linaro.org
 - [tag update]      patchew/cover.1549857716.git.balaton@eik.bme.hu -> patchew/cover.1549857716.git.balaton@eik.bme.hu
Submodule 'capstone' (https://git.qemu.org/git/capstone.git) registered for path 'capstone'
Submodule 'dtc' (https://git.qemu.org/git/dtc.git) registered for path 'dtc'
Submodule 'roms/QemuMacDrivers' (https://git.qemu.org/git/QemuMacDrivers.git) registered for path 'roms/QemuMacDrivers'
Submodule 'roms/SLOF' (https://git.qemu.org/git/SLOF.git) registered for path 'roms/SLOF'
Submodule 'roms/ipxe' (https://git.qemu.org/git/ipxe.git) registered for path 'roms/ipxe'
Submodule 'roms/openbios' (https://git.qemu.org/git/openbios.git) registered for path 'roms/openbios'
Submodule 'roms/openhackware' (https://git.qemu.org/git/openhackware.git) registered for path 'roms/openhackware'
Submodule 'roms/qemu-palcode' (https://git.qemu.org/git/qemu-palcode.git) registered for path 'roms/qemu-palcode'
Submodule 'roms/seabios' (https://git.qemu.org/git/seabios.git/) registered for path 'roms/seabios'
Submodule 'roms/seabios-hppa' (https://github.com/hdeller/seabios-hppa.git) registered for path 'roms/seabios-hppa'
Submodule 'roms/sgabios' (https://git.qemu.org/git/sgabios.git) registered for path 'roms/sgabios'
Submodule 'roms/skiboot' (https://git.qemu.org/git/skiboot.git) registered for path 'roms/skiboot'
Submodule 'roms/u-boot' (https://git.qemu.org/git/u-boot.git) registered for path 'roms/u-boot'
Submodule 'roms/u-boot-sam460ex' (https://git.qemu.org/git/u-boot-sam460ex.git) registered for path 'roms/u-boot-sam460ex'
Submodule 'tests/fp/berkeley-softfloat-3' (https://github.com/cota/berkeley-softfloat-3) registered for path 'tests/fp/berkeley-softfloat-3'
Submodule 'tests/fp/berkeley-testfloat-3' (https://github.com/cota/berkeley-testfloat-3) registered for path 'tests/fp/berkeley-testfloat-3'
Submodule 'ui/keycodemapdb' (https://git.qemu.org/git/keycodemapdb.git) registered for path 'ui/keycodemapdb'
Cloning into 'capstone'...
Submodule path 'capstone': checked out '22ead3e0bfdb87516656453336160e0a37b066bf'
Cloning into 'dtc'...
Submodule path 'dtc': checked out '88f18909db731a627456f26d779445f84e449536'
Cloning into 'roms/QemuMacDrivers'...
Submodule path 'roms/QemuMacDrivers': checked out '90c488d5f4a407342247b9ea869df1c2d9c8e266'
Cloning into 'roms/SLOF'...
Submodule path 'roms/SLOF': checked out 'a5b428e1c1eae703bdd62a3f527223c291ee3fdc'
Cloning into 'roms/ipxe'...
Submodule path 'roms/ipxe': checked out 'de4565cbe76ea9f7913a01f331be3ee901bb6e17'
Cloning into 'roms/openbios'...
Submodule path 'roms/openbios': checked out '441a84d3a642a10b948369c63f32367e8ff6395b'
Cloning into 'roms/openhackware'...
Submodule path 'roms/openhackware': checked out 'c559da7c8eec5e45ef1f67978827af6f0b9546f5'
Cloning into 'roms/qemu-palcode'...
Submodule path 'roms/qemu-palcode': checked out '51c237d7e20d05100eacadee2f61abc17e6bc097'
Cloning into 'roms/seabios'...
Submodule path 'roms/seabios': checked out 'a698c8995ffb2838296ec284fe3c4ad33dfca307'
Cloning into 'roms/seabios-hppa'...
Submodule path 'roms/seabios-hppa': checked out '1ef99a01572c2581c30e16e6fe69e9ea2ef92ce0'
Cloning into 'roms/sgabios'...
Submodule path 'roms/sgabios': checked out 'cbaee52287e5f32373181cff50a00b6c4ac9015a'
Cloning into 'roms/skiboot'...
Submodule path 'roms/skiboot': checked out 'e0ee24c27a172bcf482f6f2bc905e6211c134bcc'
Cloning into 'roms/u-boot'...
Submodule path 'roms/u-boot': checked out 'd85ca029f257b53a96da6c2fb421e78a003a9943'
Cloning into 'roms/u-boot-sam460ex'...
Submodule path 'roms/u-boot-sam460ex': checked out '60b3916f33e617a815973c5a6df77055b2e3a588'
Cloning into 'tests/fp/berkeley-softfloat-3'...
Submodule path 'tests/fp/berkeley-softfloat-3': checked out 'b64af41c3276f97f0e181920400ee056b9c88037'
Cloning into 'tests/fp/berkeley-testfloat-3'...
Submodule path 'tests/fp/berkeley-testfloat-3': checked out '5a59dcec19327396a011a17fd924aed4fec416b3'
Cloning into 'ui/keycodemapdb'...
Submodule path 'ui/keycodemapdb': checked out '6b3d716e2b6472eb7189d3220552280ef3d832ce'
Switched to a new branch 'test'
8d76c56 ui/cocoa: Perform UI operations only on the main thread
3aee068 ui/cocoa: Subclass NSApplication so we can implement sendEvent
1da7a6a ui/cocoa: Don't call NSApp sendEvent directly from handleEvent
07e0180 ui/cocoa: Move console/device menu creation code up in file
ae490d8 ui/cocoa: Factor out initial menu creation
4b0ac50 ui/cocoa: Use the pixman image directly in switchSurface
c83f0eb ui/cocoa: Ensure we have the iothread lock when calling into QEMU

=== OUTPUT BEGIN ===
1/7 Checking commit c83f0eb31d04 (ui/cocoa: Ensure we have the iothread lock when calling into QEMU)
2/7 Checking commit 4b0ac5055867 (ui/cocoa: Use the pixman image directly in switchSurface)
3/7 Checking commit ae490d83dba7 (ui/cocoa: Factor out initial menu creation)
4/7 Checking commit 07e018072093 (ui/cocoa: Move console/device menu creation code up in file)
5/7 Checking commit 1da7a6a15059 (ui/cocoa: Don't call NSApp sendEvent directly from handleEvent)
ERROR: trailing whitespace
#41: FILE: ui/cocoa.m:152:
+    $

total: 1 errors, 0 warnings, 122 lines checked

Patch 5/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

6/7 Checking commit 3aee068a7c6a (ui/cocoa: Subclass NSApplication so we can implement sendEvent)
7/7 Checking commit 8d76c56d6c33 (ui/cocoa: Perform UI operations only on the main thread)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190214102816.3393-1-peter.maydell@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
no-reply@patchew.org Feb. 14, 2019, 5:52 p.m. UTC | #5 
Patchew URL: https://patchew.org/QEMU/20190214102816.3393-1-peter.maydell@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190214102816.3393-1-peter.maydell@linaro.org
Subject: [Qemu-devel] [PATCH v2 0/7] ui/cocoa: Use OSX's main loop
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20190214102816.3393-1-peter.maydell@linaro.org -> patchew/20190214102816.3393-1-peter.maydell@linaro.org
Switched to a new branch 'test'
0538b64902 ui/cocoa: Perform UI operations only on the main thread
9c813776c5 ui/cocoa: Subclass NSApplication so we can implement sendEvent
ee910daa7f ui/cocoa: Don't call NSApp sendEvent directly from handleEvent
475c73329c ui/cocoa: Move console/device menu creation code up in file
84187b00a1 ui/cocoa: Factor out initial menu creation
ec9d2d35f1 ui/cocoa: Use the pixman image directly in switchSurface
31e3ce4546 ui/cocoa: Ensure we have the iothread lock when calling into QEMU

=== OUTPUT BEGIN ===
1/7 Checking commit 31e3ce4546b9 (ui/cocoa: Ensure we have the iothread lock when calling into QEMU)
2/7 Checking commit ec9d2d35f160 (ui/cocoa: Use the pixman image directly in switchSurface)
3/7 Checking commit 84187b00a139 (ui/cocoa: Factor out initial menu creation)
4/7 Checking commit 475c73329cdd (ui/cocoa: Move console/device menu creation code up in file)
5/7 Checking commit ee910daa7f20 (ui/cocoa: Don't call NSApp sendEvent directly from handleEvent)
ERROR: trailing whitespace
#42: FILE: ui/cocoa.m:152:
+    $

total: 1 errors, 0 warnings, 122 lines checked

Patch 5/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

6/7 Checking commit 9c813776c52a (ui/cocoa: Subclass NSApplication so we can implement sendEvent)
7/7 Checking commit 0538b64902ce (ui/cocoa: Perform UI operations only on the main thread)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190214102816.3393-1-peter.maydell@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
no-reply@patchew.org Feb. 15, 2019, 1:01 a.m. UTC | #6 
Patchew URL: https://patchew.org/QEMU/20190214102816.3393-1-peter.maydell@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190214102816.3393-1-peter.maydell@linaro.org
Subject: [Qemu-devel] [PATCH v2 0/7] ui/cocoa: Use OSX's main loop
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20190214102816.3393-1-peter.maydell@linaro.org -> patchew/20190214102816.3393-1-peter.maydell@linaro.org
 t [tag update]            patchew/20190214190603.25030-1-peter.maydell@linaro.org -> patchew/20190214190603.25030-1-peter.maydell@linaro.org
Switched to a new branch 'test'
9aa7dd27d3 ui/cocoa: Perform UI operations only on the main thread
417e53a95a ui/cocoa: Subclass NSApplication so we can implement sendEvent
211ca5f248 ui/cocoa: Don't call NSApp sendEvent directly from handleEvent
17de4a307c ui/cocoa: Move console/device menu creation code up in file
cf54a90e45 ui/cocoa: Factor out initial menu creation
5f7c287c74 ui/cocoa: Use the pixman image directly in switchSurface
53f929697b ui/cocoa: Ensure we have the iothread lock when calling into QEMU

=== OUTPUT BEGIN ===
1/7 Checking commit 53f929697be6 (ui/cocoa: Ensure we have the iothread lock when calling into QEMU)
2/7 Checking commit 5f7c287c7483 (ui/cocoa: Use the pixman image directly in switchSurface)
3/7 Checking commit cf54a90e45cd (ui/cocoa: Factor out initial menu creation)
4/7 Checking commit 17de4a307c5a (ui/cocoa: Move console/device menu creation code up in file)
5/7 Checking commit 211ca5f248f2 (ui/cocoa: Don't call NSApp sendEvent directly from handleEvent)
ERROR: trailing whitespace
#42: FILE: ui/cocoa.m:152:
+    $

total: 1 errors, 0 warnings, 122 lines checked

Patch 5/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

6/7 Checking commit 417e53a95ae0 (ui/cocoa: Subclass NSApplication so we can implement sendEvent)
7/7 Checking commit 9aa7dd27d3bb (ui/cocoa: Perform UI operations only on the main thread)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190214102816.3393-1-peter.maydell@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
no-reply@patchew.org Feb. 27, 2019, 3:24 p.m. UTC | #7 
Patchew URL: https://patchew.org/QEMU/20190214102816.3393-1-peter.maydell@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190214102816.3393-1-peter.maydell@linaro.org
Subject: [Qemu-devel] [PATCH v2 0/7] ui/cocoa: Use OSX's main loop
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20190215174548.2630-1-yury-kotov@yandex-team.ru -> patchew/20190215174548.2630-1-yury-kotov@yandex-team.ru
Switched to a new branch 'test'
93a3cf9c42 ui/cocoa: Perform UI operations only on the main thread
7eb130375a ui/cocoa: Subclass NSApplication so we can implement sendEvent
556e313bf5 ui/cocoa: Don't call NSApp sendEvent directly from handleEvent
5e20ccf63c ui/cocoa: Move console/device menu creation code up in file
017353b840 ui/cocoa: Factor out initial menu creation
455ce903fa ui/cocoa: Use the pixman image directly in switchSurface
02b675ede0 ui/cocoa: Ensure we have the iothread lock when calling into QEMU

=== OUTPUT BEGIN ===
1/7 Checking commit 02b675ede0a2 (ui/cocoa: Ensure we have the iothread lock when calling into QEMU)
2/7 Checking commit 455ce903fa09 (ui/cocoa: Use the pixman image directly in switchSurface)
3/7 Checking commit 017353b840b4 (ui/cocoa: Factor out initial menu creation)
4/7 Checking commit 5e20ccf63c62 (ui/cocoa: Move console/device menu creation code up in file)
5/7 Checking commit 556e313bf5e1 (ui/cocoa: Don't call NSApp sendEvent directly from handleEvent)
ERROR: trailing whitespace
#44: FILE: ui/cocoa.m:152:
+    $

total: 1 errors, 0 warnings, 122 lines checked

Patch 5/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

6/7 Checking commit 7eb130375ad0 (ui/cocoa: Subclass NSApplication so we can implement sendEvent)
7/7 Checking commit 93a3cf9c4268 (ui/cocoa: Perform UI operations only on the main thread)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190214102816.3393-1-peter.maydell@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
no-reply@patchew.org Feb. 27, 2019, 3:29 p.m. UTC | #8 
Patchew URL: https://patchew.org/QEMU/20190214102816.3393-1-peter.maydell@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190214102816.3393-1-peter.maydell@linaro.org
Type: series
Subject: [Qemu-devel] [PATCH v2 0/7] ui/cocoa: Use OSX's main loop

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
   2e68b86..86c7e2f  master     -> master
 - [tag update]      patchew/1549562254-41157-1-git-send-email-pbonzini@redhat.com -> patchew/1549562254-41157-1-git-send-email-pbonzini@redhat.com
 - [tag update]      patchew/1550076626-7202-1-git-send-email-sandra@codesourcery.com -> patchew/1550076626-7202-1-git-send-email-sandra@codesourcery.com
 - [tag update]      patchew/20190114111744.113188-1-anton.nefedov@virtuozzo.com -> patchew/20190114111744.113188-1-anton.nefedov@virtuozzo.com
 - [tag update]      patchew/20190129175403.18017-1-philmd@redhat.com -> patchew/20190129175403.18017-1-philmd@redhat.com
 - [tag update]      patchew/20190211144421.106232-1-vsementsov@virtuozzo.com -> patchew/20190211144421.106232-1-vsementsov@virtuozzo.com
 - [tag update]      patchew/20190212193855.13223-1-ccarrara@redhat.com -> patchew/20190212193855.13223-1-ccarrara@redhat.com
 - [tag update]      patchew/20190214043916.22128-1-david@gibson.dropbear.id.au -> patchew/20190214043916.22128-1-david@gibson.dropbear.id.au
 - [tag update]      patchew/20190214102816.3393-1-peter.maydell@linaro.org -> patchew/20190214102816.3393-1-peter.maydell@linaro.org
 - [tag update]      patchew/20190215174548.2630-1-yury-kotov@yandex-team.ru -> patchew/20190215174548.2630-1-yury-kotov@yandex-team.ru
Submodule 'capstone' (https://git.qemu.org/git/capstone.git) registered for path 'capstone'
Submodule 'dtc' (https://git.qemu.org/git/dtc.git) registered for path 'dtc'
Submodule 'roms/QemuMacDrivers' (https://git.qemu.org/git/QemuMacDrivers.git) registered for path 'roms/QemuMacDrivers'
Submodule 'roms/SLOF' (https://git.qemu.org/git/SLOF.git) registered for path 'roms/SLOF'
Submodule 'roms/ipxe' (https://git.qemu.org/git/ipxe.git) registered for path 'roms/ipxe'
Submodule 'roms/openbios' (https://git.qemu.org/git/openbios.git) registered for path 'roms/openbios'
Submodule 'roms/openhackware' (https://git.qemu.org/git/openhackware.git) registered for path 'roms/openhackware'
Submodule 'roms/qemu-palcode' (https://git.qemu.org/git/qemu-palcode.git) registered for path 'roms/qemu-palcode'
Submodule 'roms/seabios' (https://git.qemu.org/git/seabios.git/) registered for path 'roms/seabios'
Submodule 'roms/seabios-hppa' (https://github.com/hdeller/seabios-hppa.git) registered for path 'roms/seabios-hppa'
Submodule 'roms/sgabios' (https://git.qemu.org/git/sgabios.git) registered for path 'roms/sgabios'
Submodule 'roms/skiboot' (https://git.qemu.org/git/skiboot.git) registered for path 'roms/skiboot'
Submodule 'roms/u-boot' (https://git.qemu.org/git/u-boot.git) registered for path 'roms/u-boot'
Submodule 'roms/u-boot-sam460ex' (https://git.qemu.org/git/u-boot-sam460ex.git) registered for path 'roms/u-boot-sam460ex'
Submodule 'tests/fp/berkeley-softfloat-3' (https://github.com/cota/berkeley-softfloat-3) registered for path 'tests/fp/berkeley-softfloat-3'
Submodule 'tests/fp/berkeley-testfloat-3' (https://github.com/cota/berkeley-testfloat-3) registered for path 'tests/fp/berkeley-testfloat-3'
Submodule 'ui/keycodemapdb' (https://git.qemu.org/git/keycodemapdb.git) registered for path 'ui/keycodemapdb'
Cloning into 'capstone'...
Submodule path 'capstone': checked out '22ead3e0bfdb87516656453336160e0a37b066bf'
Cloning into 'dtc'...
Submodule path 'dtc': checked out '88f18909db731a627456f26d779445f84e449536'
Cloning into 'roms/QemuMacDrivers'...
Submodule path 'roms/QemuMacDrivers': checked out '90c488d5f4a407342247b9ea869df1c2d9c8e266'
Cloning into 'roms/SLOF'...
Submodule path 'roms/SLOF': checked out 'a5b428e1c1eae703bdd62a3f527223c291ee3fdc'
Cloning into 'roms/ipxe'...
Submodule path 'roms/ipxe': checked out 'de4565cbe76ea9f7913a01f331be3ee901bb6e17'
Cloning into 'roms/openbios'...
Submodule path 'roms/openbios': checked out '3464681b2b5983df80086a40179d324102347da3'
Cloning into 'roms/openhackware'...
Submodule path 'roms/openhackware': checked out 'c559da7c8eec5e45ef1f67978827af6f0b9546f5'
Cloning into 'roms/qemu-palcode'...
Submodule path 'roms/qemu-palcode': checked out '51c237d7e20d05100eacadee2f61abc17e6bc097'
Cloning into 'roms/seabios'...
Submodule path 'roms/seabios': checked out 'a698c8995ffb2838296ec284fe3c4ad33dfca307'
Cloning into 'roms/seabios-hppa'...
Submodule path 'roms/seabios-hppa': checked out '1ef99a01572c2581c30e16e6fe69e9ea2ef92ce0'
Cloning into 'roms/sgabios'...
Submodule path 'roms/sgabios': checked out 'cbaee52287e5f32373181cff50a00b6c4ac9015a'
Cloning into 'roms/skiboot'...
Submodule path 'roms/skiboot': checked out 'e0ee24c27a172bcf482f6f2bc905e6211c134bcc'
Cloning into 'roms/u-boot'...
Submodule path 'roms/u-boot': checked out 'd85ca029f257b53a96da6c2fb421e78a003a9943'
Cloning into 'roms/u-boot-sam460ex'...
Submodule path 'roms/u-boot-sam460ex': checked out '60b3916f33e617a815973c5a6df77055b2e3a588'
Cloning into 'tests/fp/berkeley-softfloat-3'...
Submodule path 'tests/fp/berkeley-softfloat-3': checked out 'b64af41c3276f97f0e181920400ee056b9c88037'
Cloning into 'tests/fp/berkeley-testfloat-3'...
Submodule path 'tests/fp/berkeley-testfloat-3': checked out '5a59dcec19327396a011a17fd924aed4fec416b3'
Cloning into 'ui/keycodemapdb'...
Submodule path 'ui/keycodemapdb': checked out '6b3d716e2b6472eb7189d3220552280ef3d832ce'
Switched to a new branch 'test'
93a3cf9 ui/cocoa: Perform UI operations only on the main thread
7eb1303 ui/cocoa: Subclass NSApplication so we can implement sendEvent
556e313 ui/cocoa: Don't call NSApp sendEvent directly from handleEvent
5e20ccf ui/cocoa: Move console/device menu creation code up in file
017353b ui/cocoa: Factor out initial menu creation
455ce90 ui/cocoa: Use the pixman image directly in switchSurface
02b675e ui/cocoa: Ensure we have the iothread lock when calling into QEMU

=== OUTPUT BEGIN ===
1/7 Checking commit 02b675ede0a2 (ui/cocoa: Ensure we have the iothread lock when calling into QEMU)
2/7 Checking commit 455ce903fa09 (ui/cocoa: Use the pixman image directly in switchSurface)
3/7 Checking commit 017353b840b4 (ui/cocoa: Factor out initial menu creation)
4/7 Checking commit 5e20ccf63c62 (ui/cocoa: Move console/device menu creation code up in file)
5/7 Checking commit 556e313bf5e1 (ui/cocoa: Don't call NSApp sendEvent directly from handleEvent)
ERROR: trailing whitespace
#44: FILE: ui/cocoa.m:152:
+    $

total: 1 errors, 0 warnings, 122 lines checked

Patch 5/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

6/7 Checking commit 7eb130375ad0 (ui/cocoa: Subclass NSApplication so we can implement sendEvent)
7/7 Checking commit 93a3cf9c4268 (ui/cocoa: Perform UI operations only on the main thread)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190214102816.3393-1-peter.maydell@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
no-reply@patchew.org Feb. 27, 2019, 5:41 p.m. UTC | #9 
Patchew URL: https://patchew.org/QEMU/20190214102816.3393-1-peter.maydell@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190214102816.3393-1-peter.maydell@linaro.org
Subject: [Qemu-devel] [PATCH v2 0/7] ui/cocoa: Use OSX's main loop
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/1550603704-22474-1-git-send-email-aleksandar.markovic@rt-rk.com -> patchew/1550603704-22474-1-git-send-email-aleksandar.markovic@rt-rk.com
 t [tag update]            patchew/20190214102816.3393-1-peter.maydell@linaro.org -> patchew/20190214102816.3393-1-peter.maydell@linaro.org
 t [tag update]            patchew/20190218125615.18970-1-armbru@redhat.com -> patchew/20190218125615.18970-1-armbru@redhat.com
 t [tag update]            patchew/20190218181349.23885-1-ppandit@redhat.com -> patchew/20190218181349.23885-1-ppandit@redhat.com
Switched to a new branch 'test'
58e0e41bba ui/cocoa: Perform UI operations only on the main thread
6dbdd9bfcc ui/cocoa: Subclass NSApplication so we can implement sendEvent
fba41f39fb ui/cocoa: Don't call NSApp sendEvent directly from handleEvent
84b10e148f ui/cocoa: Move console/device menu creation code up in file
920aaaacee ui/cocoa: Factor out initial menu creation
a45b2c5d67 ui/cocoa: Use the pixman image directly in switchSurface
7bf643a8be ui/cocoa: Ensure we have the iothread lock when calling into QEMU

=== OUTPUT BEGIN ===
1/7 Checking commit 7bf643a8be6d (ui/cocoa: Ensure we have the iothread lock when calling into QEMU)
2/7 Checking commit a45b2c5d67c9 (ui/cocoa: Use the pixman image directly in switchSurface)
3/7 Checking commit 920aaaacee07 (ui/cocoa: Factor out initial menu creation)
4/7 Checking commit 84b10e148f28 (ui/cocoa: Move console/device menu creation code up in file)
5/7 Checking commit fba41f39fbb3 (ui/cocoa: Don't call NSApp sendEvent directly from handleEvent)
ERROR: trailing whitespace
#44: FILE: ui/cocoa.m:152:
+    $

total: 1 errors, 0 warnings, 122 lines checked

Patch 5/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

6/7 Checking commit 6dbdd9bfcc26 (ui/cocoa: Subclass NSApplication so we can implement sendEvent)
7/7 Checking commit 58e0e41bba98 (ui/cocoa: Perform UI operations only on the main thread)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190214102816.3393-1-peter.maydell@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com