mbox series

[RFH,00/10] i386: hvf: miscellaneous cleanups

Message ID 20171003134540.21625-1-pbonzini@redhat.com
Headers show
Series i386: hvf: miscellaneous cleanups | expand

Message

Paolo Bonzini Oct. 3, 2017, 1:45 p.m. UTC 
This is an initial set of (untested!) cleanups for the HVF code.
If anyone could pick them up, I think they represent the bare minimum
that has to be done before we can commit HVF support to master.
It's by no means the end, but the existing MMU code in target/i386 could
definitely stand a rewrite, and HVF could then use it as well.

They are available at git://github.com/bonzini/qemu.git, branch hvf.

Alex (both of them), Sergio, anyone else who can help?

Paolo

Paolo Bonzini (10):
  i386: hvf: move all hvf files in the same directory
  i386: hvf: header cleanup
  i386: hvf: unify register enums between HVF and the rest
  i386: hvf: remove more dead emulator code
  i386: hvf: remove ZERO_INIT macro
  i386: hvf: abort on decoding error
  i386: hvf: simplify flag handling
  i386: hvf: remove addr_t
  i386: hvf: simplify and fix in/out handling
  i386: hvf: cleanup x86_gen.h

 target/i386/Makefile.objs                    |   2 +-
 target/i386/cpu.h                            |  62 ++++---
 target/i386/hvf-utils/panic.h                |  45 +++++
 target/i386/hvf-utils/x86_flags.h            | 243 ---------------------------
 target/i386/{hvf-utils => hvf}/Makefile.objs |   1 +
 target/i386/{hvf-utils => hvf}/README.md     |   0
 target/i386/{ => hvf}/hvf-i386.h             |   2 +-
 target/i386/{hvf-all.c => hvf/hvf.c}         |  36 ++--
 target/i386/{hvf-utils => hvf}/vmcs.h        |   0
 target/i386/{hvf-utils => hvf}/vmx.h         |  10 +-
 target/i386/{hvf-utils => hvf}/x86.c         |  23 +--
 target/i386/{hvf-utils => hvf}/x86.h         | 167 ++++++------------
 target/i386/{hvf-utils => hvf}/x86_cpuid.c   |   0
 target/i386/{hvf-utils => hvf}/x86_cpuid.h   |   0
 target/i386/{hvf-utils => hvf}/x86_decode.c  | 144 ++++++++--------
 target/i386/{hvf-utils => hvf}/x86_decode.h  |  23 ++-
 target/i386/{hvf-utils => hvf}/x86_descr.c   |  26 +--
 target/i386/{hvf-utils => hvf}/x86_descr.h   |  21 ++-
 target/i386/{hvf-utils => hvf}/x86_emu.c     | 238 ++++++++++----------------
 target/i386/{hvf-utils => hvf}/x86_emu.h     |  14 +-
 target/i386/{hvf-utils => hvf}/x86_flags.c   | 237 ++++++++++++--------------
 target/i386/hvf/x86_flags.h                  |  77 +++++++++
 target/i386/{hvf-utils => hvf}/x86_gen.h     |   4 -
 target/i386/{hvf-utils => hvf}/x86_mmu.c     |  36 ++--
 target/i386/{hvf-utils => hvf}/x86_mmu.h     |   8 +-
 target/i386/{hvf-utils => hvf}/x86_task.c    |  65 +++----
 target/i386/{hvf-utils => hvf}/x86_task.h    |   0
 target/i386/{hvf-utils => hvf}/x86hvf.c      |  32 ++--
 target/i386/{hvf-utils => hvf}/x86hvf.h      |   0
 29 files changed, 624 insertions(+), 892 deletions(-)
 create mode 100644 target/i386/hvf-utils/panic.h
 delete mode 100644 target/i386/hvf-utils/x86_flags.h
 rename target/i386/{hvf-utils => hvf}/Makefile.objs (87%)
 rename target/i386/{hvf-utils => hvf}/README.md (100%)
 rename target/i386/{ => hvf}/hvf-i386.h (97%)
 rename target/i386/{hvf-all.c => hvf/hvf.c} (97%)
 rename target/i386/{hvf-utils => hvf}/vmcs.h (100%)
 rename target/i386/{hvf-utils => hvf}/vmx.h (97%)
 rename target/i386/{hvf-utils => hvf}/x86.c (88%)
 rename target/i386/{hvf-utils => hvf}/x86.h (71%)
 rename target/i386/{hvf-utils => hvf}/x86_cpuid.c (100%)
 rename target/i386/{hvf-utils => hvf}/x86_cpuid.h (100%)
 rename target/i386/{hvf-utils => hvf}/x86_decode.c (96%)
 rename target/i386/{hvf-utils => hvf}/x86_decode.h (94%)
 rename target/i386/{hvf-utils => hvf}/x86_descr.c (82%)
 rename target/i386/{hvf-utils => hvf}/x86_descr.h (75%)
 rename target/i386/{hvf-utils => hvf}/x86_emu.c (84%)
 rename target/i386/{hvf-utils => hvf}/x86_emu.h (75%)
 rename target/i386/{hvf-utils => hvf}/x86_flags.c (57%)
 create mode 100644 target/i386/hvf/x86_flags.h
 rename target/i386/{hvf-utils => hvf}/x86_gen.h (93%)
 rename target/i386/{hvf-utils => hvf}/x86_mmu.c (85%)
 rename target/i386/{hvf-utils => hvf}/x86_mmu.h (84%)
 rename target/i386/{hvf-utils => hvf}/x86_task.c (81%)
 rename target/i386/{hvf-utils => hvf}/x86_task.h (100%)
 rename target/i386/{hvf-utils => hvf}/x86hvf.c (93%)
 rename target/i386/{hvf-utils => hvf}/x86hvf.h (100%)

Comments

Alex Bligh Oct. 3, 2017, 6:01 p.m. UTC | #1 
> On 3 Oct 2017, at 15:45, Paolo Bonzini <pbonzini@redhat.com> wrote:
> 
> Alex (both of them), Sergio, anyone else who can help?

Very interested in this (and thanks!) but it will be a while
before I have a sensible number of cycles available to play
with this one again.