diff mbox series

[v2,5/7] libpdbg: use MTMSRD opcode rather than MTMSR

Message ID 20190312014920.25368-6-npiggin@gmail.com
State Accepted
Headers show
Series sreset support for P8 systems | expand

Checks

Context Check Description
snowpatch_ozlabs/apply_patch success Successfully applied on branch master (deb577949a3505064f471e7b7c692e37c38ec8a4)
snowpatch_ozlabs/build-multiarch success Test build-multiarch on branch master

Commit Message

Nicholas Piggin March 12, 2019, 1:49 a.m. UTC 
XXX: have to ensure this still does the right thing on P9
---
 libpdbg/operations.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alistair Popple March 26, 2019, 1:24 a.m. UTC | #1 
According to the documentation this won't work as the L=0 form of MTMSRD 
requires predecode bits in SCOM RAM_CTRL to be set on P9. The L=1 form would 
work the same as it does not require any special predecode bits to be set.

- Alistair

On Tuesday, 12 March 2019 11:49:18 AM AEDT Nicholas Piggin wrote:
> XXX: have to ensure this still does the right thing on P9
> ---
>  libpdbg/operations.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libpdbg/operations.h b/libpdbg/operations.h
> index 85fc117..867f997 100644
> --- a/libpdbg/operations.h
> +++ b/libpdbg/operations.h
> @@ -59,7 +59,7 @@
>  #define MTNIA_OPCODE 0x00000002UL
>  #define MFNIA_OPCODE 0x00000004UL
>  #define MFMSR_OPCODE 0x7c0000a6UL
> -#define MTMSR_OPCODE 0x7c000124UL
> +#define MTMSR_OPCODE 0x7c000164UL
>  #define MFSPR_OPCODE 0x7c0002a6UL
>  #define MTSPR_OPCODE 0x7c0003a6UL
>  #define MFOCRF_OPCODE 0x7c100026UL
Nicholas Piggin March 26, 2019, 6:04 a.m. UTC | #2 
Alistair Popple's on March 26, 2019 11:24 am:
> According to the documentation this won't work as the L=0 form of MTMSRD 
> requires predecode bits in SCOM RAM_CTRL to be set on P9. The L=1 form would 
> work the same as it does not require any special predecode bits to be set.

Okay, we do need L=0 form though.

I'll fix and test P9.

Thanks,
Nick
diff mbox series

Patch

diff --git a/libpdbg/operations.h b/libpdbg/operations.h
index 85fc117..867f997 100644
--- a/libpdbg/operations.h
+++ b/libpdbg/operations.h
@@ -59,7 +59,7 @@ 
 #define MTNIA_OPCODE 0x00000002UL
 #define MFNIA_OPCODE 0x00000004UL
 #define MFMSR_OPCODE 0x7c0000a6UL
-#define MTMSR_OPCODE 0x7c000124UL
+#define MTMSR_OPCODE 0x7c000164UL
 #define MFSPR_OPCODE 0x7c0002a6UL
 #define MTSPR_OPCODE 0x7c0003a6UL
 #define MFOCRF_OPCODE 0x7c100026UL