diff mbox series

[RESEND,02/11] kernel/generic: remove CONFIG_FB_NOTIFY

Message ID 48032da2483548938bd9e15ca7b299485efe8142.1702174575.git.ehem+openwrt@m5p.com
State New
Headers show
Series Misc kernel config cleanup and small adjustments | expand

Commit Message

Elliott Mitchell Dec. 13, 2023, 2:16 a.m. UTC 
Date: Tue, 25 Apr 2023 16:23:20 -0700

This option is automatically enabled by CONFIG_FB=y.  There is no
reason to specifically enable it.

Signed-off-by: Elliott Mitchell <ehem+openwrt@m5p.com>
Reviewed-by: Philip Prindeville <philipp@redfish-solutions.com> 04/2023
---
 target/linux/generic/config-5.15 | 1 -
 target/linux/generic/config-6.1  | 1 -
 2 files changed, 2 deletions(-)

Comments

Jonas Gorski Dec. 12, 2023, 3:48 p.m. UTC | #1 
Hi,

On Sun, 10 Dec 2023 at 18:49, Elliott Mitchell <ehem+openwrt@m5p.com> wrote:
>
> Date: Tue, 25 Apr 2023 16:23:20 -0700
>
> This option is automatically enabled by CONFIG_FB=y.  There is no
> reason to specifically enable it.

Unfortunately this change will cause the symbol to appear in target
configs when using make kernel_*config. Ideally a make kernel_*config
without any changes should result in no changed files (currently it
does so for many targets).

To avoid that, I guess adding the symbol to
target/linux/generic/config-filter should do the trick so it becomes
properly ignored for config management.

Best Regards,
Jonas
Elliott Mitchell Dec. 13, 2023, 1:12 a.m. UTC | #2 
On Tue, Dec 12, 2023 at 04:48:32PM +0100, Jonas Gorski wrote:
> 
> On Sun, 10 Dec 2023 at 18:49, Elliott Mitchell <ehem+openwrt@m5p.com> wrote:
> >
> > Date: Tue, 25 Apr 2023 16:23:20 -0700
> >
> > This option is automatically enabled by CONFIG_FB=y.  There is no
> > reason to specifically enable it.
> 
> Unfortunately this change will cause the symbol to appear in target
> configs when using make kernel_*config. Ideally a make kernel_*config
> without any changes should result in no changed files (currently it
> does so for many targets).

I strongly dislike this approach.  Problem is forces the configuration
files to contain both values which were deliberately chosen and values
which are simply defaults (and defaults can change due to drivers
becoming mature).  Perhaps my other project could invalidate the
reasoning behind this choice.  Hmm.

> To avoid that, I guess adding the symbol to
> target/linux/generic/config-filter should do the trick so it becomes
> properly ignored for config management.

I'm okay with that.  Presently have this is in my repository.
diff mbox series

Patch

diff --git a/target/linux/generic/config-5.15 b/target/linux/generic/config-5.15
index 09628ef0da..09bd33c3d6 100644
--- a/target/linux/generic/config-5.15
+++ b/target/linux/generic/config-5.15
@@ -1984,7 +1984,6 @@  CONFIG_FAT_DEFAULT_IOCHARSET="iso8859-1"
 # CONFIG_FB_MXS is not set
 # CONFIG_FB_N411 is not set
 # CONFIG_FB_NEOMAGIC is not set
-CONFIG_FB_NOTIFY=y
 # CONFIG_FB_NVIDIA is not set
 # CONFIG_FB_OF is not set
 # CONFIG_FB_OMAP2 is not set
diff --git a/target/linux/generic/config-6.1 b/target/linux/generic/config-6.1
index 25c5eb0863..5e0362ee49 100644
--- a/target/linux/generic/config-6.1
+++ b/target/linux/generic/config-6.1
@@ -2072,7 +2072,6 @@  CONFIG_FAT_DEFAULT_IOCHARSET="iso8859-1"
 # CONFIG_FB_MXS is not set
 # CONFIG_FB_N411 is not set
 # CONFIG_FB_NEOMAGIC is not set
-CONFIG_FB_NOTIFY=y
 # CONFIG_FB_NVIDIA is not set
 # CONFIG_FB_OF is not set
 # CONFIG_FB_OMAP2 is not set