diff mbox series

[v2,2/2] firmware-utils: tplink-safeloader: set EAP235-Wall v1 soft-version

Message ID 2222a4efbc86150448232058af97282a54115e76.1631264098.git.sander@svanheule.net
State Accepted
Delegated to: Hauke Mehrtens
Headers show
Series Safeloader firmware images contain a soft-version partition, which encodes version info about the image. There are currently two formats: plain text and structured binary with the firmware version number and build info. | expand

Commit Message

Sander Vanheule Sept. 10, 2021, 8:57 a.m. UTC
Starting with v3 of the vendor firmware for the TP-Link EAP235-Wall v1,
downgrades to firmware versions below v3 as not allowed.  Since OpenWrt
uses version 0.0.0 as a default, this causes the factory install to fail
on devices with a recent firmware. This failure is associated by the
following message on the device's serial console:

    EAP235/230-Wall forbid fw reverted from 3.x.x to lower version!

Vendor firmware (v3) also uses build and release numbers to compare
images, so identical version numbers are very unlikely to cause issues.
Bump the firmware version to 3.0.0 to ensure users can install OpenWrt
on their devices.

Reported-by: Colton Conor <colton.conor@gmail.com>
Tested-by: Colton Conor <colton.conor@gmail.com>
Signed-off-by: Sander Vanheule <sander@svanheule.net>
---
v2: Add Colton Conor's tags

 tools/firmware-utils/src/tplink-safeloader.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/tools/firmware-utils/src/tplink-safeloader.c b/tools/firmware-utils/src/tplink-safeloader.c
index 923cd865f64c..04a77fa079c9 100644
--- a/tools/firmware-utils/src/tplink-safeloader.c
+++ b/tools/firmware-utils/src/tplink-safeloader.c
@@ -1560,7 +1560,7 @@  static struct device_info boards[] = {
 			"SupportList:\r\n"
 			"EAP235-Wall(TP-Link|UN|AC1200-D):1.0\r\n",
 		.part_trail = PART_TRAIL_NONE,
-		.soft_ver = SOFT_VER_DEFAULT,
+		.soft_ver = SOFT_VER_NUMERIC(3, 0, 0),
 		.soft_ver_compat_level = 1,
 
 		.partitions = {