diff mbox series

[firmware-utils,2/4] uimage_sgehdr: use "char" type for header struct strings

Message ID 20240223061839.21956-2-zajec5@gmail.com
State Accepted
Delegated to: Rafał Miłecki
Headers show
Series [firmware-utils,1/4] srec2bin: drop unused "dum" variable | expand

Commit Message

Rafał Miłecki Feb. 23, 2024, 6:18 a.m. UTC 
From: Rafał Miłecki <rafal@milecki.pl>

This fixes:

src/uimage_sgehdr.c: In function ‘main’:
src/uimage_sgehdr.c:152:10: warning: pointer targets in passing argument 1 of ‘strncpy’ differ in signedness [-Wpointer-sign]
  strncpy(imgh->sgeih_p, model, sizeof(imgh->sgeih_p));
          ^~~~
src/uimage_sgehdr.c:153:10: warning: pointer targets in passing argument 1 of ‘strncpy’ differ in signedness [-Wpointer-sign]
  strncpy(imgh->sgeih_sv, sversion, sizeof(imgh->sgeih_sv));
          ^~~~
src/uimage_sgehdr.c:154:10: warning: pointer targets in passing argument 1 of ‘strncpy’ differ in signedness [-Wpointer-sign]
  strncpy(imgh->sgeih_hv, hversion, sizeof(imgh->sgeih_hv));
          ^~~~

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
 src/uimage_sgehdr.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff mbox series

Patch

diff --git a/src/uimage_sgehdr.c b/src/uimage_sgehdr.c
index 28143a8..6d62c04 100644
--- a/src/uimage_sgehdr.c
+++ b/src/uimage_sgehdr.c
@@ -40,9 +40,9 @@  struct image_header {
 	uint8_t		ih_type;	/* Image Type			*/
 	uint8_t		ih_comp;	/* Compression Type		*/
 	uint8_t		ih_name[IH_NMLEN];	/* Image Name		*/
-	uint8_t		sgeih_p[SGE_PRODUCTLEN];	/* sge_Product		*/
-	uint8_t		sgeih_sv[SGE_VERSIONLEN];	/* sge Software Version		*/
-	uint8_t		sgeih_hv[SGE_VERSIONLEN];	/* sge Hardware Version		*/
+	char		sgeih_p[SGE_PRODUCTLEN];	/* sge_Product		*/
+	char		sgeih_sv[SGE_VERSIONLEN];	/* sge Software Version		*/
+	char		sgeih_hv[SGE_VERSIONLEN];	/* sge Hardware Version		*/
 };