| Message ID | 20220616202826.267637-1-foss@volatilesystems.org |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | realtek: make Netgear GS108T v3 u-boot env partition writable | expand |
Hi Stijn, On Thu, 2022-06-16 at 22:28 +0200, Stijn Segers wrote: > Signed-off-by: Stijn Segers <foss@volatilesystems.org> You need to add at least one line describing why this change is needed; now you only have a commit title. Just mentioning that you want to be able to modify the u-boot-env from userspace should be enough. Best, Sander > --- > target/linux/realtek/dts-5.10/rtl8380_netgear_gigabit_1xx.dtsi | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/target/linux/realtek/dts-5.10/rtl8380_netgear_gigabit_1xx.dtsi > b/target/linux/realtek/dts-5.10/rtl8380_netgear_gigabit_1xx.dtsi > index 7eccfcb5a2..fd44543bb4 100644 > --- a/target/linux/realtek/dts-5.10/rtl8380_netgear_gigabit_1xx.dtsi > +++ b/target/linux/realtek/dts-5.10/rtl8380_netgear_gigabit_1xx.dtsi > @@ -24,7 +24,6 @@ > partition@e0000 { > label = "u-boot-env"; > reg = <0x00e0000 0x0010000>; > - read-only; > }; > > partition@f0000 {
Sander Vanheule <sander@svanheule.net> writes: > On Thu, 2022-06-16 at 22:28 +0200, Stijn Segers wrote: >> Signed-off-by: Stijn Segers <foss@volatilesystems.org> > > You need to add at least one line describing why this change is needed; now you > only have a commit title. Just mentioning that you want to be able to modify the > u-boot-env from userspace should be enough. Could even use the real usecase example from the forum as body. Then we have that documented here as well. Bjørn
Hi, Op vrijdag 17 juni 2022 om 09:54:56 +02:00:00 schreef Bjørn Mork <bjorn@mork.no>: > Sander Vanheule <sander@svanheule.net> writes: >> On Thu, 2022-06-16 at 22:28 +0200, Stijn Segers wrote: >>> Signed-off-by: Stijn Segers <foss@volatilesystems.org> >> >> You need to add at least one line describing why this change is >> needed; now you >> only have a commit title. Just mentioning that you want to be able >> to modify the >> u-boot-env from userspace should be enough. > > Could even use the real usecase example from the forum as body. Then > we > have that documented here as well. > > > Bjørn Thank you both, clearly my gitiquette is not up to snuff :^). Sent in a v2, also changed the title since it applies to a shared DTSI. Cheers Stijn
diff --git a/target/linux/realtek/dts-5.10/rtl8380_netgear_gigabit_1xx.dtsi b/target/linux/realtek/dts-5.10/rtl8380_netgear_gigabit_1xx.dtsi index 7eccfcb5a2..fd44543bb4 100644 --- a/target/linux/realtek/dts-5.10/rtl8380_netgear_gigabit_1xx.dtsi +++ b/target/linux/realtek/dts-5.10/rtl8380_netgear_gigabit_1xx.dtsi @@ -24,7 +24,6 @@ partition@e0000 { label = "u-boot-env"; reg = <0x00e0000 0x0010000>; - read-only; }; partition@f0000 {
Signed-off-by: Stijn Segers <foss@volatilesystems.org> --- target/linux/realtek/dts-5.10/rtl8380_netgear_gigabit_1xx.dtsi | 1 - 1 file changed, 1 deletion(-)