| Message ID | 20211214112441.18485-1-ynezz@true.cz |
|---|---|
| State | Superseded |
| Delegated to: | Petr Štetiar |
| Headers | show |
| Series | toolchain: musl: disable crypt size hack on !SMALL_FLASH devices | expand |
Hi, while the decision to do that seems obvious on first sight, I think that supporting different password hashing algorithms on different targets might lead to unexpected surprises for downstream users. E.g. when precalculated password hashes taken from one device are built inside custom firmware images for another small flash device and suddenly the login is not working anymore. I'd rather reenable all hash types for all targets, even small flash ones to maintain consistency. ~ Jo
diff --git a/toolchain/musl/Config.in b/toolchain/musl/Config.in index 7e83b6fa535d..f38791598a98 100644 --- a/toolchain/musl/Config.in +++ b/toolchain/musl/Config.in @@ -3,7 +3,7 @@ config MUSL_DISABLE_CRYPT_SIZE_HACK bool "Include crypt() support for SHA256, SHA512 and Blowfish ciphers" depends on TOOLCHAINOPTS && USE_MUSL && !EXTERNAL_TOOLCHAIN - default n + default y if !SMALL_FLASH help Enable this option to re-include crypt() support for the SHA256, SHA512 and Blowfish ciphers. Without this option, attempting to hash a string with a salt
Enable this option and re-include crypt() support for the SHA256, SHA512 and Blowfish ciphers on devices which have enough flash space. According to commit 9365745f8e7b ("musl: add a hack to remove unused crypt() algorithms, saves ~14k after lzma") it should add about ~14k to the resulting image. References: https://github.com/openwrt/openwrt/pull/1331 Signed-off-by: Petr Štetiar <ynezz@true.cz> --- toolchain/musl/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)