| Message ID | 20181219112312.8707-2-hauke@hauke-m.de |
|---|---|
| State | Accepted |
| Delegated to: | Hauke Mehrtens |
| Headers | show |
| Series | [OpenWrt-Devel,firewall3,1/2] options.c, redirects.c: Fix possible buffer overflows | expand |
Hi, > Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> Acked-by: Jo-Philipp Wich <jo@mein.io> ~ Jo
diff --git a/utils.c b/utils.c index 4f892a7..684b2c3 100644 --- a/utils.c +++ b/utils.c @@ -252,6 +252,7 @@ __fw3_command_pipe(bool silent, const char *command, ...) switch ((pid = fork())) { case -1: + free(args); return false; case 0: @@ -275,6 +276,7 @@ __fw3_command_pipe(bool silent, const char *command, ...) } pipe_fd = fdopen(pfds[1], "w"); + free(args); return true; }
args was not freed after leaving this function. Fixes Coverity issue 1412470 Resource leak Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> --- utils.c | 2 ++ 1 file changed, 2 insertions(+)