| Message ID | 20180627211433.26619-1-jwh@corp.connectbit.io |
|---|---|
| State | Superseded |
| Delegated to: | John Crispin |
| Headers | show |
| Series | [OpenWrt-Devel,v2,1/2,netifd] system-linux: add 2.5 and 10G interface speed definitions | expand |
On 27/06/2018 23:14, jwh@corp.connectbit.io wrote: > From: Joe Holden <jwh@zorins.co.uk> > > Signed-off-by: Joe Holden <jwh@zorins.co.uk> > --- > system-linux.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/system-linux.c b/system-linux.c > index 0127b01..1330ea1 100644 > --- a/system-linux.c > +++ b/system-linux.c > @@ -1688,6 +1688,8 @@ static const struct { > { ADVERTISED_100baseT_Full, "100F" }, > { ADVERTISED_1000baseT_Half, "1000H" }, > { ADVERTISED_1000baseT_Full, "1000F" }, > + { ADVERTISED_2500baseX_Full, "2500F" }, > + { ADVERTISED_10000baseT_Full, "10000F" }, > }; > > static void system_add_link_modes(struct blob_buf *b, __u32 mask) > Is there a reason you didn't include the 5GbE too? Afaik most consumer cards can do that too, and it is faster than 2.5. There are some cards that do only up to 5GbE. https://www.anandtech.com/show/11368/aquantia-launch-aqtion-5g25g1g-nics (and note that I can find these cards on sale currently, also the 5GbE one) -Alberto
On 28/06/2018 00:01, Alberto Bursi wrote: > > > On 27/06/2018 23:14, jwh@corp.connectbit.io wrote: >> From: Joe Holden <jwh@zorins.co.uk> >> >> Signed-off-by: Joe Holden <jwh@zorins.co.uk> >> --- >> system-linux.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/system-linux.c b/system-linux.c >> index 0127b01..1330ea1 100644 >> --- a/system-linux.c >> +++ b/system-linux.c >> @@ -1688,6 +1688,8 @@ static const struct { >> { ADVERTISED_100baseT_Full, "100F" }, >> { ADVERTISED_1000baseT_Half, "1000H" }, >> { ADVERTISED_1000baseT_Full, "1000F" }, >> + { ADVERTISED_2500baseX_Full, "2500F" }, >> + { ADVERTISED_10000baseT_Full, "10000F" }, >> }; >> >> static void system_add_link_modes(struct blob_buf *b, __u32 mask) >> > > Is there a reason you didn't include the 5GbE too? > Afaik most consumer cards can do that too, and it is faster than 2.5. > There are some cards that do only up to 5GbE. > https://www.anandtech.com/show/11368/aquantia-launch-aqtion-5g25g1g-nics > > (and note that I can find these cards on sale currently, also the 5GbE one) > > -Alberto > After a cursory look over supported hardware, I didn't see any off the shelf 5G devices (haven't seen 5G in the wild yet either) - no actual reason for not including it I guess
diff --git a/system-linux.c b/system-linux.c index 0127b01..1330ea1 100644 --- a/system-linux.c +++ b/system-linux.c @@ -1688,6 +1688,8 @@ static const struct { { ADVERTISED_100baseT_Full, "100F" }, { ADVERTISED_1000baseT_Half, "1000H" }, { ADVERTISED_1000baseT_Full, "1000F" }, + { ADVERTISED_2500baseX_Full, "2500F" }, + { ADVERTISED_10000baseT_Full, "10000F" }, }; static void system_add_link_modes(struct blob_buf *b, __u32 mask)