| Message ID | 20180530063543.30901-1-rosenp@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [OpenWrt-Devel,1/2] ramips: mt7621: fix pcie related warnings in mt7621.dtsi | expand |
On Tue, May 29, 2018 at 11:35 PM, Rosen Penev <rosenp@gmail.com> wrote: > List of warnings: > > Node /pcie@1e140000/pcie0 node name is not "pci" or "pcie" > Node /pcie@1e140000/pcie0 missing ranges for PCI bridge (or not a bridge) > Node /pcie@1e140000/pcie0 missing bus-range for PCI bridge > Node /pcie@1e140000/pcie1 node name is not "pci" or "pcie" > Node /pcie@1e140000/pcie1 missing ranges for PCI bridge (or not a bridge) > Node /pcie@1e140000/pcie1 missing bus-range for PCI bridge > Node /pcie@1e140000/pcie2 node name is not "pci" or "pcie" > Node /pcie@1e140000/pcie2 missing ranges for PCI bridge (or not a bridge) > Node /pcie@1e140000/pcie2 missing bus-range for PCI bridge > Warning (unit_address_format): Failed prerequisite 'pci_bridge' > Warning (pci_device_reg): Failed prerequisite 'pci_bridge' > Warning (pci_device_bus_num): Failed prerequisite 'pci_bridge' > > Tested on GnuBee PC2 device. All pcie lanes still work. On further investigation, this errors with: bridge configuration invalid ([bus 00-00]), reconfiguring Will respin. > > Signed-off-by: Rosen Penev <rosenp@gmail.com> > --- > target/linux/ramips/dts/mt7621.dtsi | 12 +++--------- > 1 file changed, 3 insertions(+), 9 deletions(-) > > diff --git a/target/linux/ramips/dts/mt7621.dtsi b/target/linux/ramips/dts/mt7621.dtsi > index 87399a113e..39b1ca4425 100644 > --- a/target/linux/ramips/dts/mt7621.dtsi > +++ b/target/linux/ramips/dts/mt7621.dtsi > @@ -453,31 +453,25 @@ > clocks = <&clkctrl 24 &clkctrl 25 &clkctrl 26>; > clock-names = "pcie0", "pcie1", "pcie2"; > > - pcie0 { > + pcie0: pcie@0,0 { > reg = <0x0000 0 0 0 0>; > > #address-cells = <3>; > #size-cells = <2>; > - > - device_type = "pci"; > }; > > - pcie1 { > + pcie1: pcie@1,0 { > reg = <0x0800 0 0 0 0>; > > #address-cells = <3>; > #size-cells = <2>; > - > - device_type = "pci"; > }; > > - pcie2 { > + pcie2: pcie@2,0 { > reg = <0x1000 0 0 0 0>; > > #address-cells = <3>; > #size-cells = <2>; > - > - device_type = "pci"; > }; > }; > }; > -- > 2.17.0 >
diff --git a/target/linux/ramips/dts/mt7621.dtsi b/target/linux/ramips/dts/mt7621.dtsi index 87399a113e..39b1ca4425 100644 --- a/target/linux/ramips/dts/mt7621.dtsi +++ b/target/linux/ramips/dts/mt7621.dtsi @@ -453,31 +453,25 @@ clocks = <&clkctrl 24 &clkctrl 25 &clkctrl 26>; clock-names = "pcie0", "pcie1", "pcie2"; - pcie0 { + pcie0: pcie@0,0 { reg = <0x0000 0 0 0 0>; #address-cells = <3>; #size-cells = <2>; - - device_type = "pci"; }; - pcie1 { + pcie1: pcie@1,0 { reg = <0x0800 0 0 0 0>; #address-cells = <3>; #size-cells = <2>; - - device_type = "pci"; }; - pcie2 { + pcie2: pcie@2,0 { reg = <0x1000 0 0 0 0>; #address-cells = <3>; #size-cells = <2>; - - device_type = "pci"; }; }; };
List of warnings: Node /pcie@1e140000/pcie0 node name is not "pci" or "pcie" Node /pcie@1e140000/pcie0 missing ranges for PCI bridge (or not a bridge) Node /pcie@1e140000/pcie0 missing bus-range for PCI bridge Node /pcie@1e140000/pcie1 node name is not "pci" or "pcie" Node /pcie@1e140000/pcie1 missing ranges for PCI bridge (or not a bridge) Node /pcie@1e140000/pcie1 missing bus-range for PCI bridge Node /pcie@1e140000/pcie2 node name is not "pci" or "pcie" Node /pcie@1e140000/pcie2 missing ranges for PCI bridge (or not a bridge) Node /pcie@1e140000/pcie2 missing bus-range for PCI bridge Warning (unit_address_format): Failed prerequisite 'pci_bridge' Warning (pci_device_reg): Failed prerequisite 'pci_bridge' Warning (pci_device_bus_num): Failed prerequisite 'pci_bridge' Tested on GnuBee PC2 device. All pcie lanes still work. Signed-off-by: Rosen Penev <rosenp@gmail.com> --- target/linux/ramips/dts/mt7621.dtsi | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-)