| Message ID | 20180527162140.3085-1-rosenp@gmail.com |
|---|---|
| State | Accepted |
| Delegated to: | John Crispin |
| Headers | show |
| Series | [OpenWrt-Devel] ath10k-firmware: Fix typo in last commit | expand |
2018-05-27 19:21 GMT+03:00 Rosen Penev <rosenp@gmail.com>: > Signed-off-by: Rosen Penev <rosenp@gmail.com> > --- > package/firmware/ath10k-firmware/Makefile | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/package/firmware/ath10k-firmware/Makefile b/package/firmware/ath10k-firmware/Makefile > index 2c024905bb..35f6013947 100644 > --- a/package/firmware/ath10k-firmware/Makefile > +++ b/package/firmware/ath10k-firmware/Makefile > @@ -452,8 +452,6 @@ define Package/ath10k-firmware-qca6174/install > $(INSTALL_DATA) Shouldn't it be "$(INSTALL_DATA) \", similar to all the other install defines? Mathias
Mathias Kresin wrote on Mon May 28 09:44:34 PDT 2018:
> Shouldn't it be "$(INSTALL_DATA) \", similar to all the other install defines?
Yep. And there are two of those. On lines 445 and 452.
(the "typo fix" just removed the third one, the extra one)
On Tue, May 29, 2018 at 9:25 AM, Hannu Nyman <hannu.nyman@iki.fi> wrote: > Mathias Kresin wrote on Mon May 28 09:44:34 PDT 2018: >> >> Shouldn't it be "$(INSTALL_DATA) \", similar to all the other install >> defines? > > > Yep. And there are two of those. On lines 445 and 452. > I fixed this locally but forgot to send patch. Will do so soon. > (the "typo fix" just removed the third one, the extra one) >
diff --git a/package/firmware/ath10k-firmware/Makefile b/package/firmware/ath10k-firmware/Makefile index 2c024905bb..35f6013947 100644 --- a/package/firmware/ath10k-firmware/Makefile +++ b/package/firmware/ath10k-firmware/Makefile @@ -452,8 +452,6 @@ define Package/ath10k-firmware-qca6174/install $(INSTALL_DATA) $(PKG_BUILD_DIR)/QCA6174/hw3.0/4.4.1.c1/firmware-6.bin_RM.4.4.1.c1-00042-QCARMSWP-1 \ $(1)/lib/firmware/ath10k/QCA6174/hw3.0/firmware-6.bin - $(INSTALL_DATA) - endef define Package/ath10k-firmware-qca99x0/install
Signed-off-by: Rosen Penev <rosenp@gmail.com> --- package/firmware/ath10k-firmware/Makefile | 2 -- 1 file changed, 2 deletions(-)