| Message ID | 1583168546-1821-1-git-send-email-tharvey@gateworks.com |
|---|---|
| State | Superseded |
| Delegated to: | Petr Štetiar |
| Headers | show |
| Series | [OpenWrt-Devel] imx6: remove unnecessary wildcard from board name mathching | expand |
> -----Original Message----- > From: openwrt-devel [mailto:openwrt-devel-bounces@lists.openwrt.org] > On Behalf Of Tim Harvey > Sent: Montag, 2. März 2020 18:02 > To: Petr Štetiar <ynezz@true.cz>; Adrian Schmutzler > <mail@adrianschmutzler.de>; openwrt-devel@lists.openwrt.org > Cc: Tim Harvey <tharvey@gateworks.com> > Subject: [OpenWrt-Devel] [PATCH] imx6: remove unnecessary wildcard from > board name mathching > > The wildcard used in the network config matching is not necessary given the > board names returned by imx6_board_detect() in lib/imx6.sh. Thanks. You have a typo in the title: mathching->matching My "review" on this was just a drive-by comment, I cannot review much else of your initial patch, but IIRC ynezz already had a look as well... Best Adrian
diff --git a/target/linux/imx6/base-files/etc/board.d/02_network b/target/linux/imx6/base-files/etc/board.d/02_network index 13a140a..bc05313 100755 --- a/target/linux/imx6/base-files/etc/board.d/02_network +++ b/target/linux/imx6/base-files/etc/board.d/02_network @@ -11,21 +11,21 @@ board_config_update case "$board" in cubox-i |\ -*gw51xx |\ -*gw52xx |\ -*gw5904 |\ -*gw5907 |\ -*gw5910 |\ -*gw5912 |\ -*gw5913) +gw51xx |\ +gw52xx |\ +gw5904 |\ +gw5907 |\ +gw5910 |\ +gw5912 |\ +gw5913) ucidef_set_interface_lan 'eth0' ;; -*gw53xx |\ -*gw54xx |\ -*gw552x) +gw53xx |\ +gw54xx |\ +gw552x) ucidef_set_interfaces_lan_wan 'eth0' 'eth1' ;; -*wandboard) +wandboard) ucidef_set_interface_wan 'eth0' ;; esac
The wildcard used in the network config matching is not necessary given the board names returned by imx6_board_detect() in lib/imx6.sh. Signed-off-by: Tim Harvey <tharvey@gateworks.com> --- .../linux/imx6/base-files/etc/board.d/02_network | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-)