| Message ID | 1545141554-27476-1-git-send-email-ynezz@true.cz |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [OpenWrt-Devel] gpio-nct5104d: Chill out unsupported device log spamming | expand |
I'm seeing this message as well on QEMU on an APU2c4 and agree that toning it down would probably be reasonable. # dmesg | grep -c 'gpio-nct5104d: Unsupported device 0xffff' 216 Best regards Martin On 12/18/18 2:59 PM, Petr Štetiar wrote: > I'm doing some quick run time tests in QEMU, where I'm always greeted > with a bunch of quite useless error messages, so it would be nice if we > could relax them little bit and developers could always enable them if > needed anyway. > > $ dmesg | grep -c 'gpio-nct5104d: Unsupported device 0xffff' > 246 > > Signed-off-by: Petr Štetiar <ynezz@true.cz> > --- > package/kernel/gpio-nct5104d/src/gpio-nct5104d.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/package/kernel/gpio-nct5104d/src/gpio-nct5104d.c b/package/kernel/gpio-nct5104d/src/gpio-nct5104d.c > index 8da7580..e29d22f 100644 > --- a/package/kernel/gpio-nct5104d/src/gpio-nct5104d.c > +++ b/package/kernel/gpio-nct5104d/src/gpio-nct5104d.c > @@ -361,7 +361,7 @@ static int __init nct5104d_find(int addr, struct nct5104d_sio *sio) > superio_outb(addr, SIO_GPIO_ENABLE, gpio_cfg); > break; > default: > - pr_info(DRVNAME ": Unsupported device 0x%04x\n", devid); > + pr_debug(DRVNAME ": Unsupported device 0x%04x\n", devid); > goto err; > } > sio->addr = addr; >
diff --git a/package/kernel/gpio-nct5104d/src/gpio-nct5104d.c b/package/kernel/gpio-nct5104d/src/gpio-nct5104d.c index 8da7580..e29d22f 100644 --- a/package/kernel/gpio-nct5104d/src/gpio-nct5104d.c +++ b/package/kernel/gpio-nct5104d/src/gpio-nct5104d.c @@ -361,7 +361,7 @@ static int __init nct5104d_find(int addr, struct nct5104d_sio *sio) superio_outb(addr, SIO_GPIO_ENABLE, gpio_cfg); break; default: - pr_info(DRVNAME ": Unsupported device 0x%04x\n", devid); + pr_debug(DRVNAME ": Unsupported device 0x%04x\n", devid); goto err; } sio->addr = addr;
I'm doing some quick run time tests in QEMU, where I'm always greeted with a bunch of quite useless error messages, so it would be nice if we could relax them little bit and developers could always enable them if needed anyway. $ dmesg | grep -c 'gpio-nct5104d: Unsupported device 0xffff' 246 Signed-off-by: Petr Štetiar <ynezz@true.cz> --- package/kernel/gpio-nct5104d/src/gpio-nct5104d.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)