| Message ID | 1464101288-7056-1-git-send-email-marex@denx.de |
|---|---|
| State | Changes Requested |
| Headers | show |
On 2016-05-24 16:48, Marek Vasut wrote: > The patch adding SPI flash mmap read capability does not compile due to missing > m25p80_rx_nbits() function. Move it to bcm53xx patch directory, where the patch > adding this m25p80_rx_nbits() function resides. This doesn't make any sense to me. The function is already in the driver in 4.4, it is not added by any patch... - Felix
On 05/24/2016 04:57 PM, Felix Fietkau wrote: > On 2016-05-24 16:48, Marek Vasut wrote: >> The patch adding SPI flash mmap read capability does not compile due to missing >> m25p80_rx_nbits() function. Move it to bcm53xx patch directory, where the patch >> adding this m25p80_rx_nbits() function resides. > This doesn't make any sense to me. The function is already in the driver > in 4.4, it is not added by any patch... > > - Felix > Well is there any way to obtain kernel tree with the target/linux/generic/patches-4.4 applied, so I can base socfpga patches on top of it ? I tried git am on those patches, but that's obviously not possible, since a lot of these patches were not generated with git-format-patch or the relevant header was removed. Thanks
On 05/24/2016 04:57 PM, Felix Fietkau wrote: > On 2016-05-24 16:48, Marek Vasut wrote: >> The patch adding SPI flash mmap read capability does not compile due to missing >> m25p80_rx_nbits() function. Move it to bcm53xx patch directory, where the patch >> adding this m25p80_rx_nbits() function resides. > This doesn't make any sense to me. The function is already in the driver > in 4.4, it is not added by any patch... OK, please drop this one and I will send a V2 of this too: [PATCH] target: socfpga: Add support for QSPI NOR boot
Marek Vasut - 17:12 24.05.16 wrote: > On 05/24/2016 04:57 PM, Felix Fietkau wrote: > > On 2016-05-24 16:48, Marek Vasut wrote: > >> The patch adding SPI flash mmap read capability does not compile due to missing > >> m25p80_rx_nbits() function. Move it to bcm53xx patch directory, where the patch > >> adding this m25p80_rx_nbits() function resides. > > This doesn't make any sense to me. The function is already in the driver > > in 4.4, it is not added by any patch... > > > > - Felix > > > Well is there any way to obtain kernel tree with the > target/linux/generic/patches-4.4 applied, so I can base socfpga patches > on top > of it ? > > I tried git am on those patches, but that's obviously not possible, > since a lot of these patches were not generated with git-format-patch > or the relevant header was removed. Quilt work fine: https://wiki.openwrt.org/doc/devel/patches#adding_or_editing_kernel_patches
diff --git a/target/linux/generic/patches-4.4/045-mtd-devices-m25p80-add-support-for-mmap-read-request.patch b/target/linux/bcm53xx/patches-4.4/045-mtd-devices-m25p80-add-support-for-mmap-read-request.patch
similarity index 100%
rename from target/linux/generic/patches-4.4/045-mtd-devices-m25p80-add-support-for-mmap-read-request.patch
rename to target/linux/bcm53xx/patches-4.4/045-mtd-devices-m25p80-add-support-for-mmap-read-request.patch
The patch adding SPI flash mmap read capability does not compile due to missing m25p80_rx_nbits() function. Move it to bcm53xx patch directory, where the patch adding this m25p80_rx_nbits() function resides. Signed-off-by: Marek Vasut <marex@denx.de> --- .../045-mtd-devices-m25p80-add-support-for-mmap-read-request.patch | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename target/linux/{generic => bcm53xx}/patches-4.4/045-mtd-devices-m25p80-add-support-for-mmap-read-request.patch (100%)