| Message ID | 1446310848-15567-1-git-send-email-martin.blumenstingl@googlemail.com |
|---|---|
| State | Accepted |
| Headers | show |
Hi, On 31/10/2015 18:00, Martin Blumenstingl wrote: > This fixes #20409 > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > --- > .../0043-MIPS-add-board-support-for-Arcadyan-VGV7510KW22.patch | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/package/boot/uboot-lantiq/patches/0043-MIPS-add-board-support-for-Arcadyan-VGV7510KW22.patch b/package/boot/uboot-lantiq/patches/0043-MIPS-add-board-support-for-Arcadyan-VGV7510KW22.patch > index a491032..adb894f 100644 > --- a/package/boot/uboot-lantiq/patches/0043-MIPS-add-board-support-for-Arcadyan-VGV7510KW22.patch > +++ b/package/boot/uboot-lantiq/patches/0043-MIPS-add-board-support-for-Arcadyan-VGV7510KW22.patch > @@ -30,7 +30,7 @@ > +######################################################################### > --- /dev/null > +++ b/board/arcadyan/vgv7510kw22/vgv7510kw22.c > -@@ -0,0 +1,133 @@ > +@@ -0,0 +1,136 @@ > +/* > + * Copyright (C) 2015 Martin Blumenstingl <martin.blumenstingl@googlemail.com> > + * > @@ -122,7 +122,10 @@ > + const enum ltq_gphy_clk clk = LTQ_GPHY_CLK_25MHZ_PLL0; > + const ulong fw_addr = 0x80FF0000; > + > -+ ltq_gphy_phy22f_a1x_load(fw_addr); > ++ if (ltq_chip_version_get() == 1) > ++ ltq_gphy_phy22f_a1x_load(fw_addr); > ++ else > ++ ltq_gphy_phy22f_a2x_load(fw_addr); I'll merge this as is, however i am starting to wonder if we should not just autodetect the right fw to use and only pass 11G/22F as an option John > + > + ltq_cgu_gphy_clk_src(clk); > + >
On Sun, Nov 1, 2015 at 9:01 AM, John Crispin <blogic@openwrt.org> wrote: > I'll merge this as is, however i am starting to wonder if we should not > just autodetect the right fw to use and only pass 11G/22F as an option I am *guessing* that it's due to binary size reasons (including all GPHY firmwares in the u-boot binary would make it quite a bit bigger). However, it's probably best to ask Daniel (I've put him on CC) what his opinion is (someone for example suggested to LZMA compress the GPHY firmware images to save space). Regards, Martin
diff --git a/package/boot/uboot-lantiq/patches/0043-MIPS-add-board-support-for-Arcadyan-VGV7510KW22.patch b/package/boot/uboot-lantiq/patches/0043-MIPS-add-board-support-for-Arcadyan-VGV7510KW22.patch index a491032..adb894f 100644 --- a/package/boot/uboot-lantiq/patches/0043-MIPS-add-board-support-for-Arcadyan-VGV7510KW22.patch +++ b/package/boot/uboot-lantiq/patches/0043-MIPS-add-board-support-for-Arcadyan-VGV7510KW22.patch @@ -30,7 +30,7 @@ +######################################################################### --- /dev/null +++ b/board/arcadyan/vgv7510kw22/vgv7510kw22.c -@@ -0,0 +1,133 @@ +@@ -0,0 +1,136 @@ +/* + * Copyright (C) 2015 Martin Blumenstingl <martin.blumenstingl@googlemail.com> + * @@ -122,7 +122,10 @@ + const enum ltq_gphy_clk clk = LTQ_GPHY_CLK_25MHZ_PLL0; + const ulong fw_addr = 0x80FF0000; + -+ ltq_gphy_phy22f_a1x_load(fw_addr); ++ if (ltq_chip_version_get() == 1) ++ ltq_gphy_phy22f_a1x_load(fw_addr); ++ else ++ ltq_gphy_phy22f_a2x_load(fw_addr); + + ltq_cgu_gphy_clk_src(clk); +
This fixes #20409 Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> --- .../0043-MIPS-add-board-support-for-Arcadyan-VGV7510KW22.patch | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)