diff mbox

[OpenWrt-Devel] ipq806x: add platform_pre_upgrade for sysupgrade

Message ID 1442319522-11585-1-git-send-email-zajec5@gmail.com
State Accepted
Headers show

Commit Message

Rafał Miłecki Sept. 15, 2015, 12:18 p.m. UTC
We're in process of cleaning nand_do_platform_check. Currently is leaves
a special mark in /tmp/sysupgrade-nand-path triggering some diffent code
path in nand_upgrade_stage1. This can be a bit confusing.

The plan is to have the check function only check the image and nothing
else. Then platform code (platform_pre_upgrade) should trigger NAND
specific upgrade path. This is what this patch implements.

This follows ar71xx, lantiq and partially bcm53xx.

Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
---
I'd like to push it in a month if I won't get any reply.
---
 target/linux/ipq806x/base-files/lib/upgrade/platform.sh | 11 +++++++++++
 1 file changed, 11 insertions(+)

Comments

John Crispin Sept. 15, 2015, 12:25 p.m. UTC | #1
On 15/09/2015 14:18, Rafał Miłecki wrote:
> We're in process of cleaning nand_do_platform_check. Currently is leaves
> a special mark in /tmp/sysupgrade-nand-path triggering some diffent code
> path in nand_upgrade_stage1. This can be a bit confusing.
> 
> The plan is to have the check function only check the image and nothing
> else. Then platform code (platform_pre_upgrade) should trigger NAND
> specific upgrade path. This is what this patch implements.
> 
> This follows ar71xx, lantiq and partially bcm53xx.
> 
> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>

Ack, looks good

> ---
> I'd like to push it in a month if I won't get any reply.
> ---
>  target/linux/ipq806x/base-files/lib/upgrade/platform.sh | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/target/linux/ipq806x/base-files/lib/upgrade/platform.sh b/target/linux/ipq806x/base-files/lib/upgrade/platform.sh
> index 75a01b7..c0e19a1 100644
> --- a/target/linux/ipq806x/base-files/lib/upgrade/platform.sh
> +++ b/target/linux/ipq806x/base-files/lib/upgrade/platform.sh
> @@ -16,4 +16,15 @@ platform_check_image() {
>  	esac
>  }
>  
> +platform_pre_upgrade() {
> +	local board=$(ipq806x_board_name)
> +
> +	case "$board" in
> +	AP148 |\
> +	r7500)
> +		nand_do_upgrade "$1"
> +		;;
> +	esac
> +}
> +
>  # use default for platform_do_upgrade()
>
diff mbox

Patch

diff --git a/target/linux/ipq806x/base-files/lib/upgrade/platform.sh b/target/linux/ipq806x/base-files/lib/upgrade/platform.sh
index 75a01b7..c0e19a1 100644
--- a/target/linux/ipq806x/base-files/lib/upgrade/platform.sh
+++ b/target/linux/ipq806x/base-files/lib/upgrade/platform.sh
@@ -16,4 +16,15 @@  platform_check_image() {
 	esac
 }
 
+platform_pre_upgrade() {
+	local board=$(ipq806x_board_name)
+
+	case "$board" in
+	AP148 |\
+	r7500)
+		nand_do_upgrade "$1"
+		;;
+	esac
+}
+
 # use default for platform_do_upgrade()