mbox series

[0/4] lantiq: fix VDSL2 vectoring

Message ID 20220313211438.1302111-1-jan@3e8.eu
Headers show
Series lantiq: fix VDSL2 vectoring | expand

Message

Jan Hoffmann March 13, 2022, 9:14 p.m. UTC 
For vectoring to work, the modem needs to send error reports to the
vectoring control entity at the carrier office. With Lantiq VR9/VR10
modems, a separate driver is needed to do this, which is currently
missing in OpenWrt.

In addition to that, the DSL connection may be interrupted at random
intervals due to insufficient locking in the MEI driver. While this is
technically not specific to vectoring, the additional interrupts from
the error reports seem to trigger the issue.

This patch set addresses both issues. The changes have been available
in the forum [0] for some time now. Multiple users who previously
experienced instability on vectoring-enabled VDSL2 lines have reported
that these patches actually allow a stable connection.

[0] https://forum.openwrt.org/t/vectoring-on-lantiq-vrx200-vr9-missing-callback-for-sending-error-samples/104046


Jan Hoffmann (4):
  ltq-vectoring: add driver
  ltq-vdsl-mei: enable vectoring error sample callback
  ltq-vdsl-app: set MAC address for vectoring error reports
  ltq-vdsl-mei: add locking to interrupt handler

 package/kernel/lantiq/ltq-vdsl-mei/Makefile   |   4 +-
 .../ltq-vdsl-mei/patches/100-compat.patch     |  11 --
 .../patches/200-interrupt-lock.patch          |  45 +++++++
 package/kernel/lantiq/ltq-vectoring/Makefile  |  61 +++++++++
 .../patches/001-fix-compile.patch             |  95 ++++++++++++++
 .../ltq-vectoring/patches/100-cleanup.patch   |  73 +++++++++++
 .../ltq-vectoring/patches/200-compat.patch    | 120 ++++++++++++++++++
 .../config/ltq-vdsl-app/files/dsl_control     |  20 ++-
 8 files changed, 410 insertions(+), 19 deletions(-)
 create mode 100644 package/kernel/lantiq/ltq-vdsl-mei/patches/200-interrupt-lock.patch
 create mode 100644 package/kernel/lantiq/ltq-vectoring/Makefile
 create mode 100644 package/kernel/lantiq/ltq-vectoring/patches/001-fix-compile.patch
 create mode 100644 package/kernel/lantiq/ltq-vectoring/patches/100-cleanup.patch
 create mode 100644 package/kernel/lantiq/ltq-vectoring/patches/200-compat.patch

Comments

Martin Blumenstingl March 21, 2022, 11:10 a.m. UTC | #1 
The sender domain has a DMARC Reject/Quarantine policy which disallows
sending mailing list messages using the original "From" header.

To mitigate this problem, the original message has been wrapped
automatically by the mailing list software.
Hi Jan,

On Sun, Mar 13, 2022 at 10:17 PM Jan Hoffmann <jan@3e8.eu> wrote:
>
> For vectoring to work, the modem needs to send error reports to the
> vectoring control entity at the carrier office. With Lantiq VR9/VR10
> modems, a separate driver is needed to do this, which is currently
> missing in OpenWrt.
>
> In addition to that, the DSL connection may be interrupted at random
> intervals due to insufficient locking in the MEI driver. While this is
> technically not specific to vectoring, the additional interrupts from
> the error reports seem to trigger the issue.
>
> This patch set addresses both issues. The changes have been available
> in the forum [0] for some time now. Multiple users who previously
> experienced instability on vectoring-enabled VDSL2 lines have reported
> that these patches actually allow a stable connection.
I haven't experienced this personally. Still thank you for documenting
and working on this!

> Jan Hoffmann (4):
>   ltq-vectoring: add driver
>   ltq-vdsl-mei: enable vectoring error sample callback
>   ltq-vdsl-app: set MAC address for vectoring error reports
>   ltq-vdsl-mei: add locking to interrupt handler
I have tested these patches for a few days and they don't break my
HH5A so this gets my:
Tested-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>


Best regards,
Martin