| Message ID | 20211003065350.1437-1-musashino.open@gmail.com |
|---|---|
| Headers | show |
| Series | realtek: add support for Panasonic Switch-M8eG PN28080K | expand |
Hi, On Sun, 2021-10-03 at 15:53 +0900, INAGAKI Hiroshi wrote: [...] > > INAGAKI Hiroshi (3): > realtek: enable pca953x driver for target > realtek: enable gpio-restart driver in target > realtek: add support for Panasonic Switch-M8eG PN28080K > > target/linux/realtek/config-5.10 | 4 + > target/linux/realtek/config-5.4 | 4 + > .../rtl8380_panasonic_m8eg-pn28080k.dts | 103 ++++++++ > .../rtl83xx_panasonic_mxxeg-pn28xx0k.dtsi | 216 +++++++++++++++++ > .../rtl8380_panasonic_m8eg-pn28080k.dts | 107 +++++++++ > .../rtl83xx_panasonic_mxxeg-pn28xx0k.dtsi | 220 ++++++++++++++++++ > target/linux/realtek/image/Makefile | 10 + > 7 files changed, 664 insertions(+) > create mode 100644 target/linux/realtek/dts-5.10/rtl8380_panasonic_m8eg-pn28080k.dts > create mode 100644 target/linux/realtek/dts-5.10/rtl83xx_panasonic_mxxeg-pn28xx0k.dtsi > create mode 100644 target/linux/realtek/dts-5.4/rtl8380_panasonic_m8eg-pn28080k.dts > create mode 100644 target/linux/realtek/dts-5.4/rtl83xx_panasonic_mxxeg-pn28xx0k.dtsi I guess this is more a question for the maintainers: Since the realtek target now uses the 5.10 kernel in master, does it still make sense to add support for 5.4? Hiroshi has backported the upstream drivers for 5.10 (thanks again!), so both kernel version now have different quirks. Personnaly, I would prefer not to have to put any energy in 5.4 anymore. Best, Sander
On 11/12/21 10:00 PM, Sander Vanheule wrote: > Hi, > > On Sun, 2021-10-03 at 15:53 +0900, INAGAKI Hiroshi wrote: > [...] > >> >> INAGAKI Hiroshi (3): >> realtek: enable pca953x driver for target >> realtek: enable gpio-restart driver in target >> realtek: add support for Panasonic Switch-M8eG PN28080K >> >> target/linux/realtek/config-5.10 | 4 + >> target/linux/realtek/config-5.4 | 4 + >> .../rtl8380_panasonic_m8eg-pn28080k.dts | 103 ++++++++ >> .../rtl83xx_panasonic_mxxeg-pn28xx0k.dtsi | 216 +++++++++++++++++ >> .../rtl8380_panasonic_m8eg-pn28080k.dts | 107 +++++++++ >> .../rtl83xx_panasonic_mxxeg-pn28xx0k.dtsi | 220 ++++++++++++++++++ >> target/linux/realtek/image/Makefile | 10 + >> 7 files changed, 664 insertions(+) >> create mode 100644 target/linux/realtek/dts-5.10/rtl8380_panasonic_m8eg-pn28080k.dts >> create mode 100644 target/linux/realtek/dts-5.10/rtl83xx_panasonic_mxxeg-pn28xx0k.dtsi >> create mode 100644 target/linux/realtek/dts-5.4/rtl8380_panasonic_m8eg-pn28080k.dts >> create mode 100644 target/linux/realtek/dts-5.4/rtl83xx_panasonic_mxxeg-pn28xx0k.dtsi > > I guess this is more a question for the maintainers: Since the realtek target now uses the > 5.10 kernel in master, does it still make sense to add support for 5.4? Hiroshi has > backported the upstream drivers for 5.10 (thanks again!), so both kernel version now have > different quirks. Personnaly, I would prefer not to have to put any energy in 5.4 anymore. The realtek target already has KERNEL_PATCHVER set to 5.10 now. You do not have to add support for kernel 5.4 in your patches any more, if you want to it is fine with me, but we will probability delete the support for kernel 5.4 in 1 or 2 months anyway. If you need special workarounds for kernel 5.4 I would suggest to go with kernel 5.10 only. @Hiroshi I added some of the GPIO patches from Sander, could you please rebase your patch on top of that. Hauke
Hi Hauke, Thank you for the guidance. On 2021/11/30 6:37, Hauke Mehrtens wrote: > On 11/12/21 10:00 PM, Sander Vanheule wrote: >> Hi, >> >> On Sun, 2021-10-03 at 15:53 +0900, INAGAKI Hiroshi wrote: >> [...] >> >>> >>> INAGAKI Hiroshi (3): >>> realtek: enable pca953x driver for target >>> realtek: enable gpio-restart driver in target >>> realtek: add support for Panasonic Switch-M8eG PN28080K >>> >>> target/linux/realtek/config-5.10 | 4 + >>> target/linux/realtek/config-5.4 | 4 + >>> .../rtl8380_panasonic_m8eg-pn28080k.dts | 103 ++++++++ >>> .../rtl83xx_panasonic_mxxeg-pn28xx0k.dtsi | 216 >>> +++++++++++++++++ >>> .../rtl8380_panasonic_m8eg-pn28080k.dts | 107 +++++++++ >>> .../rtl83xx_panasonic_mxxeg-pn28xx0k.dtsi | 220 >>> ++++++++++++++++++ >>> target/linux/realtek/image/Makefile | 10 + >>> 7 files changed, 664 insertions(+) >>> create mode 100644 >>> target/linux/realtek/dts-5.10/rtl8380_panasonic_m8eg-pn28080k.dts >>> create mode 100644 >>> target/linux/realtek/dts-5.10/rtl83xx_panasonic_mxxeg-pn28xx0k.dtsi >>> create mode 100644 >>> target/linux/realtek/dts-5.4/rtl8380_panasonic_m8eg-pn28080k.dts >>> create mode 100644 >>> target/linux/realtek/dts-5.4/rtl83xx_panasonic_mxxeg-pn28xx0k.dtsi >> >> I guess this is more a question for the maintainers: Since the >> realtek target now uses the >> 5.10 kernel in master, does it still make sense to add support for >> 5.4? Hiroshi has >> backported the upstream drivers for 5.10 (thanks again!), so both >> kernel version now have >> different quirks. Personnaly, I would prefer not to have to put any >> energy in 5.4 anymore. > > The realtek target already has KERNEL_PATCHVER set to 5.10 now. You > do not have to add support for kernel 5.4 in your patches any more, > if you want to it is fine with me, but we will probability delete > the support for kernel 5.4 in 1 or 2 months anyway. > > If you need special workarounds for kernel 5.4 I would suggest to go > with kernel 5.10 only. > @Hiroshi I added some of the GPIO patches from Sander, could you > please rebase your patch on top of that. I see, OK. I'm preparing the v2 patch rebased from master, without 5.4 changes :) > > Hauke Regards, Hiroshi