mbox series

[OpenWrt-Devel,0/6] uclient: Handle memory allocation failures

Message ID 20180218033640.17715-1-tobleminer@gmail.com
Headers show
Series uclient: Handle memory allocation failures | expand

Message

Tobias Schramm Feb. 18, 2018, 3:36 a.m. UTC
Hi,

this series of patches adds some code to handle memory allocation failures
without crashing.

Previously a lot of memory allocations were not checked for NULL ptrs
resulting in nullpointer dereferences if (lib)uclient ran out of memory

Regards

Tobias Schramm

Tobias Schramm (6):
  uclient-fetch: Check for nullpointer returned by open_output_file
  uclient-http: basic auth: Handle memory allocation failure
  uclient-http: auth digest: Handle multiple possible memory allocation
    failures
  uclient-http: Handle memory allocation failure
  uclient-utils: Handle memory allocation failure for url file name
  uclient: Handle memory allocation failure for url

 uclient-fetch.c |  5 +++++
 uclient-http.c  | 53 ++++++++++++++++++++++++++++++++++++++++++-----------
 uclient-utils.c |  8 ++++++--
 uclient.c       |  3 +++
 4 files changed, 56 insertions(+), 13 deletions(-)

Comments

John Crispin Feb. 18, 2018, 10:20 a.m. UTC | #1
On 18/02/18 04:36, Tobias Schramm wrote:
> Hi,
>
> this series of patches adds some code to handle memory allocation failures
> without crashing.
>
> Previously a lot of memory allocations were not checked for NULL ptrs
> resulting in nullpointer dereferences if (lib)uclient ran out of memory
>
> Regards
>
> Tobias Schramm

Hi Tobias,

thanks for the fixes, looks good overall, please also add a very short 
description to each one of the patches.

     John

>
> Tobias Schramm (6):
>    uclient-fetch: Check for nullpointer returned by open_output_file
>    uclient-http: basic auth: Handle memory allocation failure
>    uclient-http: auth digest: Handle multiple possible memory allocation
>      failures
>    uclient-http: Handle memory allocation failure
>    uclient-utils: Handle memory allocation failure for url file name
>    uclient: Handle memory allocation failure for url
>
>   uclient-fetch.c |  5 +++++
>   uclient-http.c  | 53 ++++++++++++++++++++++++++++++++++++++++++-----------
>   uclient-utils.c |  8 ++++++--
>   uclient.c       |  3 +++
>   4 files changed, 56 insertions(+), 13 deletions(-)
>