| Message ID | 03b3c32f-dcfd-54c1-b959-8067893c0758@yadro.com |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [linux,dev-4.7,1/2] mtd: spi-nor: fix options for mx66l51235f | expand |
On 08/15/2018 05:13 PM, Alexander Amelkin wrote: > Currently in driver spi-nor there is a line for mx66l51235l. > According to Macronix site there is no such part number. > The chip detected as such is actually mx66l51235f. > > According to the datasheet for mx66l51235f, > "The device default is in 24-bit address mode" (section 9-10). > Hence we removed SPI_NOR_4B_OPCODES option with this commit. > > Signed-off-by: Alexander Soldatov <a.soldatov@yadro.com> It fixes commit d342b6a973af ("mtd: spi-nor: enable 4B opcodes for mx66l51235l") You should send this one to the linux-mtd@lists.infradead.org mailing list. Reviewed-by: Cédric Le Goater <clg@kaod.org> Thanks, C. > --- > drivers/mtd/spi-nor/spi-nor.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c > index 5bfa36e..e9f4447 100644 > --- a/drivers/mtd/spi-nor/spi-nor.c > +++ b/drivers/mtd/spi-nor/spi-nor.c > @@ -1068,7 +1068,7 @@ static const struct flash_info spi_nor_ids[] = { > { "mx25l25635e", INFO(0xc22019, 0, 64 * 1024, 512, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, > { "mx25u25635f", INFO(0xc22539, 0, 64 * 1024, 512, SECT_4K | SPI_NOR_4B_OPCODES) }, > { "mx25l25655e", INFO(0xc22619, 0, 64 * 1024, 512, 0) }, > - { "mx66l51235l", INFO(0xc2201a, 0, 64 * 1024, 1024, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) }, > + { "mx66l51235f", INFO(0xc2201a, 0, 64 * 1024, 1024, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, > { "mx66u51235f", INFO(0xc2253a, 0, 64 * 1024, 1024, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) }, > { "mx66l1g45g", INFO(0xc2201b, 0, 64 * 1024, 2048, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, > { "mx66l1g55g", INFO(0xc2261b, 0, 64 * 1024, 2048, SPI_NOR_QUAD_READ) }, >
I think the mail subject should be patch linux dev-4.17, instead of dev-4.7. But anyway this is better to be submitted to upstream. Reviewed-by: Lei YU <mine260309@gmail.com> On Wed, Aug 15, 2018 at 11:14 PM Alexander Amelkin <a.amelkin@yadro.com> wrote: > > Currently in driver spi-nor there is a line for mx66l51235l. > According to Macronix site there is no such part number. > The chip detected as such is actually mx66l51235f. > > According to the datasheet for mx66l51235f, > "The device default is in 24-bit address mode" (section 9-10). > Hence we removed SPI_NOR_4B_OPCODES option with this commit. > > Signed-off-by: Alexander Soldatov <a.soldatov@yadro.com> > --- > drivers/mtd/spi-nor/spi-nor.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c > index 5bfa36e..e9f4447 100644 > --- a/drivers/mtd/spi-nor/spi-nor.c > +++ b/drivers/mtd/spi-nor/spi-nor.c > @@ -1068,7 +1068,7 @@ static const struct flash_info spi_nor_ids[] = { > { "mx25l25635e", INFO(0xc22019, 0, 64 * 1024, 512, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, > { "mx25u25635f", INFO(0xc22539, 0, 64 * 1024, 512, SECT_4K | SPI_NOR_4B_OPCODES) }, > { "mx25l25655e", INFO(0xc22619, 0, 64 * 1024, 512, 0) }, > - { "mx66l51235l", INFO(0xc2201a, 0, 64 * 1024, 1024, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) }, > + { "mx66l51235f", INFO(0xc2201a, 0, 64 * 1024, 1024, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, > { "mx66u51235f", INFO(0xc2253a, 0, 64 * 1024, 1024, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) }, > { "mx66l1g45g", INFO(0xc2201b, 0, 64 * 1024, 2048, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, > { "mx66l1g55g", INFO(0xc2261b, 0, 64 * 1024, 2048, SPI_NOR_QUAD_READ) }, > -- > 2.7.4 > >
On Thu, 16 Aug 2018 at 04:27, Cédric Le Goater <clg@kaod.org> wrote: > > On 08/15/2018 05:13 PM, Alexander Amelkin wrote: > > Currently in driver spi-nor there is a line for mx66l51235l. > > According to Macronix site there is no such part number. > > The chip detected as such is actually mx66l51235f. > > > > According to the datasheet for mx66l51235f, > > "The device default is in 24-bit address mode" (section 9-10). > > Hence we removed SPI_NOR_4B_OPCODES option with this commit. > > > > Signed-off-by: Alexander Soldatov <a.soldatov@yadro.com> > > It fixes commit d342b6a973af ("mtd: spi-nor: enable 4B opcodes for mx66l51235l") > > You should send this one to the linux-mtd@lists.infradead.org > mailing list. > > > Reviewed-by: Cédric Le Goater <clg@kaod.org> Agreed. Please send this one to the upstream list, with Cc: stable and Fixes: tags. Thanks for sending the patch out. I have applied this and the other one to dev-4.17 and pushed to github. We will get this merged into openbmc once the backlog of kernel bumps I have out there are merged. Cheers, Joel
diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c index 5bfa36e..e9f4447 100644 --- a/drivers/mtd/spi-nor/spi-nor.c +++ b/drivers/mtd/spi-nor/spi-nor.c @@ -1068,7 +1068,7 @@ static const struct flash_info spi_nor_ids[] = { { "mx25l25635e", INFO(0xc22019, 0, 64 * 1024, 512, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, { "mx25u25635f", INFO(0xc22539, 0, 64 * 1024, 512, SECT_4K | SPI_NOR_4B_OPCODES) }, { "mx25l25655e", INFO(0xc22619, 0, 64 * 1024, 512, 0) }, - { "mx66l51235l", INFO(0xc2201a, 0, 64 * 1024, 1024, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) }, + { "mx66l51235f", INFO(0xc2201a, 0, 64 * 1024, 1024, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, { "mx66u51235f", INFO(0xc2253a, 0, 64 * 1024, 1024, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) }, { "mx66l1g45g", INFO(0xc2201b, 0, 64 * 1024, 2048, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, { "mx66l1g55g", INFO(0xc2261b, 0, 64 * 1024, 2048, SPI_NOR_QUAD_READ) },
Currently in driver spi-nor there is a line for mx66l51235l. According to Macronix site there is no such part number. The chip detected as such is actually mx66l51235f. According to the datasheet for mx66l51235f, "The device default is in 24-bit address mode" (section 9-10). Hence we removed SPI_NOR_4B_OPCODES option with this commit. Signed-off-by: Alexander Soldatov <a.soldatov@yadro.com> --- drivers/mtd/spi-nor/spi-nor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)