diff mbox series

[ulogd2,13/13] build: bump autoconf version to 2.71

Message ID 20211030160141.1132819-14-jeremy@azazel.net
State Changes Requested
Delegated to: Pablo Neira
Headers show
Series Build Improvements | expand

Commit Message

Jeremy Sowden Oct. 30, 2021, 4:01 p.m. UTC 
Signed-off-by: Jeremy Sowden <jeremy@azazel.net>
---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jan Engelhardt Oct. 30, 2021, 5:21 p.m. UTC | #1 
On Saturday 2021-10-30 18:01, Jeremy Sowden wrote:

>diff --git a/configure.ac b/configure.ac
>index ea245dae3796..8d18cc6eb7fb 100644
>--- a/configure.ac
>+++ b/configure.ac
>@@ -1,6 +1,6 @@
> dnl Process this file with autoconf to produce a configure script.
> AC_INIT([ulogd], [2.0.7])
>-AC_PREREQ([2.50])
>+AC_PREREQ([2.71])
> AC_CONFIG_AUX_DIR([build-aux])
> AM_INIT_AUTOMAKE([-Wall foreign tar-pax no-dist-gzip dist-bzip2 1.10b subdir-objects])
> AC_CONFIG_HEADERS([config.h])

That's not a good move; it puts unnecessary stones on the road to 
building from git (i.e. with full autoreconf) on e.g. SUSE 15.X (and some 
other distros I am sure) that only have autoconf 2.69 or .65 or whatever.

Unless there is a _specific new shiny m4 macro_ that is invoked somewhere,
I cannot see a reason to gratuitiously bump PREREQ.
Jeremy Sowden Nov. 6, 2021, 11:07 a.m. UTC | #2 
On 2021-10-30, at 19:21:07 +0200, Jan Engelhardt wrote:
> On Saturday 2021-10-30 18:01, Jeremy Sowden wrote:
>
> >diff --git a/configure.ac b/configure.ac
> >index ea245dae3796..8d18cc6eb7fb 100644
> >--- a/configure.ac
> >+++ b/configure.ac
> >@@ -1,6 +1,6 @@
> > dnl Process this file with autoconf to produce a configure script.
> > AC_INIT([ulogd], [2.0.7])
> >-AC_PREREQ([2.50])
> >+AC_PREREQ([2.71])
> > AC_CONFIG_AUX_DIR([build-aux])
> > AM_INIT_AUTOMAKE([-Wall foreign tar-pax no-dist-gzip dist-bzip2
> 1.10b subdir-objects])
> > AC_CONFIG_HEADERS([config.h])
>
> That's not a good move; it puts unnecessary stones on the road to
> building from git (i.e. with full autoreconf) on e.g. SUSE 15.X (and
> some other distros I am sure) that only have autoconf 2.69 or .65 or
> whatever.

Did wonder if bumping to 2.71 might be a bit aggressive. :)

> Unless there is a _specific new shiny m4 macro_ that is invoked
> somewhere, I cannot see a reason to gratuitiously bump PREREQ.

Fair enough.  Don't seem to be any signficant differences in the
generated files.  Will drop this in v2.

J.
diff mbox series

Patch

diff --git a/configure.ac b/configure.ac
index ea245dae3796..8d18cc6eb7fb 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1,6 +1,6 @@ 
 dnl Process this file with autoconf to produce a configure script.
 AC_INIT([ulogd], [2.0.7])
-AC_PREREQ([2.50])
+AC_PREREQ([2.71])
 AC_CONFIG_AUX_DIR([build-aux])
 AM_INIT_AUTOMAKE([-Wall foreign tar-pax no-dist-gzip dist-bzip2 1.10b subdir-objects])
 AC_CONFIG_HEADERS([config.h])