diff mbox series

[ulogd2,10/13] build: update obsolete autoconf macros

Message ID 20211030160141.1132819-11-jeremy@azazel.net
State Changes Requested
Delegated to: Pablo Neira
Headers show
Series Build Improvements | expand

Commit Message

Jeremy Sowden Oct. 30, 2021, 4:01 p.m. UTC 
`AC_CONFIG_HEADER` has been superseded by `+AC_CONFIG_HEADERS`.

`AC_PROG_LIBTOOL` has been superseded by `LT_INIT`.

`AC_DISABLE_STATIC` can be replaced by an argument to `LT_INIT`.

`AC_HEADER_STDC` is obsolete.

Signed-off-by: Jeremy Sowden <jeremy@azazel.net>
---
 configure.ac | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

Jan Engelhardt Oct. 30, 2021, 5:16 p.m. UTC | #1 
On Saturday 2021-10-30 18:01, Jeremy Sowden wrote:
>+++ b/configure.ac
>@@ -3,7 +3,7 @@ AC_INIT([ulogd], [2.0.7])
> AC_PREREQ([2.50])
> AC_CONFIG_AUX_DIR([build-aux])
> AM_INIT_AUTOMAKE([-Wall foreign tar-pax no-dist-gzip dist-bzip2 1.10b subdir-objects])
>-AC_CONFIG_HEADER([config.h])
>+AC_CONFIG_HEADERS([config.h])
> AC_CONFIG_MACRO_DIR([m4])
> 
> m4_ifdef([AM_PROG_AR], [AM_PROG_AR])
>@@ -14,8 +14,7 @@ dnl Checks for programs.
> AC_PROG_MAKE_SET
> AC_PROG_CC
> AC_PROG_INSTALL
>-AC_DISABLE_STATIC
>-AC_PROG_LIBTOOL
>+LT_INIT([disable_static])

This ought to be disable-static. Dash, not underscore.
Jeremy Sowden Nov. 6, 2021, 11:07 a.m. UTC | #2 
On 2021-10-30, at 19:16:27 +0200, Jan Engelhardt wrote:
> On Saturday 2021-10-30 18:01, Jeremy Sowden wrote:
> > +++ b/configure.ac
> > @@ -3,7 +3,7 @@ AC_INIT([ulogd], [2.0.7])
> >  AC_PREREQ([2.50])
> >  AC_CONFIG_AUX_DIR([build-aux])
> >  AM_INIT_AUTOMAKE([-Wall foreign tar-pax no-dist-gzip dist-bzip2
> 1.10b subdir-objects])
> > -AC_CONFIG_HEADER([config.h])
> > +AC_CONFIG_HEADERS([config.h])
> >  AC_CONFIG_MACRO_DIR([m4])
> >
> >  m4_ifdef([AM_PROG_AR], [AM_PROG_AR])
> > @@ -14,8 +14,7 @@ dnl Checks for programs.
> >  AC_PROG_MAKE_SET
> >  AC_PROG_CC
> >  AC_PROG_INSTALL
> > -AC_DISABLE_STATIC
> > -AC_PROG_LIBTOOL
> > +LT_INIT([disable_static])
>
> This ought to be disable-static. Dash, not underscore.

Will fix in v2.

J.
diff mbox series

Patch

diff --git a/configure.ac b/configure.ac
index f7d6b50c47f5..2dfeee6aa4cb 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3,7 +3,7 @@  AC_INIT([ulogd], [2.0.7])
 AC_PREREQ([2.50])
 AC_CONFIG_AUX_DIR([build-aux])
 AM_INIT_AUTOMAKE([-Wall foreign tar-pax no-dist-gzip dist-bzip2 1.10b subdir-objects])
-AC_CONFIG_HEADER([config.h])
+AC_CONFIG_HEADERS([config.h])
 AC_CONFIG_MACRO_DIR([m4])
 
 m4_ifdef([AM_PROG_AR], [AM_PROG_AR])
@@ -14,8 +14,7 @@  dnl Checks for programs.
 AC_PROG_MAKE_SET
 AC_PROG_CC
 AC_PROG_INSTALL
-AC_DISABLE_STATIC
-AC_PROG_LIBTOOL
+LT_INIT([disable_static])
 
 dnl Checks for libraries.
 AC_SEARCH_LIBS([dlopen], [dl], [libdl_LIBS="$LIBS"; LIBS=""])
@@ -23,7 +22,6 @@  AC_SUBST([libdl_LIBS])
 
 dnl Checks for header files.
 AC_HEADER_DIRENT
-AC_HEADER_STDC
 AC_CHECK_HEADERS(fcntl.h unistd.h)
 
 dnl Checks for typedefs, structures, and compiler characteristics.