diff mbox

[NETLINK] : With opcode INET_DIAG_BC_S_LE dport was compared in inet_diag_bc_run()

Message ID 4B56291D.2000304@gmail.com
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

roel kluin Jan. 19, 2010, 9:50 p.m. UTC 
The s-port should be compared.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
I presume?

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

David Miller Jan. 19, 2010, 10:12 p.m. UTC | #1 
From: Roel Kluin <roel.kluin@gmail.com>
Date: Tue, 19 Jan 2010 22:50:21 +0100

> The s-port should be compared.
> 
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> I presume?

Yep, looks good.

Excellent catch, applied, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/net/ipv4/inet_diag.c b/net/ipv4/inet_diag.c
index bdb78dd..1aaa811 100644
--- a/net/ipv4/inet_diag.c
+++ b/net/ipv4/inet_diag.c
@@ -368,7 +368,7 @@  static int inet_diag_bc_run(const void *bc, int len,
 			yes = entry->sport >= op[1].no;
 			break;
 		case INET_DIAG_BC_S_LE:
-			yes = entry->dport <= op[1].no;
+			yes = entry->sport <= op[1].no;
 			break;
 		case INET_DIAG_BC_D_GE:
 			yes = entry->dport >= op[1].no;